Fix duplicated probe not instrumented#4665
Merged
Merged
Conversation
copy a log probe when receive new configuration to detect changes for a duplicated probe Since we keep the same instance of deserialized probe and for duplicated we add them in the log definition as additional probes, changes are not detected with ConfigurationComparer
ojung
approved these changes
Feb 6, 2023
ojung
left a comment
ojung
left a comment
Member
There was a problem hiding this comment.
Nice, I think this will help down the line 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
copy a log probe when receive new configuration to detect changes for a duplicated probe
Motivation
Since we keep the same instance of deserialized probe and for duplicated we add them in the log definition as additional probes, changes are not detected with ConfigurationComparer
Additional Notes