remove debugger check for config endpoint at bootstrap#4657
Merged
Conversation
shatzi
changed the title
jpbempel
approved these changes
Feb 4, 2023
jpbempel
left a comment
jpbempel
left a comment
Member
There was a problem hiding this comment.
yes makes sense 👍 .
Before we were handling completely the access to RemoteConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
remove disabling the DebugerAgent if datadog agent config was not found at boot time.
Unlike other endpoints, configEndpoint get attached after datadog agent remote config client started.
The solution is to remove this check and let configurationPoller discovery that endpoint at later point in time.
Motivation
Our customer have setup that start both library and datadog-agent almost at the same time.
That causes DebuggerAgent to cancel it boot sequence because config endpoint was not found.
On the other hand, ASM products doesn't check for config endpoint and register itself.
Therefore, configurationPoller retried agent discovery until it find the configEndpoint and start getting configurations.
Additional Notes
We might also want to disable the check for debuggerProxy endpoint. And we should delay this discovery until we get a snapshot to send and drop the snapshot buffer if no endpoint was discovered.