Add support for undertow-jakarta-servlet#4634
Merged
Merged
Conversation
amarziali
force-pushed
the
andrea.marziali/undertow-jafkarta
branch
2 times, most recently
from
February 1, 2023 10:52
7c1b603 to
8ee3966
Compare
richardstartin
approved these changes
Feb 1, 2023
richardstartin
left a comment
richardstartin
left a comment
Contributor
There was a problem hiding this comment.
Looks good, please get a tracing review before merging
amarziali
force-pushed
the
andrea.marziali/undertow-jafkarta
branch
from
February 1, 2023 11:24
8ee3966 to
bc1583b
Compare
amarziali
force-pushed
the
andrea.marziali/undertow-jafkarta
branch
from
February 1, 2023 11:53
bc1583b to
dbe07f2
Compare
devinsba
approved these changes
Feb 2, 2023
devinsba
left a comment
devinsba
left a comment
Contributor
There was a problem hiding this comment.
Looks right to me. I assume this is mostly a direct copy of the servlet related code from 2.0 with just the servlet packages changed?
Contributor
Author
Thanks for the review. It's a copy from the undertow package rather since it was tied to javax.servlet. But undertow can also work with the jakarta variant and this was not supported |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add compatibility with undertow-jakarta-servlet (undertow-2.2+)
Motivation
Additional Notes