Skip to content

Proposal for standardized storage of installable artifacts#4610

Merged
robertomonteromiguel merged 38 commits intomasterfrom
robertomonteromiguel/docker_base_image_poc_v2
Feb 10, 2023
Merged

Proposal for standardized storage of installable artifacts#4610
robertomonteromiguel merged 38 commits intomasterfrom
robertomonteromiguel/docker_base_image_poc_v2

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Contributor

@robertomonteromiguel robertomonteromiguel commented Jan 27, 2023

What Does This Do

For internal tooling needs (e.g. System Tests), and for having consistent and reliable experience fetching the tracer artifacts. We can leverage a simplified approach of OCI Artifacts to store the final build artifacts (e.g. dd-java-agent.jar) in GitHub Container Registry.

From GitLab we will generate the docker images with last release and last snapshot on every commit in master branch.

see also: https://docs.google.com/document/d/1HbMGgZFRnIYjfnXGJGyk0LCwWs2op12R0BE58wma448/edit#

Motivation

Simplify the mechanisms to download snapshots and releases of the tracer. Simplify tests automation.

Additional Notes

@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner January 27, 2023 09:51
@robertomonteromiguel robertomonteromiguel marked this pull request as draft January 27, 2023 09:51
@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Jan 27, 2023
Comment thread .gitlab-ci.yml Outdated
@robertomonteromiguel robertomonteromiguel changed the title Create docker images with last release and last snapshot of the tracer Proposal for standardized storage of installable artifacts Feb 1, 2023
@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review February 3, 2023 09:31
Comment thread tooling/ci/Dockerfile Outdated
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the tracer part.
Won't judge for the whole OCI artifact initiative :)

By the way, if the commits could be squashed before merging 🙏

Copy link
Copy Markdown
Contributor

@pawelchcki pawelchcki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@PerfectSlayer

Won't judge for the whole OCI artifact initiative :)

At this point we're POC'ing it - to see how much it improves our workflow etc. We'll see 🤷‍♂️

@robertomonteromiguel robertomonteromiguel merged commit 75d93fd into master Feb 10, 2023
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/docker_base_image_poc_v2 branch February 10, 2023 13:20
@github-actions github-actions Bot added this to the 1.9.0 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants