Support spring web 6 / boot 3#4605
Merged
Merged
Conversation
mcculls
reviewed
Jan 26, 2023
amarziali
force-pushed
the
andrea.marziali/springweb6
branch
from
January 27, 2023 09:25
305c0c4 to
2929f81
Compare
amarziali
force-pushed
the
andrea.marziali/springweb6
branch
from
January 27, 2023 15:23
4820c3f to
74eec86
Compare
devinsba
approved these changes
Jan 30, 2023
devinsba
left a comment
devinsba
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me. AppSec should verify their classes look good too
cataphract
approved these changes
Jan 31, 2023
4 tasks
amarziali
force-pushed
the
andrea.marziali/springweb6
branch
2 times, most recently
from
February 1, 2023 10:40
a7aa4ff to
d508c76
Compare
… 9.4 so it can read Java 17 classes)
…entLruCache and com.fasterxml.jackson.databind.util.internal.PrivateMaxEntriesMap as we don't need to trace them
amarziali
force-pushed
the
andrea.marziali/springweb6
branch
from
February 1, 2023 10:44
d508c76 to
d0b272f
Compare
amarziali
force-pushed
the
andrea.marziali/springweb6
branch
from
February 1, 2023 11:59
f94341a to
84a7abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for spring web 6. Old instrumentation was not compatible because of jakarta EE 9 package changes.
Some side notes:
FIXMEon tests. Some stuff are usually addressed by servlet instrumentation (that's missing because we do not yet support servlet 5). They are minor missesMotivation
Additional Notes