Blocking on netty and grizzly#4581
Merged
Merged
Conversation
cataphract
force-pushed
the
glopes/block-vertx-grizzly
branch
from
January 20, 2023 16:27
d438f53 to
c247788
Compare
smola
approved these changes
Jan 23, 2023
smola
left a comment
smola
left a comment
Member
There was a problem hiding this comment.
LGTM when tests and system-tests for these variants pass.
cataphract
force-pushed
the
glopes/block-vertx-grizzly
branch
4 times, most recently
from
January 25, 2023 12:08
2289e1b to
c6938d5
Compare
Contributor
Author
|
Now relies fully on the netty instrumentation to block on vertx and ratpack |
cataphract
force-pushed
the
glopes/block-vertx-grizzly
branch
from
January 25, 2023 13:22
c6938d5 to
9ce7335
Compare
cataphract
force-pushed
the
glopes/block-vertx-grizzly
branch
from
January 25, 2023 14:23
9ce7335 to
af20d71
Compare
smola
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for blocking requests on netty and grizzly (includes Vert.x and ratpack).