Add process_id to all root spans#4397
Merged
zarirhamza merged 10 commits intomasterfrom Dec 8, 2022
Merged
Conversation
devinsba
previously requested changes
Dec 7, 2022
Contributor
devinsba
left a comment
devinsba
left a comment
There was a problem hiding this comment.
We should undo the changes to newHashMap()
Contributor
Author
|
All tests fixed and ready to be merged |
bantonsson
reviewed
Dec 8, 2022
bantonsson
approved these changes
Dec 8, 2022
mcculls
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Utiltizes PidHelper changes to add process_id tag with the value of PID to all root spans.
Motivation
Part of larger initiative to have similar tags and value across all tracers. Java tracer did not have process_id compared to other languages and thus has been added.