Add OTLP Trace Metrics Configs#11653
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cfff78477
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
mhlidd
added
type: feature
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7224bc2e0f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tracesSpanMetricsEnabled = | ||
| configProvider.getBoolean( | ||
| TRACES_SPAN_METRICS_ENABLED, | ||
| isTraceOtlpExporterEnabled() && isMetricsOtlpExporterEnabled()); |
There was a problem hiding this comment.
When a deployment sets DD_TRACE_OTEL_EXPORTER=otlp and DD_METRICS_OTEL_EXPORTER=otlp but leaves DD_METRICS_OTEL_ENABLED at its default false, this default evaluates to true even though the OTLP metrics pipeline is not enabled. That contradicts the tri-state comment's "OTLP metrics export" condition and can make consumers of isTracesSpanMetricsEnabled() emit span metrics without an active metrics exporter; the default should also require isMetricsOtelEnabled().
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Low risk since DD OTel configs are "internal", but fixed in ead8676 since it is a possibility.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ead86767cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
init adding tests Merge branch 'master' into mhlidd/otlp_trace_metrics_config bugfix fixing issue where internal DD configs are used instead of OTel equivalents Co-authored-by: devflow.devflow-routing-intake <[email protected]>
2 participants
What Does This Do
This PR introduces OTLP Trace Metrics Configs that set the baseline for enabling this feature in future PRs.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]