Skip to content

Fix Spring MethodParameters detection#11647

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
jpbempel/fix-spring-detection
Jun 15, 2026
Merged

Fix Spring MethodParameters detection#11647
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
jpbempel/fix-spring-detection

Conversation

@jpbempel

@jpbempel jpbempel commented Jun 15, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Member

What Does This Do

Avoid throwing an exception if Spring is not found in loaded classes Introduced an enum for reporting back result state and use UNKNOWN to fallback to another detection method.

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: DEBUG-5725

@jpbempel
Fix Spring MethodParameters detection
517f299 
Avoid throwing an exception if Spring is not found in loaded classes
Introduced an enum for reporting back result state and use UNKNOWN to
fallback to another detection method.
@jpbempel
jpbempel requested a review from a team as a code owner June 15, 2026 13:57
@jpbempel
jpbempel requested review from tylfin and removed request for a team June 15, 2026 13:57
@jpbempel jpbempel added type: bug fix Bug fix comp: debugger Dynamic Instrumentation labels Jun 15, 2026
@datadog-prod-us1-3

This comment has been minimized.

Sign in to view
@pr-commenter

pr-commenter Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1781534681 1781535027
end_time 2026-06-15T14:46:07 2026-06-15T14:51:53
git_branch master jpbempel/fix-spring-detection
git_commit_sha da24e73 5197709
start_time 2026-06-15T14:44:42 2026-06-15T14:50:28
See matching parameters
Baseline Candidate
ci_job_id 1771120256 1771120256
ci_pipeline_id 118821808 118821808
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1781533839 1781533839

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-15.703µs; +20.398µs] or [-5.370%; +6.976%]		 unstable
[-26.097µs; +30.033µs] or [-7.823%; +9.003%]		 unstable
[-35.012µs; +40.325µs] or [-10.053%; +11.579%]		 unstable
[-166.929µs; +35.705µs] or [-12.955%; +2.771%]		 same
scenario:basic same same same unstable
[-434.470µs; -183.966µs] or [-34.745%; -14.712%]		 same
scenario:loop same unsure
[+1.184µs; +12.107µs] or [+0.013%; +0.135%]		 same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (333.602 µs) : 310, 357
.   : milestone, 334,
basic (296.058 µs) : 290, 302
.   : milestone, 296,
loop (8.977 ms) : 8972, 8983
.   : milestone, 8977,
section candidate
noprobe (335.57 µs) : 306, 365
.   : milestone, 336,
basic (296.561 µs) : 291, 302
.   : milestone, 297,
loop (8.984 ms) : 8979, 8989
.   : milestone, 8984,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 333.602 µs [309.709 µs, 357.495 µs]
basic 296.058 µs [289.658 µs, 302.457 µs]
loop 8.977 ms [8.972 ms, 8.983 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 335.57 µs [306.37 µs, 364.77 µs]
basic 296.561 µs [290.709 µs, 302.413 µs]
loop 8.984 ms [8.979 ms, 8.989 ms]

@dd-octo-sts

dd-octo-sts Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.75 s 14.62 s [-0.1%; +1.9%] (no difference)
startup:insecure-bank:tracing:Agent 13.65 s 13.66 s [-0.9%; +0.8%] (no difference)
startup:petclinic:appsec:Agent 17.37 s 17.22 s [+0.2%; +1.6%] (maybe worse)
startup:petclinic:iast:Agent 17.29 s 17.46 s [-1.9%; -0.0%] (maybe better)
startup:petclinic:profiling:Agent 17.38 s 16.55 s [+0.9%; +9.2%] (maybe worse)
startup:petclinic:sca:Agent 17.38 s 17.26 s [-0.2%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.48 s 16.77 s [-2.8%; -0.7%] (maybe better)

Commit: 51977092 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jpbempel
jpbempel added this pull request to the merge queue Jun 15, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-15 15:28:51 UTC ℹ️ Start processing command /merge

2026-06-15 15:28:57 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-06-15 16:39:27 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 15, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 08697e5 into master Jun 15, 2026
589 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jpbempel/fix-spring-detection branch June 15, 2026 16:39
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes
@tylfin tylfin tylfin approved these changes

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug fix Bug fix

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel @bric3 @tylfin