What Does This Do

This PR blocks async propagations around the connection boundary in lettuce. Previously, the latestDepTest had a strictTraceWrites set to false since continuations were leaked from few tests.

On a failed Redis connection, RedisHandshakeHandler.channelRegistered registers a thenAccept on the handshake future, which is then abandoned.

 handshakeFuture.thenAccept(ignore -> {
            timeoutHandle.cancel();
        });

So the captured continuation is never resolved. Under strict trace writes this discards spans, which is why the Lettuce tests carried a useStrictTraceWrites(false) workaround.

Disabling the async propagation on this little spot prevents this.

Follows the temporal capture events happened in failed tests

gantt
  title Scope continuations (30 total, 1 leaked, 0 late, 0 double)
  dateFormat x
  axisFormat %Lms
  section Test worker
    cap #0 AbstractRedisClient.initializeChannelAsync :milestone, 0, 0
    cap #14 AbstractRedisAsyncCommands.dispatch :milestone, 6, 6
    cap #19 AbstractRedisClient.initializeChannelAsync :milestone, 10, 10
    cap #23 DefaultConnectionFuture.thenApply :milestone, 10, 10
  section lettuce-nioEventLoop-10-1
    cap #9 RedisHandshakeHandler.channelRegistered :milestone, 2, 2
    #9 fin RedisHandshakeHandler.succeed :done, 6, 7
    #14 fin AsyncCommand.completeResult :done, 7, 8
  section lettuce-nioEventLoop-13-1
    #19 fin AbstractRedisClient.lambda$initializeChannelAsync0$6 :done, 12, 13
    #28 LEAK cap RedisHandshakeHandler.channelRegistered :crit, 10, 12
    cap #29 PromiseTask.<init> :milestone, 10, 10
    #29 fin PromiseTask.run :done, 11, 12

Motivation

Additional Notes

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Add your completed PR to the merge queue by commenting /merge. You can also:
  • Customize the commit message associated with the merge with /merge --commit-message "..."
  • Remove your PR from the merge queue with /merge -c
  • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
  • Get more information in this doc

Jira ticket: [PROJ-IDENT]