What Does This Do

Refactors ExceptionHandlers.defaultExceptionHandler into a factory that takes the advice class FQN, and changes the bytecode it emits so the resulting log line is:

Failed to handle exception in instrumentation for com.example.InstrumentedClass (com.example.SomeAdvice)

instead of:

Failed to handle exception in instrumentation for com.example.InstrumentedClass

The existing ... for <instrumentedClass> prefix is preserved (so existing log searches / dashboards keep working);

Please note that now the stack manipulation is compound and made of two part:

1. One little TextConstant that's allocated for each Advice when they are installed (it's small and cheap, just doing a LDC)
2. The existing logging advice that's shared among all the installed advices

The new logging bytecode has been adapted to consume the advice name from the stack and weave it into the log message at runtime via two String.concat calls.

This is very useful to understand which advice specifically triggered the error for the telemetry. Unfortunately there is no easy way to make distinction between the OnMethodEnter/OnMethodExit but this is a nice step forward in improving the message.

Motivation

Additional Notes

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Add your completed PR to the merge queue by commenting /merge. You can also:
  • Customize the commit message associated with the merge with /merge --commit-message "..."
  • Remove your PR from the merge queue with /merge -c
  • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
  • Get more information in this doc

Jira ticket: [PROJ-IDENT]