Skip to content

Fix _dd.p.ksr formatting to use 6 decimal places#11068

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
brian.marks/fix-ksr-decimal-precision
Apr 9, 2026
Merged

Fix _dd.p.ksr formatting to use 6 decimal places#11068
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
brian.marks/fix-ksr-decimal-precision

Conversation

@bm1549
Copy link
Copy Markdown
Contributor

@bm1549 bm1549 commented Apr 9, 2026 •
edited by atlassian Bot
Loading

What Does This Do

Fixes _dd.p.ksr (Knuth sampling rate) tag formatting to use 6 decimal places of precision instead of 6 significant figures.

Before: values below 1e-4 were formatted in scientific notation (e.g. 0.000001 → "1e-06")
After: all values use fixed decimal notation with up to 6 decimal places (e.g. 0.000001 → "0.000001")

Motivation

System-tests Test_Knuth_Sample_Rate::test_sampling_knuth_sample_rate_trace_sampling_rule was failing for dd-trace-java v1.61.0. The spec says the KSR tag should be formatted with "up to 6 decimal digits of precision, with trailing zeros stripped" — fixed decimal, not scientific notation.

The three previously-failing parametric cases are now covered as unit test rows in the existing "updateKnuthSamplingRate formats rate correctly" table:

  • 0.000001 → "0.000001" (six_decimal_precision_boundary)
  • 0.0000001 → "0" (below_precision_rounds_to_zero)
  • 0.00000051 → "0.000001" (rounds_up_to_one_millionth)

The fix also simplifies the implementation: the variable-scale multiplier branches and the formatScientific6g helper are replaced by a single fixed multiplier of 1_000_000L.

APMAPI-1880

Additional Notes

  • Existing unit tests that expected the old %.6g semantics (7 sig figs for values < 0.1, scientific notation) are updated to match the corrected 6 decimal place behavior.
  • The JMH benchmark's reference implementation (stringFormatImpl) is updated from %.6g to %.6f to match the new spec.
  • Performance is equal or better: fixed multiplier removes the 4-way magnitude dispatch, loop is always 6 digits instead of 6-9, scientific path eliminated entirely.

Contributor Checklist

Jira ticket: APMAPI-1880

@bm1549 bm1549 added the tag: ai generated Largely based on code generated by an AI or LLM label Apr 9, 2026
@bm1549 @claude
Fix _dd.p.ksr formatting to use 6 decimal places instead of 6 signifi…
9f9795f 
…cant figures

The system-tests (Test_Knuth_Sample_Rate) expect the KSR tag to be
formatted with up to 6 decimal digits of precision, not 6 significant
figures. The previous implementation used %.6g semantics which produced
scientific notation for values < 1e-4 (e.g. "1e-06" for 0.000001).

The corrected format rounds to 6 decimal places:
- 0.000001 -> "0.000001"  (previously "1e-06")
- 0.0000001 -> "0"        (previously "1e-07"; below precision)
- 0.00000051 -> "0.000001" (previously scientific; rounds up)

This also simplifies the implementation: the variable-scale multiplier
and formatScientific6g helper are replaced by a single fixed multiplier
of 1e6 (always 6 decimal places).

Unit tests updated to reflect the corrected expected values, and new
tests added that directly mirror the three previously-failing
system-test parametric cases.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@bm1549 bm1549 force-pushed the brian.marks/fix-ksr-decimal-precision branch from 5e42c3a to 9f9795f Compare April 9, 2026 11:55
mcculls
mcculls approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this fixes the affected system-tests

@PerfectSlayer PerfectSlayer added type: bug Bug report and fix comp: core Tracer core labels Apr 9, 2026
@PerfectSlayer
Copy link
Copy Markdown
Contributor

PerfectSlayer commented Apr 9, 2026

Related to #11065 and DataDog/system-tests#6709

@PerfectSlayer PerfectSlayer marked this pull request as ready for review April 9, 2026 12:13
@PerfectSlayer PerfectSlayer requested review from a team as code owners April 9, 2026 12:13
@PerfectSlayer PerfectSlayer requested review from dougqh and mtoffl01 and removed request for a team April 9, 2026 12:13
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 9, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master brian.marks/fix-ksr-decimal-precision
git_commit_date 1775720215 1775735748
git_commit_sha 68a2e63 9f9795f
release_version 1.62.0-SNAPSHOT~68a2e632a8 1.62.0-SNAPSHOT~9f9795f2f8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1775737560 1775737560
ci_job_id 1580974218 1580974218
ci_pipeline_id 106862104 106862104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-801l3vfw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-801l3vfw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060491
Total [baseline] (8.899 s) : 0, 8898898
Agent [candidate] (1.056 s) : 0, 1055952
Total [candidate] (8.811 s) : 0, 8811031
section iast
Agent [baseline] (1.225 s) : 0, 1224740
Total [baseline] (9.58 s) : 0, 9580098
Agent [candidate] (1.222 s) : 0, 1221958
Total [candidate] (9.608 s) : 0, 9607931
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.225 s 164.249 ms (15.5%)
Total tracing 8.899 s -
Total iast 9.58 s 681.2 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.222 s 166.006 ms (15.7%)
Total tracing 8.811 s -
Total iast 9.608 s 796.9 ms (9.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.237 ms) : 0, 1237
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (635.246 ms) : 0, 635246
BytebuddyAgent [candidate] (632.587 ms) : 0, 632587
AgentMeter [baseline] (29.509 ms) : 0, 29509
AgentMeter [candidate] (29.314 ms) : 0, 29314
GlobalTracer [baseline] (249.009 ms) : 0, 249009
GlobalTracer [candidate] (249.033 ms) : 0, 249033
AppSec [baseline] (32.156 ms) : 0, 32156
AppSec [candidate] (31.916 ms) : 0, 31916
Debugger [baseline] (59.49 ms) : 0, 59490
Debugger [candidate] (59.064 ms) : 0, 59064
Remote Config [baseline] (603.048 µs) : 0, 603
Remote Config [candidate] (614.423 µs) : 0, 614
Telemetry [baseline] (8.089 ms) : 0, 8089
Telemetry [candidate] (8.015 ms) : 0, 8015
Flare Poller [baseline] (8.905 ms) : 0, 8905
Flare Poller [candidate] (8.069 ms) : 0, 8069
section iast
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (802.519 ms) : 0, 802519
BytebuddyAgent [candidate] (799.95 ms) : 0, 799950
AgentMeter [baseline] (11.446 ms) : 0, 11446
AgentMeter [candidate] (11.39 ms) : 0, 11390
GlobalTracer [baseline] (239.521 ms) : 0, 239521
GlobalTracer [candidate] (239.438 ms) : 0, 239438
IAST [baseline] (25.739 ms) : 0, 25739
IAST [candidate] (25.784 ms) : 0, 25784
AppSec [baseline] (33.336 ms) : 0, 33336
AppSec [candidate] (33.407 ms) : 0, 33407
Debugger [baseline] (57.163 ms) : 0, 57163
Debugger [candidate] (58.362 ms) : 0, 58362
Remote Config [baseline] (526.844 µs) : 0, 527
Remote Config [candidate] (1.145 ms) : 0, 1145
Telemetry [baseline] (13.609 ms) : 0, 13609
Telemetry [candidate] (11.551 ms) : 0, 11551
Flare Poller [baseline] (3.447 ms) : 0, 3447
Flare Poller [candidate] (3.469 ms) : 0, 3469
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055960
Total [baseline] (10.977 s) : 0, 10977462
Agent [candidate] (1.064 s) : 0, 1064393
Total [candidate] (11.201 s) : 0, 11200902
section appsec
Agent [baseline] (1.249 s) : 0, 1248659
Total [baseline] (11.19 s) : 0, 11190377
Agent [candidate] (1.249 s) : 0, 1249348
Total [candidate] (11.149 s) : 0, 11148610
section iast
Agent [baseline] (1.233 s) : 0, 1233370
Total [baseline] (11.316 s) : 0, 11316450
Agent [candidate] (1.227 s) : 0, 1226798
Total [candidate] (11.317 s) : 0, 11317043
section profiling
Agent [baseline] (1.182 s) : 0, 1182104
Total [baseline] (11.032 s) : 0, 11032350
Agent [candidate] (1.184 s) : 0, 1183648
Total [candidate] (11.11 s) : 0, 11110172
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.249 s 192.699 ms (18.2%)
Agent iast 1.233 s 177.411 ms (16.8%)
Agent profiling 1.182 s 126.145 ms (11.9%)
Total tracing 10.977 s -
Total appsec 11.19 s 212.915 ms (1.9%)
Total iast 11.316 s 338.988 ms (3.1%)
Total profiling 11.032 s 54.887 ms (0.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.249 s 184.954 ms (17.4%)
Agent iast 1.227 s 162.404 ms (15.3%)
Agent profiling 1.184 s 119.255 ms (11.2%)
Total tracing 11.201 s -
Total appsec 11.149 s -52.292 ms (-0.5%)
Total iast 11.317 s 116.142 ms (1.0%)
Total profiling 11.11 s -90.73 ms (-0.8%) 
gantt
    title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.239 ms) : 0, 1239
BytebuddyAgent [baseline] (630.962 ms) : 0, 630962
BytebuddyAgent [candidate] (636.987 ms) : 0, 636987
AgentMeter [baseline] (29.279 ms) : 0, 29279
AgentMeter [candidate] (29.485 ms) : 0, 29485
GlobalTracer [baseline] (248.226 ms) : 0, 248226
GlobalTracer [candidate] (249.873 ms) : 0, 249873
AppSec [baseline] (31.859 ms) : 0, 31859
AppSec [candidate] (32.188 ms) : 0, 32188
Debugger [baseline] (59.811 ms) : 0, 59811
Debugger [candidate] (60.418 ms) : 0, 60418
Remote Config [baseline] (591.914 µs) : 0, 592
Remote Config [candidate] (597.87 µs) : 0, 598
Telemetry [baseline] (8.068 ms) : 0, 8068
Telemetry [candidate] (8.13 ms) : 0, 8130
Flare Poller [baseline] (9.811 ms) : 0, 9811
Flare Poller [candidate] (9.141 ms) : 0, 9141
section appsec
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (662.154 ms) : 0, 662154
BytebuddyAgent [candidate] (662.855 ms) : 0, 662855
AgentMeter [baseline] (11.986 ms) : 0, 11986
AgentMeter [candidate] (12.024 ms) : 0, 12024
GlobalTracer [baseline] (248.453 ms) : 0, 248453
GlobalTracer [candidate] (249.321 ms) : 0, 249321
IAST [baseline] (24.566 ms) : 0, 24566
IAST [candidate] (24.52 ms) : 0, 24520
AppSec [baseline] (184.867 ms) : 0, 184867
AppSec [candidate] (184.722 ms) : 0, 184722
Debugger [baseline] (66.252 ms) : 0, 66252
Debugger [candidate] (65.794 ms) : 0, 65794
Remote Config [baseline] (598.904 µs) : 0, 599
Remote Config [candidate] (601.767 µs) : 0, 602
Telemetry [baseline] (8.566 ms) : 0, 8566
Telemetry [candidate] (8.435 ms) : 0, 8435
Flare Poller [baseline] (3.549 ms) : 0, 3549
Flare Poller [candidate] (3.52 ms) : 0, 3520
section iast
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (806.607 ms) : 0, 806607
BytebuddyAgent [candidate] (803.574 ms) : 0, 803574
AgentMeter [baseline] (11.597 ms) : 0, 11597
AgentMeter [candidate] (11.434 ms) : 0, 11434
GlobalTracer [baseline] (241.59 ms) : 0, 241590
GlobalTracer [candidate] (239.991 ms) : 0, 239991
IAST [baseline] (26.913 ms) : 0, 26913
IAST [candidate] (27.343 ms) : 0, 27343
AppSec [baseline] (32.853 ms) : 0, 32853
AppSec [candidate] (30.738 ms) : 0, 30738
Debugger [baseline] (59.671 ms) : 0, 59671
Debugger [candidate] (60.054 ms) : 0, 60054
Remote Config [baseline] (1.126 ms) : 0, 1126
Remote Config [candidate] (528.258 µs) : 0, 528
Telemetry [baseline] (11.825 ms) : 0, 11825
Telemetry [candidate] (12.358 ms) : 0, 12358
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.432 ms) : 0, 3432
section profiling
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (689.756 ms) : 0, 689756
BytebuddyAgent [candidate] (690.823 ms) : 0, 690823
AgentMeter [baseline] (9.167 ms) : 0, 9167
AgentMeter [candidate] (9.146 ms) : 0, 9146
GlobalTracer [baseline] (206.795 ms) : 0, 206795
GlobalTracer [candidate] (207.002 ms) : 0, 207002
AppSec [baseline] (32.32 ms) : 0, 32320
AppSec [candidate] (32.481 ms) : 0, 32481
Debugger [baseline] (65.444 ms) : 0, 65444
Debugger [candidate] (65.47 ms) : 0, 65470
Remote Config [baseline] (574.989 µs) : 0, 575
Remote Config [candidate] (566.741 µs) : 0, 567
Telemetry [baseline] (7.872 ms) : 0, 7872
Telemetry [candidate] (7.785 ms) : 0, 7785
Flare Poller [baseline] (3.614 ms) : 0, 3614
Flare Poller [candidate] (3.568 ms) : 0, 3568
ProfilingAgent [baseline] (94.192 ms) : 0, 94192
ProfilingAgent [candidate] (94.353 ms) : 0, 94353
Profiling [baseline] (94.758 ms) : 0, 94758
Profiling [candidate] (94.914 ms) : 0, 94914
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master brian.marks/fix-ksr-decimal-precision
git_commit_date 1775720215 1775735748
git_commit_sha 68a2e63 9f9795f
release_version 1.62.0-SNAPSHOT~68a2e632a8 1.62.0-SNAPSHOT~9f9795f2f8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1775738039 1775738039
ci_job_id 1580974219 1580974219
ci_pipeline_id 106862104 106862104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-v2cax3l0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-v2cax3l0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:petclinic:no_agent:high_load worse
[+1.527ms; +2.850ms] or [+9.186%; +17.146%]		 unstable
[+1.892ms; +5.068ms] or [+6.764%; +18.115%]		 unstable
[-57.726op/s; -0.649op/s] or [-21.191%; -0.238%]		 18.812ms 31.458ms 243.219op/s 16.624ms 27.978ms 272.406op/s
scenario:load:petclinic:appsec:high_load better
[-1.686ms; -0.716ms] or [-8.706%; -3.695%]		 same
[-1278.011µs; +75.937µs] or [-4.134%; +0.246%]		 unstable
[-12.832op/s; +38.144op/s] or [-5.387%; +16.014%]		 18.170ms 30.313ms 250.844op/s 19.371ms 30.914ms 238.188op/s
scenario:load:petclinic:profiling:high_load better
[-1.712ms; -0.761ms] or [-8.938%; -3.972%]		 better
[-2.044ms; -0.725ms] or [-6.716%; -2.383%]		 unstable
[-11.512op/s; +40.200op/s] or [-4.774%; +16.670%]		 17.920ms 29.045ms 255.500op/s 19.156ms 30.429ms 241.156op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.277 ms) : 1264, 1289
.   : milestone, 1277,
iast (3.325 ms) : 3278, 3372
.   : milestone, 3325,
iast_FULL (6.01 ms) : 5949, 6071
.   : milestone, 6010,
iast_GLOBAL (3.698 ms) : 3643, 3753
.   : milestone, 3698,
profiling (2.021 ms) : 2004, 2038
.   : milestone, 2021,
tracing (1.851 ms) : 1836, 1867
.   : milestone, 1851,
section candidate
no_agent (1.258 ms) : 1246, 1270
.   : milestone, 1258,
iast (3.41 ms) : 3360, 3460
.   : milestone, 3410,
iast_FULL (6.012 ms) : 5950, 6073
.   : milestone, 6012,
iast_GLOBAL (3.69 ms) : 3630, 3750
.   : milestone, 3690,
profiling (2.05 ms) : 2032, 2068
.   : milestone, 2050,
tracing (1.963 ms) : 1944, 1982
.   : milestone, 1963,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.277 ms [1.264 ms, 1.289 ms] -
iast 3.325 ms [3.278 ms, 3.372 ms] 2.048 ms (160.5%)
iast_FULL 6.01 ms [5.949 ms, 6.071 ms] 4.733 ms (370.8%)
iast_GLOBAL 3.698 ms [3.643 ms, 3.753 ms] 2.422 ms (189.7%)
profiling 2.021 ms [2.004 ms, 2.038 ms] 744.523 µs (58.3%)
tracing 1.851 ms [1.836 ms, 1.867 ms] 574.971 µs (45.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.258 ms [1.246 ms, 1.27 ms] -
iast 3.41 ms [3.36 ms, 3.46 ms] 2.152 ms (171.1%)
iast_FULL 6.012 ms [5.95 ms, 6.073 ms] 4.754 ms (377.9%)
iast_GLOBAL 3.69 ms [3.63 ms, 3.75 ms] 2.432 ms (193.3%)
profiling 2.05 ms [2.032 ms, 2.068 ms] 791.655 µs (62.9%)
tracing 1.963 ms [1.944 ms, 1.982 ms] 705.24 µs (56.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.128 ms) : 16962, 17295
.   : milestone, 17128,
appsec (19.594 ms) : 19394, 19794
.   : milestone, 19594,
code_origins (17.89 ms) : 17706, 18074
.   : milestone, 17890,
iast (18.165 ms) : 17984, 18346
.   : milestone, 18165,
profiling (19.354 ms) : 19162, 19546
.   : milestone, 19354,
tracing (17.892 ms) : 17718, 18066
.   : milestone, 17892,
section candidate
no_agent (19.188 ms) : 18990, 19387
.   : milestone, 19188,
appsec (18.604 ms) : 18410, 18797
.   : milestone, 18604,
code_origins (17.668 ms) : 17495, 17842
.   : milestone, 17668,
iast (18.859 ms) : 18669, 19049
.   : milestone, 18859,
profiling (18.262 ms) : 18081, 18442
.   : milestone, 18262,
tracing (18.014 ms) : 17836, 18191
.   : milestone, 18014,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.128 ms [16.962 ms, 17.295 ms] -
appsec 19.594 ms [19.394 ms, 19.794 ms] 2.466 ms (14.4%)
code_origins 17.89 ms [17.706 ms, 18.074 ms] 761.801 µs (4.4%)
iast 18.165 ms [17.984 ms, 18.346 ms] 1.037 ms (6.1%)
profiling 19.354 ms [19.162 ms, 19.546 ms] 2.226 ms (13.0%)
tracing 17.892 ms [17.718 ms, 18.066 ms] 763.809 µs (4.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.188 ms [18.99 ms, 19.387 ms] -
appsec 18.604 ms [18.41 ms, 18.797 ms] -584.962 µs (-3.0%)
code_origins 17.668 ms [17.495 ms, 17.842 ms] -1.52 ms (-7.9%)
iast 18.859 ms [18.669 ms, 19.049 ms] -329.572 µs (-1.7%)
profiling 18.262 ms [18.081 ms, 18.442 ms] -926.831 µs (-4.8%)
tracing 18.014 ms [17.836 ms, 18.191 ms] -1.175 ms (-6.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master brian.marks/fix-ksr-decimal-precision
git_commit_date 1775720215 1775735748
git_commit_sha 68a2e63 9f9795f
release_version 1.62.0-SNAPSHOT~68a2e632a8 1.62.0-SNAPSHOT~9f9795f2f8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1775737684 1775737684
ci_job_id 1580974220 1580974220
ci_pipeline_id 106862104 106862104
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-of6gwptz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-of6gwptz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
.   : milestone, 1486,
appsec (3.883 ms) : 3656, 4109
.   : milestone, 3883,
iast (2.279 ms) : 2210, 2349
.   : milestone, 2279,
iast_GLOBAL (2.312 ms) : 2243, 2382
.   : milestone, 2312,
profiling (2.098 ms) : 2044, 2153
.   : milestone, 2098,
tracing (2.111 ms) : 2057, 2164
.   : milestone, 2111,
section candidate
no_agent (1.488 ms) : 1477, 1500
.   : milestone, 1488,
appsec (3.828 ms) : 3604, 4052
.   : milestone, 3828,
iast (2.282 ms) : 2213, 2352
.   : milestone, 2282,
iast_GLOBAL (2.319 ms) : 2249, 2388
.   : milestone, 2319,
profiling (2.101 ms) : 2046, 2156
.   : milestone, 2101,
tracing (2.085 ms) : 2032, 2139
.   : milestone, 2085,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.474 ms, 1.497 ms] -
appsec 3.883 ms [3.656 ms, 4.109 ms] 2.397 ms (161.3%)
iast 2.279 ms [2.21 ms, 2.349 ms] 793.416 µs (53.4%)
iast_GLOBAL 2.312 ms [2.243 ms, 2.382 ms] 826.48 µs (55.6%)
profiling 2.098 ms [2.044 ms, 2.153 ms] 612.604 µs (41.2%)
tracing 2.111 ms [2.057 ms, 2.164 ms] 624.706 µs (42.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.488 ms [1.477 ms, 1.5 ms] -
appsec 3.828 ms [3.604 ms, 4.052 ms] 2.34 ms (157.2%)
iast 2.282 ms [2.213 ms, 2.352 ms] 794.068 µs (53.4%)
iast_GLOBAL 2.319 ms [2.249 ms, 2.388 ms] 830.337 µs (55.8%)
profiling 2.101 ms [2.046 ms, 2.156 ms] 612.526 µs (41.2%)
tracing 2.085 ms [2.032 ms, 2.139 ms] 596.883 µs (40.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~9f9795f2f8, baseline=1.62.0-SNAPSHOT~68a2e632a8
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.507 s) : 15507000, 15507000
.   : milestone, 15507000,
appsec (14.838 s) : 14838000, 14838000
.   : milestone, 14838000,
iast (18.91 s) : 18910000, 18910000
.   : milestone, 18910000,
iast_GLOBAL (18.293 s) : 18293000, 18293000
.   : milestone, 18293000,
profiling (15.07 s) : 15070000, 15070000
.   : milestone, 15070000,
tracing (14.843 s) : 14843000, 14843000
.   : milestone, 14843000,
section candidate
no_agent (15.565 s) : 15565000, 15565000
.   : milestone, 15565000,
appsec (15.376 s) : 15376000, 15376000
.   : milestone, 15376000,
iast (18.407 s) : 18407000, 18407000
.   : milestone, 18407000,
iast_GLOBAL (17.917 s) : 17917000, 17917000
.   : milestone, 17917000,
profiling (15.376 s) : 15376000, 15376000
.   : milestone, 15376000,
tracing (14.809 s) : 14809000, 14809000
.   : milestone, 14809000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.507 s [15.507 s, 15.507 s] -
appsec 14.838 s [14.838 s, 14.838 s] -669.0 ms (-4.3%)
iast 18.91 s [18.91 s, 18.91 s] 3.403 s (21.9%)
iast_GLOBAL 18.293 s [18.293 s, 18.293 s] 2.786 s (18.0%)
profiling 15.07 s [15.07 s, 15.07 s] -437.0 ms (-2.8%)
tracing 14.843 s [14.843 s, 14.843 s] -664.0 ms (-4.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.565 s [15.565 s, 15.565 s] -
appsec 15.376 s [15.376 s, 15.376 s] -189.0 ms (-1.2%)
iast 18.407 s [18.407 s, 18.407 s] 2.842 s (18.3%)
iast_GLOBAL 17.917 s [17.917 s, 17.917 s] 2.352 s (15.1%)
profiling 15.376 s [15.376 s, 15.376 s] -189.0 ms (-1.2%)
tracing 14.809 s [14.809 s, 14.809 s] -756.0 ms (-4.9%)

@bm1549 bm1549 added this pull request to the merge queue Apr 9, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 9, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Apr 9, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-09 12:53:16 UTC ℹ️ Start processing command /merge

2026-04-09 12:53:27 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).

2026-04-09 14:14:13 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 9, 2026
@bm1549 bm1549 mentioned this pull request Apr 9, 2026
Merged
5 tasks
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit b266e2d into master Apr 9, 2026
578 of 582 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the brian.marks/fix-ksr-decimal-precision branch April 9, 2026 14:14
@github-actions github-actions Bot added this to the 1.62.0 milestone Apr 9, 2026
@PerfectSlayer PerfectSlayer modified the milestone: 1.62.0 Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01 mtoffl01 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM type: bug Bug report and fix

Projects

None yet

Milestone

1.62.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bm1549 @PerfectSlayer @mcculls