Fix Flaky SecurityResponseIdSmokeTest#10391
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33ea6db7ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088088
Total [baseline] (10.893 s) : 0, 10892573
Agent [candidate] (1.094 s) : 0, 1094423
Total [candidate] (10.777 s) : 0, 10777490
section appsec
Agent [baseline] (1.267 s) : 0, 1267358
Total [baseline] (11.081 s) : 0, 11081207
Agent [candidate] (1.269 s) : 0, 1268628
Total [candidate] (11.024 s) : 0, 11024459
section iast
Agent [baseline] (1.231 s) : 0, 1231116
Total [baseline] (11.228 s) : 0, 11228152
Agent [candidate] (1.232 s) : 0, 1232443
Total [candidate] (11.256 s) : 0, 11256375
section profiling
Agent [baseline] (1.206 s) : 0, 1205982
Total [baseline] (10.978 s) : 0, 10978421
Agent [candidate] (1.208 s) : 0, 1208382
Total [candidate] (10.901 s) : 0, 10901228
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (653.383 ms) : 0, 653383
BytebuddyAgent [candidate] (656.946 ms) : 0, 656946
GlobalTracer [baseline] (283.642 ms) : 0, 283642
GlobalTracer [candidate] (285.122 ms) : 0, 285122
AppSec [baseline] (32.796 ms) : 0, 32796
AppSec [candidate] (32.864 ms) : 0, 32864
Debugger [baseline] (68.071 ms) : 0, 68071
Debugger [candidate] (69.057 ms) : 0, 69057
Remote Config [baseline] (644.107 µs) : 0, 644
Remote Config [candidate] (638.163 µs) : 0, 638
Telemetry [baseline] (8.981 ms) : 0, 8981
Telemetry [candidate] (9.041 ms) : 0, 9041
Flare Poller [baseline] (3.809 ms) : 0, 3809
Flare Poller [candidate] (3.907 ms) : 0, 3907
section appsec
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (692.231 ms) : 0, 692231
BytebuddyAgent [candidate] (693.387 ms) : 0, 693387
GlobalTracer [baseline] (258.914 ms) : 0, 258914
GlobalTracer [candidate] (259.161 ms) : 0, 259161
IAST [baseline] (24.615 ms) : 0, 24615
IAST [candidate] (24.79 ms) : 0, 24790
AppSec [baseline] (173.623 ms) : 0, 173623
AppSec [candidate] (174.178 ms) : 0, 174178
Debugger [baseline] (67.57 ms) : 0, 67570
Debugger [candidate] (66.793 ms) : 0, 66793
Remote Config [baseline] (787.931 µs) : 0, 788
Remote Config [candidate] (755.351 µs) : 0, 755
Telemetry [baseline] (9.264 ms) : 0, 9264
Telemetry [candidate] (9.207 ms) : 0, 9207
Flare Poller [baseline] (3.752 ms) : 0, 3752
Flare Poller [candidate] (3.725 ms) : 0, 3725
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (796.625 ms) : 0, 796625
BytebuddyAgent [candidate] (797.184 ms) : 0, 797184
GlobalTracer [baseline] (257.647 ms) : 0, 257647
GlobalTracer [candidate] (257.938 ms) : 0, 257938
IAST [baseline] (27.09 ms) : 0, 27090
IAST [candidate] (27.162 ms) : 0, 27162
AppSec [baseline] (35.348 ms) : 0, 35348
AppSec [candidate] (34.614 ms) : 0, 34614
Debugger [baseline] (65.03 ms) : 0, 65030
Debugger [candidate] (66.161 ms) : 0, 66161
Remote Config [baseline] (568.556 µs) : 0, 569
Remote Config [candidate] (585.375 µs) : 0, 585
Telemetry [baseline] (8.52 ms) : 0, 8520
Telemetry [candidate] (8.522 ms) : 0, 8522
Flare Poller [baseline] (3.612 ms) : 0, 3612
Flare Poller [candidate] (3.581 ms) : 0, 3581
section profiling
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (703.565 ms) : 0, 703565
BytebuddyAgent [candidate] (704.62 ms) : 0, 704620
GlobalTracer [baseline] (221.447 ms) : 0, 221447
GlobalTracer [candidate] (221.616 ms) : 0, 221616
AppSec [baseline] (32.043 ms) : 0, 32043
AppSec [candidate] (32.094 ms) : 0, 32094
Debugger [baseline] (67.859 ms) : 0, 67859
Debugger [candidate] (68.547 ms) : 0, 68547
Remote Config [baseline] (663.411 µs) : 0, 663
Remote Config [candidate] (639.581 µs) : 0, 640
Telemetry [baseline] (8.965 ms) : 0, 8965
Telemetry [candidate] (8.92 ms) : 0, 8920
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.71 ms) : 0, 3710
ProfilingAgent [baseline] (96.632 ms) : 0, 96632
ProfilingAgent [candidate] (97.072 ms) : 0, 97072
Profiling [baseline] (97.209 ms) : 0, 97209
Profiling [candidate] (97.674 ms) : 0, 97674
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086931
Total [baseline] (8.771 s) : 0, 8770501
Agent [candidate] (1.086 s) : 0, 1086168
Total [candidate] (8.736 s) : 0, 8735803
section iast
Agent [baseline] (1.231 s) : 0, 1230863
Total [baseline] (9.368 s) : 0, 9367510
Agent [candidate] (1.225 s) : 0, 1225464
Total [candidate] (9.333 s) : 0, 9332972
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (653.244 ms) : 0, 653244
BytebuddyAgent [candidate] (653.109 ms) : 0, 653109
GlobalTracer [baseline] (283.595 ms) : 0, 283595
GlobalTracer [candidate] (283.256 ms) : 0, 283256
AppSec [baseline] (32.892 ms) : 0, 32892
AppSec [candidate] (32.626 ms) : 0, 32626
Debugger [baseline] (67.084 ms) : 0, 67084
Debugger [candidate] (67.117 ms) : 0, 67117
Remote Config [baseline] (646.953 µs) : 0, 647
Remote Config [candidate] (642.165 µs) : 0, 642
Telemetry [baseline] (8.976 ms) : 0, 8976
Telemetry [candidate] (8.841 ms) : 0, 8841
Flare Poller [baseline] (3.815 ms) : 0, 3815
Flare Poller [candidate] (3.818 ms) : 0, 3818
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (796.116 ms) : 0, 796116
BytebuddyAgent [candidate] (792.841 ms) : 0, 792841
GlobalTracer [baseline] (258.125 ms) : 0, 258125
GlobalTracer [candidate] (257.583 ms) : 0, 257583
IAST [baseline] (27.195 ms) : 0, 27195
IAST [candidate] (27.052 ms) : 0, 27052
AppSec [baseline] (32.914 ms) : 0, 32914
AppSec [candidate] (33.493 ms) : 0, 33493
Debugger [baseline] (67.168 ms) : 0, 67168
Debugger [candidate] (65.396 ms) : 0, 65396
Remote Config [baseline] (569.378 µs) : 0, 569
Remote Config [candidate] (590.491 µs) : 0, 590
Telemetry [baseline] (8.539 ms) : 0, 8539
Telemetry [candidate] (8.466 ms) : 0, 8466
Flare Poller [baseline] (3.602 ms) : 0, 3602
Flare Poller [candidate] (3.537 ms) : 0, 3537
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (18.144 ms) : 17960, 18327
. : milestone, 18144,
appsec (19.685 ms) : 19481, 19888
. : milestone, 19685,
code_origins (17.575 ms) : 17400, 17750
. : milestone, 17575,
iast (17.344 ms) : 17171, 17518
. : milestone, 17344,
profiling (19.376 ms) : 19180, 19571
. : milestone, 19376,
tracing (18.425 ms) : 18241, 18609
. : milestone, 18425,
section candidate
no_agent (18.185 ms) : 17997, 18373
. : milestone, 18185,
appsec (19.73 ms) : 19528, 19932
. : milestone, 19730,
code_origins (17.735 ms) : 17555, 17914
. : milestone, 17735,
iast (17.739 ms) : 17563, 17916
. : milestone, 17739,
profiling (18.738 ms) : 18551, 18926
. : milestone, 18738,
tracing (17.784 ms) : 17607, 17960
. : milestone, 17784,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1162, 1185
. : milestone, 1173,
iast (3.1 ms) : 3062, 3138
. : milestone, 3100,
iast_FULL (5.644 ms) : 5589, 5700
. : milestone, 5644,
iast_GLOBAL (3.472 ms) : 3421, 3522
. : milestone, 3472,
profiling (1.907 ms) : 1891, 1924
. : milestone, 1907,
tracing (1.806 ms) : 1789, 1823
. : milestone, 1806,
section candidate
no_agent (1.196 ms) : 1184, 1209
. : milestone, 1196,
iast (3.083 ms) : 3046, 3121
. : milestone, 3083,
iast_FULL (6.042 ms) : 5981, 6104
. : milestone, 6042,
iast_GLOBAL (3.503 ms) : 3452, 3553
. : milestone, 3503,
profiling (1.961 ms) : 1945, 1978
. : milestone, 1961,
tracing (1.79 ms) : 1774, 1805
. : milestone, 1790,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
appsec (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
iast (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
iast_GLOBAL (18.008 s) : 18008000, 18008000
. : milestone, 18008000,
profiling (14.737 s) : 14737000, 14737000
. : milestone, 14737000,
tracing (15.385 s) : 15385000, 15385000
. : milestone, 15385000,
section candidate
no_agent (15.718 s) : 15718000, 15718000
. : milestone, 15718000,
appsec (15.056 s) : 15056000, 15056000
. : milestone, 15056000,
iast (18.379 s) : 18379000, 18379000
. : milestone, 18379000,
iast_GLOBAL (17.802 s) : 17802000, 17802000
. : milestone, 17802000,
profiling (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
tracing (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~33ea6db7ff, baseline=1.59.0-SNAPSHOT~340e03e23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.472 ms) : 2420, 2524
. : milestone, 2472,
iast (2.217 ms) : 2151, 2282
. : milestone, 2217,
iast_GLOBAL (2.253 ms) : 2188, 2318
. : milestone, 2253,
profiling (2.056 ms) : 2004, 2109
. : milestone, 2056,
tracing (2.05 ms) : 1999, 2102
. : milestone, 2050,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.733 ms) : 3514, 3953
. : milestone, 3733,
iast (2.212 ms) : 2147, 2277
. : milestone, 2212,
iast_GLOBAL (2.261 ms) : 2196, 2327
. : milestone, 2261,
profiling (2.09 ms) : 2035, 2144
. : milestone, 2090,
tracing (2.044 ms) : 1993, 2095
. : milestone, 2044,
|
What Does This Do
The main fix is that test 4 now waits for its two traces before finishing. This prevents those traces from leaking into test 5. With that in place
Motivation
test security_response_id is not present in trace when request is not blocked is flaky on master (see dashboard):
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-60650