-
Notifications
You must be signed in to change notification settings - Fork 320
Avoid NPE when enumerating servlet headers #10213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Dec 15, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078438
Total [baseline] (8.737 s) : 0, 8737184
Agent [candidate] (1.089 s) : 0, 1088524
Total [candidate] (8.741 s) : 0, 8740850
section iast
Agent [baseline] (1.226 s) : 0, 1225970
Total [baseline] (9.353 s) : 0, 9353234
Agent [candidate] (1.237 s) : 0, 1237159
Total [candidate] (9.407 s) : 0, 9407226
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (647.892 ms) : 0, 647892
BytebuddyAgent [candidate] (653.888 ms) : 0, 653888
GlobalTracer [baseline] (281.392 ms) : 0, 281392
GlobalTracer [candidate] (283.584 ms) : 0, 283584
AppSec [baseline] (32.247 ms) : 0, 32247
AppSec [candidate] (32.57 ms) : 0, 32570
Debugger [baseline] (66.961 ms) : 0, 66961
Debugger [candidate] (67.993 ms) : 0, 67993
Remote Config [baseline] (629.584 µs) : 0, 630
Remote Config [candidate] (647.511 µs) : 0, 648
Telemetry [baseline] (8.957 ms) : 0, 8957
Telemetry [candidate] (9.026 ms) : 0, 9026
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.785 ms) : 0, 3785
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (794.566 ms) : 0, 794566
BytebuddyAgent [candidate] (802.253 ms) : 0, 802253
GlobalTracer [baseline] (255.657 ms) : 0, 255657
GlobalTracer [candidate] (259.04 ms) : 0, 259040
AppSec [baseline] (34.431 ms) : 0, 34431
AppSec [candidate] (33.943 ms) : 0, 33943
Debugger [baseline] (65.101 ms) : 0, 65101
Debugger [candidate] (65.327 ms) : 0, 65327
Remote Config [baseline] (540.709 µs) : 0, 541
Remote Config [candidate] (557.115 µs) : 0, 557
Telemetry [baseline] (8.443 ms) : 0, 8443
Telemetry [candidate] (8.335 ms) : 0, 8335
Flare Poller [baseline] (3.496 ms) : 0, 3496
Flare Poller [candidate] (3.466 ms) : 0, 3466
IAST [baseline] (26.963 ms) : 0, 26963
IAST [candidate] (27.287 ms) : 0, 27287
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078645
Total [baseline] (10.845 s) : 0, 10845162
Agent [candidate] (1.082 s) : 0, 1082410
Total [candidate] (10.859 s) : 0, 10858686
section appsec
Agent [baseline] (1.26 s) : 0, 1260218
Total [baseline] (10.977 s) : 0, 10977221
Agent [candidate] (1.265 s) : 0, 1264664
Total [candidate] (11.05 s) : 0, 11049872
section iast
Agent [baseline] (1.229 s) : 0, 1229434
Total [baseline] (11.262 s) : 0, 11262337
Agent [candidate] (1.23 s) : 0, 1229510
Total [candidate] (11.224 s) : 0, 11224304
section profiling
Agent [baseline] (1.213 s) : 0, 1212759
Total [baseline] (10.999 s) : 0, 10998946
Agent [candidate] (1.213 s) : 0, 1212788
Total [candidate] (10.975 s) : 0, 10975234
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (647.759 ms) : 0, 647759
BytebuddyAgent [candidate] (649.926 ms) : 0, 649926
GlobalTracer [baseline] (281.19 ms) : 0, 281190
GlobalTracer [candidate] (282.023 ms) : 0, 282023
AppSec [baseline] (32.214 ms) : 0, 32214
AppSec [candidate] (32.178 ms) : 0, 32178
Debugger [baseline] (67.619 ms) : 0, 67619
Debugger [candidate] (68.123 ms) : 0, 68123
Remote Config [baseline] (652.934 µs) : 0, 653
Remote Config [candidate] (630.682 µs) : 0, 631
Telemetry [baseline] (8.929 ms) : 0, 8929
Telemetry [candidate] (9.089 ms) : 0, 9089
Flare Poller [baseline] (3.738 ms) : 0, 3738
Flare Poller [candidate] (3.782 ms) : 0, 3782
section appsec
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (686.969 ms) : 0, 686969
BytebuddyAgent [candidate] (689.331 ms) : 0, 689331
GlobalTracer [baseline] (257.825 ms) : 0, 257825
GlobalTracer [candidate] (258.265 ms) : 0, 258265
AppSec [baseline] (174.652 ms) : 0, 174652
AppSec [candidate] (174.882 ms) : 0, 174882
Debugger [baseline] (66.277 ms) : 0, 66277
Debugger [candidate] (67.196 ms) : 0, 67196
Remote Config [baseline] (711.684 µs) : 0, 712
Remote Config [candidate] (692.012 µs) : 0, 692
Telemetry [baseline] (9.027 ms) : 0, 9027
Telemetry [candidate] (9.134 ms) : 0, 9134
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.942 ms) : 0, 3942
IAST [baseline] (24.339 ms) : 0, 24339
IAST [candidate] (24.508 ms) : 0, 24508
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (795.366 ms) : 0, 795366
BytebuddyAgent [candidate] (796.374 ms) : 0, 796374
GlobalTracer [baseline] (256.874 ms) : 0, 256874
GlobalTracer [candidate] (256.999 ms) : 0, 256999
AppSec [baseline] (35.029 ms) : 0, 35029
AppSec [candidate] (34.343 ms) : 0, 34343
Debugger [baseline] (65.844 ms) : 0, 65844
Debugger [candidate] (65.701 ms) : 0, 65701
Remote Config [baseline] (576.154 µs) : 0, 576
Remote Config [candidate] (544.107 µs) : 0, 544
Telemetry [baseline] (8.478 ms) : 0, 8478
Telemetry [candidate] (8.388 ms) : 0, 8388
Flare Poller [baseline] (3.46 ms) : 0, 3460
Flare Poller [candidate] (3.521 ms) : 0, 3521
IAST [baseline] (27.075 ms) : 0, 27075
IAST [candidate] (27.035 ms) : 0, 27035
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (706.936 ms) : 0, 706936
BytebuddyAgent [candidate] (707.446 ms) : 0, 707446
GlobalTracer [baseline] (222.16 ms) : 0, 222160
GlobalTracer [candidate] (222.499 ms) : 0, 222499
AppSec [baseline] (32.437 ms) : 0, 32437
AppSec [candidate] (32.286 ms) : 0, 32286
Debugger [baseline] (68.47 ms) : 0, 68470
Debugger [candidate] (68.742 ms) : 0, 68742
Remote Config [baseline] (651.711 µs) : 0, 652
Remote Config [candidate] (658.612 µs) : 0, 659
Telemetry [baseline] (9.068 ms) : 0, 9068
Telemetry [candidate] (9.026 ms) : 0, 9026
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.765 ms) : 0, 3765
ProfilingAgent [baseline] (97.745 ms) : 0, 97745
ProfilingAgent [candidate] (96.852 ms) : 0, 96852
Profiling [baseline] (98.332 ms) : 0, 98332
Profiling [candidate] (97.423 ms) : 0, 97423
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1214
. : milestone, 1203,
iast (3.362 ms) : 3316, 3408
. : milestone, 3362,
iast_FULL (5.675 ms) : 5619, 5732
. : milestone, 5675,
iast_GLOBAL (3.651 ms) : 3594, 3709
. : milestone, 3651,
profiling (2.081 ms) : 2062, 2100
. : milestone, 2081,
tracing (1.858 ms) : 1841, 1875
. : milestone, 1858,
section candidate
no_agent (1.199 ms) : 1188, 1211
. : milestone, 1199,
iast (3.291 ms) : 3246, 3337
. : milestone, 3291,
iast_FULL (5.779 ms) : 5723, 5836
. : milestone, 5779,
iast_GLOBAL (3.64 ms) : 3588, 3693
. : milestone, 3640,
profiling (1.979 ms) : 1961, 1997
. : milestone, 1979,
tracing (1.823 ms) : 1807, 1838
. : milestone, 1823,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section baseline
no_agent (17.141 ms) : 16968, 17314
. : milestone, 17141,
appsec (19.586 ms) : 19387, 19786
. : milestone, 19586,
code_origins (17.83 ms) : 17654, 18006
. : milestone, 17830,
iast (17.582 ms) : 17408, 17756
. : milestone, 17582,
profiling (20.005 ms) : 19804, 20207
. : milestone, 20005,
tracing (17.624 ms) : 17450, 17799
. : milestone, 17624,
section candidate
no_agent (17.147 ms) : 16976, 17319
. : milestone, 17147,
appsec (18.845 ms) : 18652, 19037
. : milestone, 18845,
code_origins (17.774 ms) : 17599, 17949
. : milestone, 17774,
iast (17.6 ms) : 17427, 17772
. : milestone, 17600,
profiling (18.594 ms) : 18408, 18780
. : milestone, 18594,
tracing (18.724 ms) : 18534, 18913
. : milestone, 18724,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.67 ms) : 3454, 3885
. : milestone, 3670,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.265 ms) : 2200, 2330
. : milestone, 2265,
profiling (2.065 ms) : 2013, 2117
. : milestone, 2065,
tracing (2.045 ms) : 1994, 2095
. : milestone, 2045,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.471 ms) : 2419, 2523
. : milestone, 2471,
iast (2.214 ms) : 2150, 2279
. : milestone, 2214,
iast_GLOBAL (2.259 ms) : 2194, 2324
. : milestone, 2259,
profiling (2.093 ms) : 2038, 2147
. : milestone, 2093,
tracing (2.047 ms) : 1996, 2098
. : milestone, 2047,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~d1f7dd18c1, baseline=1.57.0-SNAPSHOT~fef9d162d8
dateFormat X
axisFormat %s
section baseline
no_agent (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
appsec (14.632 s) : 14632000, 14632000
. : milestone, 14632000,
iast (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
iast_GLOBAL (17.717 s) : 17717000, 17717000
. : milestone, 17717000,
profiling (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
tracing (14.587 s) : 14587000, 14587000
. : milestone, 14587000,
section candidate
no_agent (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
appsec (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
iast (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
iast_GLOBAL (17.736 s) : 17736000, 17736000
. : milestone, 17736000,
profiling (14.611 s) : 14611000, 14611000
. : milestone, 14611000,
tracing (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst:servlet
Servlet instrumentation
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
ServletRequest.getHeaderNames() can return null.
Fixes:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]