-
Notifications
You must be signed in to change notification settings - Fork 320
Don't send IO failures to telemetry logs #10210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 thought: Discussed internally about the impact for all various usages. Seemed the right things to exclude.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078027
Total [baseline] (10.809 s) : 0, 10809175
Agent [candidate] (1.085 s) : 0, 1085205
Total [candidate] (10.916 s) : 0, 10915641
section appsec
Agent [baseline] (1.265 s) : 0, 1264601
Total [baseline] (11.016 s) : 0, 11015960
Agent [candidate] (1.269 s) : 0, 1269001
Total [candidate] (11.126 s) : 0, 11125565
section iast
Agent [baseline] (1.227 s) : 0, 1226819
Total [baseline] (11.225 s) : 0, 11225247
Agent [candidate] (1.217 s) : 0, 1216869
Total [candidate] (11.073 s) : 0, 11073131
section profiling
Agent [baseline] (1.198 s) : 0, 1198378
Total [baseline] (10.902 s) : 0, 10901985
Agent [candidate] (1.201 s) : 0, 1200577
Total [candidate] (10.891 s) : 0, 10890522
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (646.738 ms) : 0, 646738
BytebuddyAgent [candidate] (651.035 ms) : 0, 651035
GlobalTracer [baseline] (281.313 ms) : 0, 281313
GlobalTracer [candidate] (283.323 ms) : 0, 283323
AppSec [baseline] (32.259 ms) : 0, 32259
AppSec [candidate] (32.46 ms) : 0, 32460
Debugger [baseline] (67.746 ms) : 0, 67746
Debugger [candidate] (68.087 ms) : 0, 68087
Remote Config [baseline] (607.622 µs) : 0, 608
Remote Config [candidate] (625.498 µs) : 0, 625
Telemetry [baseline] (9.033 ms) : 0, 9033
Telemetry [candidate] (9.127 ms) : 0, 9127
Flare Poller [baseline] (3.699 ms) : 0, 3699
Flare Poller [candidate] (3.746 ms) : 0, 3746
section appsec
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (689.261 ms) : 0, 689261
BytebuddyAgent [candidate] (691.662 ms) : 0, 691662
GlobalTracer [baseline] (258.661 ms) : 0, 258661
GlobalTracer [candidate] (259.408 ms) : 0, 259408
IAST [baseline] (24.537 ms) : 0, 24537
IAST [candidate] (24.786 ms) : 0, 24786
AppSec [baseline] (172.96 ms) : 0, 172960
AppSec [candidate] (173.138 ms) : 0, 173138
Debugger [baseline] (68.714 ms) : 0, 68714
Debugger [candidate] (69.494 ms) : 0, 69494
Remote Config [baseline] (714.68 µs) : 0, 715
Remote Config [candidate] (751.763 µs) : 0, 752
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (9.043 ms) : 0, 9043
Flare Poller [baseline] (3.996 ms) : 0, 3996
Flare Poller [candidate] (3.814 ms) : 0, 3814
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.164 ms) : 0, 1164
BytebuddyAgent [baseline] (793.024 ms) : 0, 793024
BytebuddyAgent [candidate] (785.867 ms) : 0, 785867
GlobalTracer [baseline] (256.673 ms) : 0, 256673
GlobalTracer [candidate] (254.784 ms) : 0, 254784
IAST [baseline] (27.182 ms) : 0, 27182
IAST [candidate] (26.918 ms) : 0, 26918
AppSec [baseline] (33.781 ms) : 0, 33781
AppSec [candidate] (33.71 ms) : 0, 33710
Debugger [baseline] (67.111 ms) : 0, 67111
Debugger [candidate] (66.764 ms) : 0, 66764
Remote Config [baseline] (582.595 µs) : 0, 583
Remote Config [candidate] (618.823 µs) : 0, 619
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (8.334 ms) : 0, 8334
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (3.504 ms) : 0, 3504
section profiling
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (697.901 ms) : 0, 697901
BytebuddyAgent [candidate] (699.113 ms) : 0, 699113
GlobalTracer [baseline] (219.88 ms) : 0, 219880
GlobalTracer [candidate] (220.897 ms) : 0, 220897
AppSec [baseline] (31.958 ms) : 0, 31958
AppSec [candidate] (32.019 ms) : 0, 32019
Debugger [baseline] (68.104 ms) : 0, 68104
Debugger [candidate] (67.926 ms) : 0, 67926
Remote Config [baseline] (610.617 µs) : 0, 611
Remote Config [candidate] (619.289 µs) : 0, 619
Telemetry [baseline] (8.913 ms) : 0, 8913
Telemetry [candidate] (8.753 ms) : 0, 8753
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (3.745 ms) : 0, 3745
ProfilingAgent [baseline] (96.648 ms) : 0, 96648
ProfilingAgent [candidate] (96.705 ms) : 0, 96705
Profiling [baseline] (97.219 ms) : 0, 97219
Profiling [candidate] (97.294 ms) : 0, 97294
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078399
Total [baseline] (8.718 s) : 0, 8717700
Agent [candidate] (1.076 s) : 0, 1076246
Total [candidate] (8.698 s) : 0, 8698309
section iast
Agent [baseline] (1.224 s) : 0, 1223586
Total [baseline] (9.476 s) : 0, 9475996
Agent [candidate] (1.23 s) : 0, 1230405
Total [candidate] (9.423 s) : 0, 9423201
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (646.734 ms) : 0, 646734
BytebuddyAgent [candidate] (645.94 ms) : 0, 645940
GlobalTracer [baseline] (281.864 ms) : 0, 281864
GlobalTracer [candidate] (281.897 ms) : 0, 281897
AppSec [baseline] (32.185 ms) : 0, 32185
AppSec [candidate] (31.996 ms) : 0, 31996
Debugger [baseline] (67.502 ms) : 0, 67502
Debugger [candidate] (66.487 ms) : 0, 66487
Remote Config [baseline] (632.783 µs) : 0, 633
Remote Config [candidate] (622.323 µs) : 0, 622
Telemetry [baseline] (9.116 ms) : 0, 9116
Telemetry [candidate] (8.943 ms) : 0, 8943
Flare Poller [baseline] (3.751 ms) : 0, 3751
Flare Poller [candidate] (3.723 ms) : 0, 3723
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (789.502 ms) : 0, 789502
BytebuddyAgent [candidate] (797.153 ms) : 0, 797153
GlobalTracer [baseline] (256.973 ms) : 0, 256973
GlobalTracer [candidate] (257.039 ms) : 0, 257039
IAST [baseline] (27.363 ms) : 0, 27363
IAST [candidate] (27.22 ms) : 0, 27220
AppSec [baseline] (33.754 ms) : 0, 33754
AppSec [candidate] (33.604 ms) : 0, 33604
Debugger [baseline] (66.804 ms) : 0, 66804
Debugger [candidate] (66.081 ms) : 0, 66081
Remote Config [baseline] (598.89 µs) : 0, 599
Remote Config [candidate] (578.745 µs) : 0, 579
Telemetry [baseline] (8.456 ms) : 0, 8456
Telemetry [candidate] (8.406 ms) : 0, 8406
Flare Poller [baseline] (3.584 ms) : 0, 3584
Flare Poller [candidate] (3.526 ms) : 0, 3526
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section baseline
no_agent (19.0 ms) : 18809, 19191
. : milestone, 19000,
appsec (18.959 ms) : 18768, 19151
. : milestone, 18959,
code_origins (17.766 ms) : 17587, 17945
. : milestone, 17766,
iast (17.664 ms) : 17490, 17839
. : milestone, 17664,
profiling (19.883 ms) : 19682, 20083
. : milestone, 19883,
tracing (17.588 ms) : 17415, 17761
. : milestone, 17588,
section candidate
no_agent (18.174 ms) : 17989, 18359
. : milestone, 18174,
appsec (18.378 ms) : 18191, 18566
. : milestone, 18378,
code_origins (17.754 ms) : 17576, 17931
. : milestone, 17754,
iast (17.757 ms) : 17581, 17932
. : milestone, 17757,
profiling (18.755 ms) : 18571, 18939
. : milestone, 18755,
tracing (18.089 ms) : 17908, 18269
. : milestone, 18089,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.209 ms) : 1197, 1221
. : milestone, 1209,
iast (3.231 ms) : 3190, 3273
. : milestone, 3231,
iast_FULL (5.763 ms) : 5705, 5820
. : milestone, 5763,
iast_GLOBAL (3.652 ms) : 3599, 3705
. : milestone, 3652,
profiling (1.965 ms) : 1947, 1984
. : milestone, 1965,
tracing (1.816 ms) : 1801, 1831
. : milestone, 1816,
section candidate
no_agent (1.204 ms) : 1192, 1216
. : milestone, 1204,
iast (3.054 ms) : 3018, 3091
. : milestone, 3054,
iast_FULL (5.939 ms) : 5878, 6000
. : milestone, 5939,
iast_GLOBAL (3.65 ms) : 3592, 3709
. : milestone, 3650,
profiling (2.222 ms) : 2202, 2243
. : milestone, 2222,
tracing (1.837 ms) : 1822, 1852
. : milestone, 1837,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.486 ms) : 2434, 2538
. : milestone, 2486,
iast (2.217 ms) : 2152, 2281
. : milestone, 2217,
iast_GLOBAL (2.267 ms) : 2201, 2332
. : milestone, 2267,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.062 ms) : 2010, 2113
. : milestone, 2062,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.727 ms) : 3508, 3946
. : milestone, 3727,
iast (2.216 ms) : 2151, 2281
. : milestone, 2216,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.083 ms) : 2030, 2136
. : milestone, 2083,
tracing (2.06 ms) : 2009, 2112
. : milestone, 2060,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~be072c8003, baseline=1.57.0-SNAPSHOT~1f4c004d2a
dateFormat X
axisFormat %s
section baseline
no_agent (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (17.837 s) : 17837000, 17837000
. : milestone, 17837000,
iast_GLOBAL (17.73 s) : 17730000, 17730000
. : milestone, 17730000,
profiling (15.098 s) : 15098000, 15098000
. : milestone, 15098000,
tracing (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
section candidate
no_agent (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
appsec (14.837 s) : 14837000, 14837000
. : milestone, 14837000,
iast (18.345 s) : 18345000, 18345000
. : milestone, 18345000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
. : milestone, 17790000,
profiling (14.607 s) : 14607000, 14607000
. : milestone, 14607000,
tracing (14.547 s) : 14547000, 14547000
. : milestone, 14547000,
|
What Does This Do
There is no reason to send such kind of logs to the telemetry. For diagnostics, there are already metrics created for that.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]