Skip to content

Avoid NPE on QuartzDecorator #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 1 commit into from
Dec 12, 2025
Merged

Avoid NPE on QuartzDecorator #10181

amarziali merged 1 commit into from
Dec 12, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Dec 12, 2025

What Does This Do

Correctly protects from null access variables used on QuartzDecorator.

Solves:

java.lang.NullPointerException
  at datadog.trace.instrumentation.quartz.QuartzDecorator.onExecute(QuartzDecorator.java:37)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner December 12, 2025 11:14
@amarziali amarziali added type: bug Bug report and fix inst: others All other instrumentations tag: telemetry error reported Reported by error telemetry labels Dec 12, 2025
@amarziali amarziali enabled auto-merge (squash) December 12, 2025 11:16
bric3
bric3 reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it makes sense to set default values?

@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/quartz
git_commit_date 1765529699 1765537994
git_commit_sha 552ae2b 8bd6dd3
release_version 1.57.0-SNAPSHOT~552ae2be7d 1.57.0-SNAPSHOT~8bd6dd3852
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765539783 1765539783
ci_job_id 1290270718 1290270718
ci_pipeline_id 86442771 86442771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-hijm6ufn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-hijm6ufn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079332
Total [baseline] (8.772 s) : 0, 8772319
Agent [candidate] (1.086 s) : 0, 1086329
Total [candidate] (8.789 s) : 0, 8788713
section iast
Agent [baseline] (1.219 s) : 0, 1218535
Total [baseline] (9.365 s) : 0, 9365413
Agent [candidate] (1.224 s) : 0, 1224419
Total [candidate] (9.437 s) : 0, 9437379
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent iast 1.219 s 139.203 ms (12.9%)
Total tracing 8.772 s -
Total iast 9.365 s 593.094 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.224 s 138.09 ms (12.7%)
Total tracing 8.789 s -
Total iast 9.437 s 648.665 ms (7.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (648.546 ms) : 0, 648546
BytebuddyAgent [candidate] (653.675 ms) : 0, 653675
GlobalTracer [baseline] (281.238 ms) : 0, 281238
GlobalTracer [candidate] (282.961 ms) : 0, 282961
AppSec [baseline] (32.27 ms) : 0, 32270
AppSec [candidate] (32.495 ms) : 0, 32495
Debugger [baseline] (67.194 ms) : 0, 67194
Debugger [candidate] (66.816 ms) : 0, 66816
Remote Config [baseline] (638.553 µs) : 0, 639
Remote Config [candidate] (633.225 µs) : 0, 633
Telemetry [baseline] (8.867 ms) : 0, 8867
Telemetry [candidate] (9.018 ms) : 0, 9018
Flare Poller [baseline] (3.735 ms) : 0, 3735
Flare Poller [candidate] (3.679 ms) : 0, 3679
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (788.324 ms) : 0, 788324
BytebuddyAgent [candidate] (792.255 ms) : 0, 792255
GlobalTracer [baseline] (255.01 ms) : 0, 255010
GlobalTracer [candidate] (256.626 ms) : 0, 256626
IAST [baseline] (26.786 ms) : 0, 26786
IAST [candidate] (26.913 ms) : 0, 26913
AppSec [baseline] (35.573 ms) : 0, 35573
AppSec [candidate] (32.821 ms) : 0, 32821
Debugger [baseline] (63.658 ms) : 0, 63658
Debugger [candidate] (66.675 ms) : 0, 66675
Remote Config [baseline] (566.602 µs) : 0, 567
Remote Config [candidate] (542.178 µs) : 0, 542
Telemetry [baseline] (8.421 ms) : 0, 8421
Telemetry [candidate] (8.368 ms) : 0, 8368
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.481 ms) : 0, 3481
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084407
Total [baseline] (10.802 s) : 0, 10801984
Agent [candidate] (1.082 s) : 0, 1082338
Total [candidate] (10.911 s) : 0, 10911414
section appsec
Agent [baseline] (1.27 s) : 0, 1270482
Total [baseline] (10.991 s) : 0, 10990643
Agent [candidate] (1.27 s) : 0, 1269972
Total [candidate] (10.999 s) : 0, 10999340
section iast
Agent [baseline] (1.221 s) : 0, 1221231
Total [baseline] (11.262 s) : 0, 11261651
Agent [candidate] (1.232 s) : 0, 1232308
Total [candidate] (11.234 s) : 0, 11234315
section profiling
Agent [baseline] (1.205 s) : 0, 1205146
Total [baseline] (10.861 s) : 0, 10861394
Agent [candidate] (1.209 s) : 0, 1208754
Total [candidate] (10.923 s) : 0, 10922798
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.27 s 186.075 ms (17.2%)
Agent iast 1.221 s 136.824 ms (12.6%)
Agent profiling 1.205 s 120.739 ms (11.1%)
Total tracing 10.802 s -
Total appsec 10.991 s 188.659 ms (1.7%)
Total iast 11.262 s 459.668 ms (4.3%)
Total profiling 10.861 s 59.411 ms (0.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.27 s 187.634 ms (17.3%)
Agent iast 1.232 s 149.97 ms (13.9%)
Agent profiling 1.209 s 126.416 ms (11.7%)
Total tracing 10.911 s -
Total appsec 10.999 s 87.926 ms (0.8%)
Total iast 11.234 s 322.901 ms (3.0%)
Total profiling 10.923 s 11.384 ms (0.1%) 
gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (651.054 ms) : 0, 651054
BytebuddyAgent [candidate] (649.562 ms) : 0, 649562
GlobalTracer [baseline] (282.229 ms) : 0, 282229
GlobalTracer [candidate] (281.834 ms) : 0, 281834
AppSec [baseline] (32.483 ms) : 0, 32483
AppSec [candidate] (32.44 ms) : 0, 32440
Debugger [baseline] (68.445 ms) : 0, 68445
Debugger [candidate] (68.329 ms) : 0, 68329
Remote Config [baseline] (650.917 µs) : 0, 651
Remote Config [candidate] (639.398 µs) : 0, 639
Telemetry [baseline] (9.009 ms) : 0, 9009
Telemetry [candidate] (9.033 ms) : 0, 9033
Flare Poller [baseline] (3.736 ms) : 0, 3736
Flare Poller [candidate] (3.758 ms) : 0, 3758
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (690.633 ms) : 0, 690633
BytebuddyAgent [candidate] (691.412 ms) : 0, 691412
GlobalTracer [baseline] (260.976 ms) : 0, 260976
GlobalTracer [candidate] (258.749 ms) : 0, 258749
IAST [baseline] (24.881 ms) : 0, 24881
IAST [candidate] (24.487 ms) : 0, 24487
AppSec [baseline] (175.948 ms) : 0, 175948
AppSec [candidate] (176.107 ms) : 0, 176107
Debugger [baseline] (67.651 ms) : 0, 67651
Debugger [candidate] (68.285 ms) : 0, 68285
Remote Config [baseline] (660.993 µs) : 0, 661
Remote Config [candidate] (744.644 µs) : 0, 745
Telemetry [baseline] (9.096 ms) : 0, 9096
Telemetry [candidate] (9.301 ms) : 0, 9301
Flare Poller [baseline] (3.8 ms) : 0, 3800
Flare Poller [candidate] (4.041 ms) : 0, 4041
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (789.346 ms) : 0, 789346
BytebuddyAgent [candidate] (797.987 ms) : 0, 797987
GlobalTracer [baseline] (255.313 ms) : 0, 255313
GlobalTracer [candidate] (257.768 ms) : 0, 257768
IAST [baseline] (26.764 ms) : 0, 26764
IAST [candidate] (27.188 ms) : 0, 27188
AppSec [baseline] (35.357 ms) : 0, 35357
AppSec [candidate] (35.008 ms) : 0, 35008
Debugger [baseline] (65.506 ms) : 0, 65506
Debugger [candidate] (65.093 ms) : 0, 65093
Remote Config [baseline] (542.022 µs) : 0, 542
Remote Config [candidate] (536.704 µs) : 0, 537
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (8.394 ms) : 0, 8394
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.507 ms) : 0, 3507
section profiling
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (701.8 ms) : 0, 701800
BytebuddyAgent [candidate] (703.357 ms) : 0, 703357
GlobalTracer [baseline] (221.38 ms) : 0, 221380
GlobalTracer [candidate] (221.892 ms) : 0, 221892
AppSec [baseline] (32.17 ms) : 0, 32170
AppSec [candidate] (32.497 ms) : 0, 32497
Debugger [baseline] (68.652 ms) : 0, 68652
Debugger [candidate] (68.868 ms) : 0, 68868
Remote Config [baseline] (639.697 µs) : 0, 640
Remote Config [candidate] (671.774 µs) : 0, 672
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (9.099 ms) : 0, 9099
Flare Poller [baseline] (3.789 ms) : 0, 3789
Flare Poller [candidate] (3.808 ms) : 0, 3808
ProfilingAgent [baseline] (96.542 ms) : 0, 96542
ProfilingAgent [candidate] (97.312 ms) : 0, 97312
Profiling [baseline] (97.115 ms) : 0, 97115
Profiling [candidate] (97.894 ms) : 0, 97894
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/quartz
git_commit_date 1765529699 1765537994
git_commit_sha 552ae2b 8bd6dd3
release_version 1.57.0-SNAPSHOT~552ae2be7d 1.57.0-SNAPSHOT~8bd6dd3852
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765540288 1765540288
ci_job_id 1290270719 1290270719
ci_pipeline_id 86442771 86442771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-bw0ybekl 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-bw0ybekl 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load better
[-494.923µs; -159.259µs] or [-9.371%; -3.015%]		 better
[-1.711ms; -0.505ms] or [-13.375%; -3.951%]		 unstable
[-44.881op/s; +142.193op/s] or [-5.760%; +18.247%]		 4.954ms 11.685ms 827.906op/s 5.282ms 12.794ms 779.250op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.198 ms) : 1187, 1210
.   : milestone, 1198,
iast (3.216 ms) : 3171, 3260
.   : milestone, 3216,
iast_FULL (5.933 ms) : 5872, 5994
.   : milestone, 5933,
iast_GLOBAL (3.581 ms) : 3529, 3634
.   : milestone, 3581,
profiling (2.116 ms) : 2097, 2134
.   : milestone, 2116,
tracing (1.822 ms) : 1806, 1838
.   : milestone, 1822,
section candidate
no_agent (1.233 ms) : 1221, 1244
.   : milestone, 1233,
iast (3.216 ms) : 3174, 3258
.   : milestone, 3216,
iast_FULL (5.582 ms) : 5527, 5637
.   : milestone, 5582,
iast_GLOBAL (3.588 ms) : 3532, 3644
.   : milestone, 3588,
profiling (2.019 ms) : 2001, 2036
.   : milestone, 2019,
tracing (1.874 ms) : 1858, 1891
.   : milestone, 1874,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.198 ms [1.187 ms, 1.21 ms] -
iast 3.216 ms [3.171 ms, 3.26 ms] 2.018 ms (168.4%)
iast_FULL 5.933 ms [5.872 ms, 5.994 ms] 4.735 ms (395.2%)
iast_GLOBAL 3.581 ms [3.529 ms, 3.634 ms] 2.383 ms (198.9%)
profiling 2.116 ms [2.097 ms, 2.134 ms] 917.569 µs (76.6%)
tracing 1.822 ms [1.806 ms, 1.838 ms] 623.856 µs (52.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.233 ms [1.221 ms, 1.244 ms] -
iast 3.216 ms [3.174 ms, 3.258 ms] 1.983 ms (160.9%)
iast_FULL 5.582 ms [5.527 ms, 5.637 ms] 4.349 ms (352.8%)
iast_GLOBAL 3.588 ms [3.532 ms, 3.644 ms] 2.355 ms (191.0%)
profiling 2.019 ms [2.001 ms, 2.036 ms] 785.622 µs (63.7%)
tracing 1.874 ms [1.858 ms, 1.891 ms] 641.212 µs (52.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.103 ms) : 16933, 17273
.   : milestone, 17103,
appsec (18.729 ms) : 18538, 18919
.   : milestone, 18729,
code_origins (18.493 ms) : 18306, 18679
.   : milestone, 18493,
iast (17.726 ms) : 17552, 17900
.   : milestone, 17726,
profiling (19.847 ms) : 19638, 20056
.   : milestone, 19847,
tracing (17.875 ms) : 17698, 18051
.   : milestone, 17875,
section candidate
no_agent (17.201 ms) : 17027, 17374
.   : milestone, 17201,
appsec (18.384 ms) : 18200, 18569
.   : milestone, 18384,
code_origins (18.771 ms) : 18583, 18960
.   : milestone, 18771,
iast (18.069 ms) : 17887, 18251
.   : milestone, 18069,
profiling (20.025 ms) : 19815, 20236
.   : milestone, 20025,
tracing (17.533 ms) : 17360, 17707
.   : milestone, 17533,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.103 ms [16.933 ms, 17.273 ms] -
appsec 18.729 ms [18.538 ms, 18.919 ms] 1.626 ms (9.5%)
code_origins 18.493 ms [18.306 ms, 18.679 ms] 1.389 ms (8.1%)
iast 17.726 ms [17.552 ms, 17.9 ms] 622.514 µs (3.6%)
profiling 19.847 ms [19.638 ms, 20.056 ms] 2.744 ms (16.0%)
tracing 17.875 ms [17.698 ms, 18.051 ms] 771.713 µs (4.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.201 ms [17.027 ms, 17.374 ms] -
appsec 18.384 ms [18.2 ms, 18.569 ms] 1.183 ms (6.9%)
code_origins 18.771 ms [18.583 ms, 18.96 ms] 1.571 ms (9.1%)
iast 18.069 ms [17.887 ms, 18.251 ms] 868.031 µs (5.0%)
profiling 20.025 ms [19.815 ms, 20.236 ms] 2.825 ms (16.4%)
tracing 17.533 ms [17.36 ms, 17.707 ms] 332.427 µs (1.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/quartz
git_commit_date 1765529699 1765537994
git_commit_sha 552ae2b 8bd6dd3
release_version 1.57.0-SNAPSHOT~552ae2be7d 1.57.0-SNAPSHOT~8bd6dd3852
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1765539980 1765539980
ci_job_id 1290270720 1290270720
ci_pipeline_id 86442771 86442771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-srtg4za6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-srtg4za6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
.   : milestone, 1484,
appsec (2.477 ms) : 2426, 2529
.   : milestone, 2477,
iast (2.231 ms) : 2167, 2296
.   : milestone, 2231,
iast_GLOBAL (2.275 ms) : 2210, 2339
.   : milestone, 2275,
profiling (2.081 ms) : 2029, 2133
.   : milestone, 2081,
tracing (2.061 ms) : 2011, 2112
.   : milestone, 2061,
section candidate
no_agent (1.491 ms) : 1479, 1502
.   : milestone, 1491,
appsec (3.724 ms) : 3505, 3943
.   : milestone, 3724,
iast (2.224 ms) : 2160, 2289
.   : milestone, 2224,
iast_GLOBAL (2.276 ms) : 2212, 2341
.   : milestone, 2276,
profiling (2.469 ms) : 2318, 2620
.   : milestone, 2469,
tracing (2.065 ms) : 2014, 2116
.   : milestone, 2065,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.484 ms [1.472 ms, 1.496 ms] -
appsec 2.477 ms [2.426 ms, 2.529 ms] 993.021 µs (66.9%)
iast 2.231 ms [2.167 ms, 2.296 ms] 747.413 µs (50.4%)
iast_GLOBAL 2.275 ms [2.21 ms, 2.339 ms] 790.714 µs (53.3%)
profiling 2.081 ms [2.029 ms, 2.133 ms] 596.995 µs (40.2%)
tracing 2.061 ms [2.011 ms, 2.112 ms] 577.369 µs (38.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.491 ms [1.479 ms, 1.502 ms] -
appsec 3.724 ms [3.505 ms, 3.943 ms] 2.233 ms (149.8%)
iast 2.224 ms [2.16 ms, 2.289 ms] 733.558 µs (49.2%)
iast_GLOBAL 2.276 ms [2.212 ms, 2.341 ms] 785.613 µs (52.7%)
profiling 2.469 ms [2.318 ms, 2.62 ms] 978.489 µs (65.6%)
tracing 2.065 ms [2.014 ms, 2.116 ms] 574.192 µs (38.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~8bd6dd3852, baseline=1.57.0-SNAPSHOT~552ae2be7d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.307 s) : 15307000, 15307000
.   : milestone, 15307000,
appsec (14.716 s) : 14716000, 14716000
.   : milestone, 14716000,
iast (17.981 s) : 17981000, 17981000
.   : milestone, 17981000,
iast_GLOBAL (17.756 s) : 17756000, 17756000
.   : milestone, 17756000,
profiling (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
tracing (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
section candidate
no_agent (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
appsec (14.874 s) : 14874000, 14874000
.   : milestone, 14874000,
iast (18.178 s) : 18178000, 18178000
.   : milestone, 18178000,
iast_GLOBAL (18.004 s) : 18004000, 18004000
.   : milestone, 18004000,
profiling (14.672 s) : 14672000, 14672000
.   : milestone, 14672000,
tracing (14.558 s) : 14558000, 14558000
.   : milestone, 14558000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.307 s [15.307 s, 15.307 s] -
appsec 14.716 s [14.716 s, 14.716 s] -591.0 ms (-3.9%)
iast 17.981 s [17.981 s, 17.981 s] 2.674 s (17.5%)
iast_GLOBAL 17.756 s [17.756 s, 17.756 s] 2.449 s (16.0%)
profiling 15.113 s [15.113 s, 15.113 s] -194.0 ms (-1.3%)
tracing 15.011 s [15.011 s, 15.011 s] -296.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.008 s [15.008 s, 15.008 s] -
appsec 14.874 s [14.874 s, 14.874 s] -134.0 ms (-0.9%)
iast 18.178 s [18.178 s, 18.178 s] 3.17 s (21.1%)
iast_GLOBAL 18.004 s [18.004 s, 18.004 s] 2.996 s (20.0%)
profiling 14.672 s [14.672 s, 14.672 s] -336.0 ms (-2.2%)
tracing 14.558 s [14.558 s, 14.558 s] -450.0 ms (-3.0%)

@amarziali
Copy link
Contributor Author

amarziali commented Dec 12, 2025

Could it makes sense to set default values?

Not here. The tag is only set if there is something. For the resource name, the sane default will be the same as the operation name (is already set on the tracer side IIRC)

PerfectSlayer
PerfectSlayer approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@amarziali amarziali merged commit b1be9b3 into master Dec 12, 2025
554 of 556 checks passed
@amarziali amarziali deleted the andrea.marziali/quartz branch December 12, 2025 12:43
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 left review comments

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

inst: others All other instrumentations tag: telemetry error reported Reported by error telemetry type: bug Bug report and fix

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @bric3 @PerfectSlayer