-
Notifications
You must be signed in to change notification settings - Fork 320
Avoid NPE when setting resource with null path #10180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
approved these changes
Dec 12, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079449
Total [baseline] (10.872 s) : 0, 10872091
Agent [candidate] (1.087 s) : 0, 1087469
Total [candidate] (10.818 s) : 0, 10817598
section appsec
Agent [baseline] (1.261 s) : 0, 1261294
Total [baseline] (10.973 s) : 0, 10973254
Agent [candidate] (1.269 s) : 0, 1269020
Total [candidate] (10.967 s) : 0, 10967297
section iast
Agent [baseline] (1.223 s) : 0, 1222691
Total [baseline] (11.203 s) : 0, 11203388
Agent [candidate] (1.223 s) : 0, 1222857
Total [candidate] (11.203 s) : 0, 11203113
section profiling
Agent [baseline] (1.205 s) : 0, 1204592
Total [baseline] (10.914 s) : 0, 10914491
Agent [candidate] (1.203 s) : 0, 1202986
Total [candidate] (10.956 s) : 0, 10956201
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (647.978 ms) : 0, 647978
BytebuddyAgent [candidate] (652.797 ms) : 0, 652797
GlobalTracer [baseline] (281.17 ms) : 0, 281170
GlobalTracer [candidate] (283.125 ms) : 0, 283125
AppSec [baseline] (32.225 ms) : 0, 32225
AppSec [candidate] (32.566 ms) : 0, 32566
Debugger [baseline] (68.118 ms) : 0, 68118
Debugger [candidate] (68.557 ms) : 0, 68557
Remote Config [baseline] (630.092 µs) : 0, 630
Remote Config [candidate] (662.529 µs) : 0, 663
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (9.177 ms) : 0, 9177
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.787 ms) : 0, 3787
section appsec
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (687.742 ms) : 0, 687742
BytebuddyAgent [candidate] (693.48 ms) : 0, 693480
GlobalTracer [baseline] (257.954 ms) : 0, 257954
GlobalTracer [candidate] (259.205 ms) : 0, 259205
AppSec [baseline] (174.525 ms) : 0, 174525
AppSec [candidate] (174.284 ms) : 0, 174284
Debugger [baseline] (66.497 ms) : 0, 66497
Debugger [candidate] (66.974 ms) : 0, 66974
Remote Config [baseline] (699.287 µs) : 0, 699
Remote Config [candidate] (740.678 µs) : 0, 741
Telemetry [baseline] (8.951 ms) : 0, 8951
Telemetry [candidate] (9.18 ms) : 0, 9180
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.932 ms) : 0, 3932
IAST [baseline] (24.497 ms) : 0, 24497
IAST [candidate] (24.468 ms) : 0, 24468
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (791.193 ms) : 0, 791193
BytebuddyAgent [candidate] (791.19 ms) : 0, 791190
GlobalTracer [baseline] (255.42 ms) : 0, 255420
GlobalTracer [candidate] (255.759 ms) : 0, 255759
AppSec [baseline] (35.039 ms) : 0, 35039
AppSec [candidate] (34.987 ms) : 0, 34987
Debugger [baseline] (65.167 ms) : 0, 65167
Debugger [candidate] (65.09 ms) : 0, 65090
Remote Config [baseline] (558.117 µs) : 0, 558
Remote Config [candidate] (545.653 µs) : 0, 546
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (8.385 ms) : 0, 8385
Flare Poller [baseline] (3.502 ms) : 0, 3502
Flare Poller [candidate] (3.477 ms) : 0, 3477
IAST [baseline] (26.945 ms) : 0, 26945
IAST [candidate] (26.849 ms) : 0, 26849
section profiling
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (701.619 ms) : 0, 701619
BytebuddyAgent [candidate] (700.643 ms) : 0, 700643
GlobalTracer [baseline] (221.293 ms) : 0, 221293
GlobalTracer [candidate] (220.758 ms) : 0, 220758
AppSec [baseline] (32.198 ms) : 0, 32198
AppSec [candidate] (31.904 ms) : 0, 31904
Debugger [baseline] (68.205 ms) : 0, 68205
Debugger [candidate] (68.656 ms) : 0, 68656
Remote Config [baseline] (644.787 µs) : 0, 645
Remote Config [candidate] (633.293 µs) : 0, 633
Telemetry [baseline] (9.141 ms) : 0, 9141
Telemetry [candidate] (8.974 ms) : 0, 8974
Flare Poller [baseline] (3.805 ms) : 0, 3805
Flare Poller [candidate] (3.717 ms) : 0, 3717
ProfilingAgent [baseline] (96.563 ms) : 0, 96563
ProfilingAgent [candidate] (96.77 ms) : 0, 96770
Profiling [baseline] (97.141 ms) : 0, 97141
Profiling [candidate] (97.355 ms) : 0, 97355
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078659
Total [baseline] (8.722 s) : 0, 8721974
Agent [candidate] (1.079 s) : 0, 1078530
Total [candidate] (8.747 s) : 0, 8746593
section iast
Agent [baseline] (1.218 s) : 0, 1217690
Total [baseline] (9.343 s) : 0, 9342510
Agent [candidate] (1.229 s) : 0, 1228736
Total [candidate] (9.376 s) : 0, 9376031
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (648.426 ms) : 0, 648426
BytebuddyAgent [candidate] (647.475 ms) : 0, 647475
GlobalTracer [baseline] (281.054 ms) : 0, 281054
GlobalTracer [candidate] (281.329 ms) : 0, 281329
AppSec [baseline] (32.272 ms) : 0, 32272
AppSec [candidate] (32.391 ms) : 0, 32391
Debugger [baseline] (66.952 ms) : 0, 66952
Debugger [candidate] (67.169 ms) : 0, 67169
Remote Config [baseline] (629.701 µs) : 0, 630
Remote Config [candidate] (644.208 µs) : 0, 644
Telemetry [baseline] (8.954 ms) : 0, 8954
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.745 ms) : 0, 3745
Flare Poller [candidate] (3.792 ms) : 0, 3792
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (788.3 ms) : 0, 788300
BytebuddyAgent [candidate] (796.81 ms) : 0, 796810
GlobalTracer [baseline] (254.784 ms) : 0, 254784
GlobalTracer [candidate] (256.804 ms) : 0, 256804
AppSec [baseline] (34.923 ms) : 0, 34923
AppSec [candidate] (34.183 ms) : 0, 34183
Debugger [baseline] (63.908 ms) : 0, 63908
Debugger [candidate] (64.937 ms) : 0, 64937
Remote Config [baseline] (556.896 µs) : 0, 557
Remote Config [candidate] (542.492 µs) : 0, 542
Telemetry [baseline] (8.372 ms) : 0, 8372
Telemetry [candidate] (8.41 ms) : 0, 8410
Flare Poller [baseline] (3.456 ms) : 0, 3456
Flare Poller [candidate] (3.495 ms) : 0, 3495
IAST [baseline] (26.909 ms) : 0, 26909
IAST [candidate] (26.812 ms) : 0, 26812
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1179, 1202
. : milestone, 1191,
iast (3.275 ms) : 3230, 3321
. : milestone, 3275,
iast_FULL (5.815 ms) : 5756, 5874
. : milestone, 5815,
iast_GLOBAL (3.556 ms) : 3500, 3612
. : milestone, 3556,
profiling (2.2 ms) : 2180, 2221
. : milestone, 2200,
tracing (1.805 ms) : 1790, 1821
. : milestone, 1805,
section candidate
no_agent (1.195 ms) : 1184, 1206
. : milestone, 1195,
iast (3.101 ms) : 3062, 3139
. : milestone, 3101,
iast_FULL (5.859 ms) : 5800, 5918
. : milestone, 5859,
iast_GLOBAL (3.625 ms) : 3572, 3677
. : milestone, 3625,
profiling (2.026 ms) : 2009, 2043
. : milestone, 2026,
tracing (1.85 ms) : 1833, 1868
. : milestone, 1850,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (19.534 ms) : 19332, 19735
. : milestone, 19534,
appsec (19.858 ms) : 19656, 20061
. : milestone, 19858,
code_origins (17.572 ms) : 17394, 17751
. : milestone, 17572,
iast (17.459 ms) : 17286, 17632
. : milestone, 17459,
profiling (18.583 ms) : 18398, 18767
. : milestone, 18583,
tracing (18.705 ms) : 18518, 18893
. : milestone, 18705,
section candidate
no_agent (19.166 ms) : 18968, 19364
. : milestone, 19166,
appsec (19.209 ms) : 19017, 19401
. : milestone, 19209,
code_origins (18.075 ms) : 17889, 18262
. : milestone, 18075,
iast (17.535 ms) : 17363, 17708
. : milestone, 17535,
profiling (20.169 ms) : 19964, 20374
. : milestone, 20169,
tracing (17.728 ms) : 17552, 17904
. : milestone, 17728,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1475, 1498
. : milestone, 1486,
appsec (2.796 ms) : 2712, 2880
. : milestone, 2796,
iast (2.588 ms) : 2486, 2690
. : milestone, 2588,
iast_GLOBAL (2.631 ms) : 2529, 2733
. : milestone, 2631,
profiling (2.446 ms) : 2358, 2534
. : milestone, 2446,
tracing (2.384 ms) : 2301, 2467
. : milestone, 2384,
section candidate
no_agent (1.496 ms) : 1485, 1508
. : milestone, 1496,
appsec (4.166 ms) : 3912, 4421
. : milestone, 4166,
iast (2.585 ms) : 2483, 2686
. : milestone, 2585,
iast_GLOBAL (2.623 ms) : 2521, 2724
. : milestone, 2623,
profiling (2.393 ms) : 2307, 2478
. : milestone, 2393,
tracing (2.376 ms) : 2292, 2459
. : milestone, 2376,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~0521eba6a1, baseline=1.57.0-SNAPSHOT~552ae2be7d
dateFormat X
axisFormat %s
section baseline
no_agent (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
appsec (14.344 s) : 14344000, 14344000
. : milestone, 14344000,
iast (17.338 s) : 17338000, 17338000
. : milestone, 17338000,
iast_GLOBAL (17.043 s) : 17043000, 17043000
. : milestone, 17043000,
profiling (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
tracing (14.109 s) : 14109000, 14109000
. : milestone, 14109000,
section candidate
no_agent (15.115 s) : 15115000, 15115000
. : milestone, 15115000,
appsec (14.592 s) : 14592000, 14592000
. : milestone, 14592000,
iast (17.663 s) : 17663000, 17663000
. : milestone, 17663000,
iast_GLOBAL (17.058 s) : 17058000, 17058000
. : milestone, 17058000,
profiling (14.25 s) : 14250000, 14250000
. : milestone, 14250000,
tracing (14.259 s) : 14259000, 14259000
. : milestone, 14259000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: others
All other instrumentations
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
When setting client/server resource name from the path, the path must not be null. This was already checked on the tag interceptor but not from the calls coming from instrumentations. This PR enforces this check
Avoids:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]