-
Notifications
You must be signed in to change notification settings - Fork 320
Fix metric expressions with @return
#10178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When compiling the metric expression using @return synthetic variable, the type of @return was not propagated correctly and the generic Object type was used instead which prevent to call length() when this is a String. Fix also reporting errors as ProbeSatus by returning Error status when instrumenting.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
@return
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (314.941 µs) : 292, 338
. : milestone, 315,
basic (281.794 µs) : 276, 288
. : milestone, 282,
loop (8.967 ms) : 8963, 8972
. : milestone, 8967,
section candidate
noprobe (322.525 µs) : 289, 356
. : milestone, 323,
basic (284.209 µs) : 277, 291
. : milestone, 284,
loop (8.962 ms) : 8958, 8966
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081207
Total [baseline] (8.771 s) : 0, 8770540
Agent [candidate] (1.08 s) : 0, 1080411
Total [candidate] (8.801 s) : 0, 8800554
section iast
Agent [baseline] (1.219 s) : 0, 1218798
Total [baseline] (9.454 s) : 0, 9453883
Agent [candidate] (1.23 s) : 0, 1229780
Total [candidate] (9.497 s) : 0, 9496952
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (649.405 ms) : 0, 649405
BytebuddyAgent [candidate] (648.408 ms) : 0, 648408
GlobalTracer [baseline] (282.237 ms) : 0, 282237
GlobalTracer [candidate] (282.058 ms) : 0, 282058
AppSec [baseline] (32.251 ms) : 0, 32251
AppSec [candidate] (32.298 ms) : 0, 32298
Debugger [baseline] (67.057 ms) : 0, 67057
Debugger [candidate] (67.464 ms) : 0, 67464
Remote Config [baseline] (654.945 µs) : 0, 655
Remote Config [candidate] (650.139 µs) : 0, 650
Telemetry [baseline] (9.002 ms) : 0, 9002
Telemetry [candidate] (9.017 ms) : 0, 9017
Flare Poller [baseline] (3.712 ms) : 0, 3712
Flare Poller [candidate] (3.767 ms) : 0, 3767
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (788.285 ms) : 0, 788285
BytebuddyAgent [candidate] (795.345 ms) : 0, 795345
GlobalTracer [baseline] (255.005 ms) : 0, 255005
GlobalTracer [candidate] (257.222 ms) : 0, 257222
AppSec [baseline] (33.658 ms) : 0, 33658
AppSec [candidate] (35.643 ms) : 0, 35643
Debugger [baseline] (66.03 ms) : 0, 66030
Debugger [candidate] (65.048 ms) : 0, 65048
Remote Config [baseline] (536.66 µs) : 0, 537
Remote Config [candidate] (546.457 µs) : 0, 546
Telemetry [baseline] (8.399 ms) : 0, 8399
Telemetry [candidate] (8.467 ms) : 0, 8467
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.506 ms) : 0, 3506
IAST [baseline] (26.761 ms) : 0, 26761
IAST [candidate] (27.147 ms) : 0, 27147
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086241
Total [baseline] (10.881 s) : 0, 10881445
Agent [candidate] (1.081 s) : 0, 1080960
Total [candidate] (10.866 s) : 0, 10866191
section appsec
Agent [baseline] (1.272 s) : 0, 1272248
Total [baseline] (11.151 s) : 0, 11151346
Agent [candidate] (1.266 s) : 0, 1265730
Total [candidate] (11.105 s) : 0, 11105353
section iast
Agent [baseline] (1.222 s) : 0, 1222227
Total [baseline] (11.124 s) : 0, 11123854
Agent [candidate] (1.232 s) : 0, 1232069
Total [candidate] (11.102 s) : 0, 11101677
section profiling
Agent [baseline] (1.212 s) : 0, 1211573
Total [baseline] (10.947 s) : 0, 10947412
Agent [candidate] (1.208 s) : 0, 1208203
Total [candidate] (11.054 s) : 0, 11053895
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (651.791 ms) : 0, 651791
BytebuddyAgent [candidate] (648.298 ms) : 0, 648298
GlobalTracer [baseline] (283.168 ms) : 0, 283168
GlobalTracer [candidate] (281.896 ms) : 0, 281896
AppSec [baseline] (32.557 ms) : 0, 32557
AppSec [candidate] (32.173 ms) : 0, 32173
Debugger [baseline] (68.453 ms) : 0, 68453
Debugger [candidate] (68.556 ms) : 0, 68556
Remote Config [baseline] (623.149 µs) : 0, 623
Remote Config [candidate] (619.61 µs) : 0, 620
Telemetry [baseline] (8.986 ms) : 0, 8986
Telemetry [candidate] (8.971 ms) : 0, 8971
Flare Poller [baseline] (3.702 ms) : 0, 3702
Flare Poller [candidate] (3.691 ms) : 0, 3691
section appsec
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (693.803 ms) : 0, 693803
BytebuddyAgent [candidate] (689.758 ms) : 0, 689758
GlobalTracer [baseline] (260.74 ms) : 0, 260740
GlobalTracer [candidate] (259.329 ms) : 0, 259329
IAST [baseline] (24.834 ms) : 0, 24834
IAST [candidate] (24.656 ms) : 0, 24656
AppSec [baseline] (175.72 ms) : 0, 175720
AppSec [candidate] (175.207 ms) : 0, 175207
Debugger [baseline] (66.545 ms) : 0, 66545
Debugger [candidate] (66.481 ms) : 0, 66481
Remote Config [baseline] (733.538 µs) : 0, 734
Remote Config [candidate] (710.304 µs) : 0, 710
Telemetry [baseline] (9.028 ms) : 0, 9028
Telemetry [candidate] (8.916 ms) : 0, 8916
Flare Poller [baseline] (3.89 ms) : 0, 3890
Flare Poller [candidate] (3.811 ms) : 0, 3811
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (790.077 ms) : 0, 790077
BytebuddyAgent [candidate] (796.399 ms) : 0, 796399
GlobalTracer [baseline] (255.529 ms) : 0, 255529
GlobalTracer [candidate] (257.069 ms) : 0, 257069
IAST [baseline] (26.878 ms) : 0, 26878
IAST [candidate] (27.202 ms) : 0, 27202
AppSec [baseline] (35.441 ms) : 0, 35441
AppSec [candidate] (35.588 ms) : 0, 35588
Debugger [baseline] (65.287 ms) : 0, 65287
Debugger [candidate] (66.172 ms) : 0, 66172
Remote Config [baseline] (541.83 µs) : 0, 542
Remote Config [candidate] (567.157 µs) : 0, 567
Telemetry [baseline] (8.391 ms) : 0, 8391
Telemetry [candidate] (8.642 ms) : 0, 8642
Flare Poller [baseline] (3.437 ms) : 0, 3437
Flare Poller [candidate] (3.599 ms) : 0, 3599
section profiling
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (705.822 ms) : 0, 705822
BytebuddyAgent [candidate] (704.453 ms) : 0, 704453
GlobalTracer [baseline] (221.702 ms) : 0, 221702
GlobalTracer [candidate] (221.051 ms) : 0, 221051
AppSec [baseline] (32.494 ms) : 0, 32494
AppSec [candidate] (32.359 ms) : 0, 32359
Debugger [baseline] (68.721 ms) : 0, 68721
Debugger [candidate] (67.913 ms) : 0, 67913
Remote Config [baseline] (624.401 µs) : 0, 624
Remote Config [candidate] (624.779 µs) : 0, 625
Telemetry [baseline] (9.009 ms) : 0, 9009
Telemetry [candidate] (8.993 ms) : 0, 8993
Flare Poller [baseline] (3.73 ms) : 0, 3730
Flare Poller [candidate] (3.796 ms) : 0, 3796
ProfilingAgent [baseline] (97.959 ms) : 0, 97959
ProfilingAgent [candidate] (97.943 ms) : 0, 97943
Profiling [baseline] (98.538 ms) : 0, 98538
Profiling [candidate] (98.53 ms) : 0, 98530
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section baseline
no_agent (19.188 ms) : 18997, 19380
. : milestone, 19188,
appsec (18.578 ms) : 18386, 18769
. : milestone, 18578,
code_origins (18.078 ms) : 17897, 18259
. : milestone, 18078,
iast (18.627 ms) : 18437, 18816
. : milestone, 18627,
profiling (18.789 ms) : 18602, 18976
. : milestone, 18789,
tracing (17.9 ms) : 17722, 18078
. : milestone, 17900,
section candidate
no_agent (18.353 ms) : 18160, 18546
. : milestone, 18353,
appsec (18.518 ms) : 18329, 18706
. : milestone, 18518,
code_origins (18.803 ms) : 18612, 18995
. : milestone, 18803,
iast (17.894 ms) : 17714, 18074
. : milestone, 17894,
profiling (18.663 ms) : 18474, 18852
. : milestone, 18663,
tracing (17.663 ms) : 17489, 17837
. : milestone, 17663,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1179, 1203
. : milestone, 1191,
iast (3.189 ms) : 3142, 3236
. : milestone, 3189,
iast_FULL (5.57 ms) : 5516, 5625
. : milestone, 5570,
iast_GLOBAL (3.602 ms) : 3545, 3660
. : milestone, 3602,
profiling (2.082 ms) : 2064, 2100
. : milestone, 2082,
tracing (1.893 ms) : 1873, 1912
. : milestone, 1893,
section candidate
no_agent (1.199 ms) : 1188, 1210
. : milestone, 1199,
iast (3.297 ms) : 3253, 3342
. : milestone, 3297,
iast_FULL (6.041 ms) : 5979, 6103
. : milestone, 6041,
iast_GLOBAL (3.673 ms) : 3620, 3727
. : milestone, 3673,
profiling (2.175 ms) : 2155, 2195
. : milestone, 2175,
tracing (1.816 ms) : 1800, 1832
. : milestone, 1816,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section baseline
no_agent (15.255 s) : 15255000, 15255000
. : milestone, 15255000,
appsec (14.842 s) : 14842000, 14842000
. : milestone, 14842000,
iast (18.097 s) : 18097000, 18097000
. : milestone, 18097000,
iast_GLOBAL (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
profiling (14.63 s) : 14630000, 14630000
. : milestone, 14630000,
tracing (14.623 s) : 14623000, 14623000
. : milestone, 14623000,
section candidate
no_agent (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
appsec (14.589 s) : 14589000, 14589000
. : milestone, 14589000,
iast (18.356 s) : 18356000, 18356000
. : milestone, 18356000,
iast_GLOBAL (17.874 s) : 17874000, 17874000
. : milestone, 17874000,
profiling (14.664 s) : 14664000, 14664000
. : milestone, 14664000,
tracing (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~7b19179cc7, baseline=1.57.0-SNAPSHOT~c7e1489fab
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.72 ms) : 3500, 3940
. : milestone, 3720,
iast (2.221 ms) : 2157, 2285
. : milestone, 2221,
iast_GLOBAL (2.265 ms) : 2200, 2329
. : milestone, 2265,
profiling (2.081 ms) : 2027, 2135
. : milestone, 2081,
tracing (2.043 ms) : 1993, 2094
. : milestone, 2043,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.459 ms) : 2407, 2510
. : milestone, 2459,
iast (2.218 ms) : 2154, 2283
. : milestone, 2218,
iast_GLOBAL (2.27 ms) : 2204, 2335
. : milestone, 2270,
profiling (2.073 ms) : 2021, 2125
. : milestone, 2073,
tracing (2.044 ms) : 1993, 2094
. : milestone, 2044,
|
What Does This Do
When compiling the metric expression using
@returnsynthetic variable, the type of@returnwas not propagated correctly and the generic Object type was used instead which prevent to call length() when thisis a String.
Fix also reporting errors as ProbeSatus by returning Error status when instrumenting.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4840