-
Notifications
You must be signed in to change notification settings - Fork 320
Don't send crash-ping to error tracking if not enabled #10170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougqh
approved these changes
Dec 11, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096399
Total [baseline] (10.897 s) : 0, 10896709
Agent [candidate] (1.083 s) : 0, 1082954
Total [candidate] (10.854 s) : 0, 10853544
section appsec
Agent [baseline] (1.267 s) : 0, 1267049
Total [baseline] (11.112 s) : 0, 11112301
Agent [candidate] (1.27 s) : 0, 1269751
Total [candidate] (11.141 s) : 0, 11141032
section iast
Agent [baseline] (1.225 s) : 0, 1225117
Total [baseline] (11.101 s) : 0, 11100607
Agent [candidate] (1.219 s) : 0, 1219461
Total [candidate] (11.168 s) : 0, 11167991
section profiling
Agent [baseline] (1.213 s) : 0, 1212828
Total [baseline] (11.03 s) : 0, 11030461
Agent [candidate] (1.208 s) : 0, 1207854
Total [candidate] (11.084 s) : 0, 11084308
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (658.305 ms) : 0, 658305
BytebuddyAgent [candidate] (649.519 ms) : 0, 649519
GlobalTracer [baseline] (285.947 ms) : 0, 285947
GlobalTracer [candidate] (282.354 ms) : 0, 282354
AppSec [baseline] (32.663 ms) : 0, 32663
AppSec [candidate] (32.474 ms) : 0, 32474
Debugger [baseline] (68.696 ms) : 0, 68696
Debugger [candidate] (68.434 ms) : 0, 68434
Remote Config [baseline] (639.262 µs) : 0, 639
Remote Config [candidate] (647.755 µs) : 0, 648
Telemetry [baseline] (9.252 ms) : 0, 9252
Telemetry [candidate] (9.026 ms) : 0, 9026
Flare Poller [baseline] (3.805 ms) : 0, 3805
Flare Poller [candidate] (3.79 ms) : 0, 3790
section appsec
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (690.521 ms) : 0, 690521
BytebuddyAgent [candidate] (693.176 ms) : 0, 693176
GlobalTracer [baseline] (259.652 ms) : 0, 259652
GlobalTracer [candidate] (260.108 ms) : 0, 260108
IAST [baseline] (24.811 ms) : 0, 24811
IAST [candidate] (24.697 ms) : 0, 24697
AppSec [baseline] (174.461 ms) : 0, 174461
AppSec [candidate] (174.114 ms) : 0, 174114
Debugger [baseline] (67.22 ms) : 0, 67220
Debugger [candidate] (67.186 ms) : 0, 67186
Remote Config [baseline] (726.509 µs) : 0, 727
Remote Config [candidate] (725.625 µs) : 0, 726
Telemetry [baseline] (8.912 ms) : 0, 8912
Telemetry [candidate] (9.051 ms) : 0, 9051
Flare Poller [baseline] (3.856 ms) : 0, 3856
Flare Poller [candidate] (3.953 ms) : 0, 3953
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (792.121 ms) : 0, 792121
BytebuddyAgent [candidate] (788.311 ms) : 0, 788311
GlobalTracer [baseline] (255.558 ms) : 0, 255558
GlobalTracer [candidate] (254.904 ms) : 0, 254904
IAST [baseline] (27.019 ms) : 0, 27019
IAST [candidate] (26.855 ms) : 0, 26855
AppSec [baseline] (33.667 ms) : 0, 33667
AppSec [candidate] (35.184 ms) : 0, 35184
Debugger [baseline] (67.623 ms) : 0, 67623
Debugger [candidate] (65.318 ms) : 0, 65318
Remote Config [baseline] (552.081 µs) : 0, 552
Remote Config [candidate] (535.716 µs) : 0, 536
Telemetry [baseline] (8.453 ms) : 0, 8453
Telemetry [candidate] (8.387 ms) : 0, 8387
Flare Poller [baseline] (3.464 ms) : 0, 3464
Flare Poller [candidate] (3.459 ms) : 0, 3459
section profiling
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (707.546 ms) : 0, 707546
BytebuddyAgent [candidate] (704.972 ms) : 0, 704972
GlobalTracer [baseline] (222.386 ms) : 0, 222386
GlobalTracer [candidate] (220.822 ms) : 0, 220822
AppSec [baseline] (32.596 ms) : 0, 32596
AppSec [candidate] (32.275 ms) : 0, 32275
Debugger [baseline] (68.055 ms) : 0, 68055
Debugger [candidate] (68.098 ms) : 0, 68098
Remote Config [baseline] (641.969 µs) : 0, 642
Remote Config [candidate] (656.951 µs) : 0, 657
Telemetry [baseline] (9.122 ms) : 0, 9122
Telemetry [candidate] (9.027 ms) : 0, 9027
Flare Poller [baseline] (3.767 ms) : 0, 3767
Flare Poller [candidate] (3.804 ms) : 0, 3804
ProfilingAgent [baseline] (97.42 ms) : 0, 97420
ProfilingAgent [candidate] (97.143 ms) : 0, 97143
Profiling [baseline] (98.013 ms) : 0, 98013
Profiling [candidate] (97.718 ms) : 0, 97718
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078781
Total [baseline] (8.752 s) : 0, 8751664
Agent [candidate] (1.095 s) : 0, 1095425
Total [candidate] (8.824 s) : 0, 8824488
section iast
Agent [baseline] (1.219 s) : 0, 1218667
Total [baseline] (9.433 s) : 0, 9433382
Agent [candidate] (1.229 s) : 0, 1229035
Total [candidate] (9.476 s) : 0, 9475765
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (647.819 ms) : 0, 647819
BytebuddyAgent [candidate] (658.063 ms) : 0, 658063
GlobalTracer [baseline] (281.127 ms) : 0, 281127
GlobalTracer [candidate] (285.494 ms) : 0, 285494
AppSec [baseline] (32.31 ms) : 0, 32310
AppSec [candidate] (32.902 ms) : 0, 32902
Debugger [baseline] (67.175 ms) : 0, 67175
Debugger [candidate] (68.162 ms) : 0, 68162
Remote Config [baseline] (657.384 µs) : 0, 657
Remote Config [candidate] (646.839 µs) : 0, 647
Telemetry [baseline] (9.052 ms) : 0, 9052
Telemetry [candidate] (9.119 ms) : 0, 9119
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.835 ms) : 0, 3835
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (788.691 ms) : 0, 788691
BytebuddyAgent [candidate] (795.416 ms) : 0, 795416
GlobalTracer [baseline] (254.933 ms) : 0, 254933
GlobalTracer [candidate] (256.791 ms) : 0, 256791
IAST [baseline] (26.917 ms) : 0, 26917
IAST [candidate] (27.146 ms) : 0, 27146
AppSec [baseline] (34.233 ms) : 0, 34233
AppSec [candidate] (35.419 ms) : 0, 35419
Debugger [baseline] (64.832 ms) : 0, 64832
Debugger [candidate] (64.868 ms) : 0, 64868
Remote Config [baseline] (611.543 µs) : 0, 612
Remote Config [candidate] (553.348 µs) : 0, 553
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.557 ms) : 0, 8557
Flare Poller [baseline] (3.447 ms) : 0, 3447
Flare Poller [candidate] (3.481 ms) : 0, 3481
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1185, 1208
. : milestone, 1196,
iast (3.315 ms) : 3276, 3354
. : milestone, 3315,
iast_FULL (5.824 ms) : 5766, 5883
. : milestone, 5824,
iast_GLOBAL (3.605 ms) : 3553, 3657
. : milestone, 3605,
profiling (2.073 ms) : 2055, 2092
. : milestone, 2073,
tracing (1.862 ms) : 1843, 1880
. : milestone, 1862,
section candidate
no_agent (1.221 ms) : 1209, 1233
. : milestone, 1221,
iast (3.118 ms) : 3078, 3158
. : milestone, 3118,
iast_FULL (5.785 ms) : 5727, 5843
. : milestone, 5785,
iast_GLOBAL (3.644 ms) : 3589, 3699
. : milestone, 3644,
profiling (2.036 ms) : 2018, 2054
. : milestone, 2036,
tracing (1.797 ms) : 1782, 1812
. : milestone, 1797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section baseline
no_agent (18.182 ms) : 17999, 18364
. : milestone, 18182,
appsec (18.805 ms) : 18611, 18998
. : milestone, 18805,
code_origins (17.489 ms) : 17315, 17663
. : milestone, 17489,
iast (17.435 ms) : 17261, 17608
. : milestone, 17435,
profiling (18.401 ms) : 18218, 18585
. : milestone, 18401,
tracing (17.691 ms) : 17516, 17865
. : milestone, 17691,
section candidate
no_agent (19.654 ms) : 19443, 19865
. : milestone, 19654,
appsec (18.626 ms) : 18440, 18813
. : milestone, 18626,
code_origins (17.912 ms) : 17733, 18091
. : milestone, 17912,
iast (17.532 ms) : 17357, 17707
. : milestone, 17532,
profiling (19.64 ms) : 19441, 19840
. : milestone, 19640,
tracing (17.419 ms) : 17247, 17591
. : milestone, 17419,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section baseline
no_agent (15.626 s) : 15626000, 15626000
. : milestone, 15626000,
appsec (14.671 s) : 14671000, 14671000
. : milestone, 14671000,
iast (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
iast_GLOBAL (18.009 s) : 18009000, 18009000
. : milestone, 18009000,
profiling (14.643 s) : 14643000, 14643000
. : milestone, 14643000,
tracing (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
section candidate
no_agent (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
appsec (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
iast (18.264 s) : 18264000, 18264000
. : milestone, 18264000,
iast_GLOBAL (17.973 s) : 17973000, 17973000
. : milestone, 17973000,
profiling (14.593 s) : 14593000, 14593000
. : milestone, 14593000,
tracing (14.571 s) : 14571000, 14571000
. : milestone, 14571000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f138af11c, baseline=1.57.0-SNAPSHOT~015be6d1b3
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (2.53 ms) : 2475, 2584
. : milestone, 2530,
iast (2.223 ms) : 2159, 2288
. : milestone, 2223,
iast_GLOBAL (2.27 ms) : 2205, 2335
. : milestone, 2270,
profiling (2.088 ms) : 2035, 2141
. : milestone, 2088,
tracing (2.058 ms) : 2007, 2109
. : milestone, 2058,
section candidate
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.684 ms) : 3469, 3899
. : milestone, 3684,
iast (2.223 ms) : 2158, 2287
. : milestone, 2223,
iast_GLOBAL (2.278 ms) : 2213, 2343
. : milestone, 2278,
profiling (2.086 ms) : 2032, 2140
. : milestone, 2086,
tracing (2.056 ms) : 2005, 2107
. : milestone, 2056,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Avoid sending the ping to error tracking intake when crashtracking bootstraps if that feature is not enabled
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]