-
Notifications
You must be signed in to change notification settings - Fork 320
Fix VerifyError when instrumenting org.apache.synapse.transport.passthru.SourceHandler
#10154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…must use Java8BytecodeBridge here
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084670
Total [baseline] (8.75 s) : 0, 8749946
Agent [candidate] (1.085 s) : 0, 1085467
Total [candidate] (8.789 s) : 0, 8789229
section iast
Agent [baseline] (1.218 s) : 0, 1218389
Total [baseline] (9.466 s) : 0, 9465514
Agent [candidate] (1.228 s) : 0, 1228489
Total [candidate] (9.489 s) : 0, 9489030
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (651.724 ms) : 0, 651724
BytebuddyAgent [candidate] (651.698 ms) : 0, 651698
GlobalTracer [baseline] (282.608 ms) : 0, 282608
GlobalTracer [candidate] (283.397 ms) : 0, 283397
AppSec [baseline] (32.575 ms) : 0, 32575
AppSec [candidate] (32.584 ms) : 0, 32584
Debugger [baseline] (67.532 ms) : 0, 67532
Debugger [candidate] (67.401 ms) : 0, 67401
Remote Config [baseline] (652.86 µs) : 0, 653
Remote Config [candidate] (667.809 µs) : 0, 668
Telemetry [baseline] (9.072 ms) : 0, 9072
Telemetry [candidate] (9.094 ms) : 0, 9094
Flare Poller [baseline] (3.755 ms) : 0, 3755
Flare Poller [candidate] (3.75 ms) : 0, 3750
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (788.095 ms) : 0, 788095
BytebuddyAgent [candidate] (793.903 ms) : 0, 793903
GlobalTracer [baseline] (255.259 ms) : 0, 255259
GlobalTracer [candidate] (257.283 ms) : 0, 257283
AppSec [baseline] (34.975 ms) : 0, 34975
AppSec [candidate] (35.815 ms) : 0, 35815
Debugger [baseline] (64.113 ms) : 0, 64113
Debugger [candidate] (65.065 ms) : 0, 65065
Remote Config [baseline] (528.076 µs) : 0, 528
Remote Config [candidate] (523.879 µs) : 0, 524
Telemetry [baseline] (8.353 ms) : 0, 8353
Telemetry [candidate] (8.432 ms) : 0, 8432
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.481 ms) : 0, 3481
IAST [baseline] (26.918 ms) : 0, 26918
IAST [candidate] (27.164 ms) : 0, 27164
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080737
Total [baseline] (10.866 s) : 0, 10865667
Agent [candidate] (1.086 s) : 0, 1086123
Total [candidate] (10.94 s) : 0, 10940003
section appsec
Agent [baseline] (1.272 s) : 0, 1271870
Total [baseline] (11.131 s) : 0, 11130738
Agent [candidate] (1.272 s) : 0, 1271689
Total [candidate] (11.243 s) : 0, 11242805
section iast
Agent [baseline] (1.224 s) : 0, 1224387
Total [baseline] (10.018 s) : 0, 10017637
Agent [candidate] (1.229 s) : 0, 1228823
Total [candidate] (11.253 s) : 0, 11253121
section profiling
Agent [baseline] (1.205 s) : 0, 1204607
Total [baseline] (10.943 s) : 0, 10942662
Agent [candidate] (1.212 s) : 0, 1211805
Total [candidate] (11.029 s) : 0, 11029243
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (648.641 ms) : 0, 648641
BytebuddyAgent [candidate] (651.174 ms) : 0, 651174
GlobalTracer [baseline] (281.705 ms) : 0, 281705
GlobalTracer [candidate] (283.564 ms) : 0, 283564
AppSec [baseline] (32.333 ms) : 0, 32333
AppSec [candidate] (32.376 ms) : 0, 32376
Debugger [baseline] (68.068 ms) : 0, 68068
Debugger [candidate] (68.56 ms) : 0, 68560
Remote Config [baseline] (615.914 µs) : 0, 616
Remote Config [candidate] (642.132 µs) : 0, 642
Telemetry [baseline] (8.996 ms) : 0, 8996
Telemetry [candidate] (9.154 ms) : 0, 9154
Flare Poller [baseline] (3.723 ms) : 0, 3723
Flare Poller [candidate] (3.795 ms) : 0, 3795
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (693.959 ms) : 0, 693959
BytebuddyAgent [candidate] (693.354 ms) : 0, 693354
GlobalTracer [baseline] (260.828 ms) : 0, 260828
GlobalTracer [candidate] (261.207 ms) : 0, 261207
AppSec [baseline] (175.419 ms) : 0, 175419
AppSec [candidate] (175.473 ms) : 0, 175473
Debugger [baseline] (66.603 ms) : 0, 66603
Debugger [candidate] (66.321 ms) : 0, 66321
Remote Config [baseline] (706.901 µs) : 0, 707
Remote Config [candidate] (743.188 µs) : 0, 743
Telemetry [baseline] (8.931 ms) : 0, 8931
Telemetry [candidate] (9.053 ms) : 0, 9053
Flare Poller [baseline] (3.887 ms) : 0, 3887
Flare Poller [candidate] (4.012 ms) : 0, 4012
IAST [baseline] (24.754 ms) : 0, 24754
IAST [candidate] (24.683 ms) : 0, 24683
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (790.791 ms) : 0, 790791
BytebuddyAgent [candidate] (793.535 ms) : 0, 793535
GlobalTracer [baseline] (256.017 ms) : 0, 256017
GlobalTracer [candidate] (257.404 ms) : 0, 257404
AppSec [baseline] (35.623 ms) : 0, 35623
AppSec [candidate] (34.494 ms) : 0, 34494
Debugger [baseline] (66.132 ms) : 0, 66132
Debugger [candidate] (66.867 ms) : 0, 66867
Remote Config [baseline] (536.623 µs) : 0, 537
Remote Config [candidate] (530.118 µs) : 0, 530
Telemetry [baseline] (8.373 ms) : 0, 8373
Telemetry [candidate] (8.529 ms) : 0, 8529
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.511 ms) : 0, 3511
IAST [baseline] (26.885 ms) : 0, 26885
IAST [candidate] (27.221 ms) : 0, 27221
section profiling
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (701.581 ms) : 0, 701581
BytebuddyAgent [candidate] (705.364 ms) : 0, 705364
GlobalTracer [baseline] (220.616 ms) : 0, 220616
GlobalTracer [candidate] (221.852 ms) : 0, 221852
AppSec [baseline] (32.358 ms) : 0, 32358
AppSec [candidate] (32.625 ms) : 0, 32625
Debugger [baseline] (68.25 ms) : 0, 68250
Debugger [candidate] (68.718 ms) : 0, 68718
Remote Config [baseline] (667.945 µs) : 0, 668
Remote Config [candidate] (620.515 µs) : 0, 621
Telemetry [baseline] (8.973 ms) : 0, 8973
Telemetry [candidate] (8.988 ms) : 0, 8988
Flare Poller [baseline] (3.808 ms) : 0, 3808
Flare Poller [candidate] (3.8 ms) : 0, 3800
ProfilingAgent [baseline] (97.644 ms) : 0, 97644
ProfilingAgent [candidate] (98.798 ms) : 0, 98798
Profiling [baseline] (98.222 ms) : 0, 98222
Profiling [candidate] (99.378 ms) : 0, 99378
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1190, 1213
. : milestone, 1202,
iast (3.227 ms) : 3187, 3268
. : milestone, 3227,
iast_FULL (5.82 ms) : 5762, 5878
. : milestone, 5820,
iast_GLOBAL (3.613 ms) : 3553, 3673
. : milestone, 3613,
profiling (2.06 ms) : 2043, 2078
. : milestone, 2060,
tracing (1.798 ms) : 1783, 1812
. : milestone, 1798,
section candidate
no_agent (1.199 ms) : 1188, 1211
. : milestone, 1199,
iast (3.161 ms) : 3122, 3199
. : milestone, 3161,
iast_FULL (5.759 ms) : 5701, 5816
. : milestone, 5759,
iast_GLOBAL (3.605 ms) : 3546, 3664
. : milestone, 3605,
profiling (2.216 ms) : 2194, 2239
. : milestone, 2216,
tracing (1.861 ms) : 1844, 1877
. : milestone, 1861,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section baseline
no_agent (17.413 ms) : 17240, 17586
. : milestone, 17413,
appsec (18.841 ms) : 18648, 19033
. : milestone, 18841,
code_origins (17.964 ms) : 17785, 18144
. : milestone, 17964,
iast (17.987 ms) : 17803, 18170
. : milestone, 17987,
profiling (19.836 ms) : 19633, 20040
. : milestone, 19836,
tracing (17.588 ms) : 17415, 17760
. : milestone, 17588,
section candidate
no_agent (19.205 ms) : 19006, 19404
. : milestone, 19205,
appsec (18.9 ms) : 18706, 19093
. : milestone, 18900,
code_origins (17.948 ms) : 17771, 18124
. : milestone, 17948,
iast (17.921 ms) : 17739, 18103
. : milestone, 17921,
profiling (18.809 ms) : 18622, 18995
. : milestone, 18809,
tracing (17.791 ms) : 17615, 17967
. : milestone, 17791,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.715 ms) : 3495, 3936
. : milestone, 3715,
iast (2.243 ms) : 2177, 2309
. : milestone, 2243,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.071 ms) : 2018, 2123
. : milestone, 2071,
tracing (2.06 ms) : 2008, 2111
. : milestone, 2060,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.471 ms) : 2419, 2523
. : milestone, 2471,
iast (2.218 ms) : 2153, 2282
. : milestone, 2218,
iast_GLOBAL (2.263 ms) : 2198, 2328
. : milestone, 2263,
profiling (2.51 ms) : 2347, 2674
. : milestone, 2510,
tracing (2.057 ms) : 2006, 2108
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~27d7c10783, baseline=1.57.0-SNAPSHOT~a86bb9d9e2
dateFormat X
axisFormat %s
section baseline
no_agent (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
appsec (14.47 s) : 14470000, 14470000
. : milestone, 14470000,
iast (18.151 s) : 18151000, 18151000
. : milestone, 18151000,
iast_GLOBAL (18.051 s) : 18051000, 18051000
. : milestone, 18051000,
profiling (14.541 s) : 14541000, 14541000
. : milestone, 14541000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
section candidate
no_agent (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
appsec (14.379 s) : 14379000, 14379000
. : milestone, 14379000,
iast (18.489 s) : 18489000, 18489000
. : milestone, 18489000,
iast_GLOBAL (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
profiling (15.251 s) : 15251000, 15251000
. : milestone, 15251000,
tracing (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
What Does This Do
Synapse's bytecode level does not support static interface calls, so must use
Java8BytecodeBridgehere.Motivation
SynapseV0ForkedTestandSynapseV1ForkedTestwere failing with:The
invokestaticopcode is a hint that it was trying to call a static method on an interface, which is not supported at this older bytecode level.Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]