-
Notifications
You must be signed in to change notification settings - Fork 320
Rum injection: filter setContentType headers #10150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
f2d2849 to
c742e6f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087616
Total [baseline] (10.825 s) : 0, 10825425
Agent [candidate] (1.088 s) : 0, 1087932
Total [candidate] (10.826 s) : 0, 10825919
section appsec
Agent [baseline] (1.264 s) : 0, 1263755
Total [baseline] (11.095 s) : 0, 11094922
Agent [candidate] (1.265 s) : 0, 1264931
Total [candidate] (11.054 s) : 0, 11053971
section iast
Agent [baseline] (1.224 s) : 0, 1223750
Total [baseline] (11.084 s) : 0, 11083645
Agent [candidate] (1.229 s) : 0, 1228839
Total [candidate] (11.128 s) : 0, 11127630
section profiling
Agent [baseline] (1.202 s) : 0, 1201946
Total [baseline] (11.022 s) : 0, 11021642
Agent [candidate] (1.215 s) : 0, 1215144
Total [candidate] (11.047 s) : 0, 11046640
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (653.315 ms) : 0, 653315
BytebuddyAgent [candidate] (654.628 ms) : 0, 654628
GlobalTracer [baseline] (283.242 ms) : 0, 283242
GlobalTracer [candidate] (282.012 ms) : 0, 282012
AppSec [baseline] (32.52 ms) : 0, 32520
AppSec [candidate] (32.528 ms) : 0, 32528
Debugger [baseline] (68.301 ms) : 0, 68301
Debugger [candidate] (68.473 ms) : 0, 68473
Remote Config [baseline] (645.216 µs) : 0, 645
Remote Config [candidate] (637.59 µs) : 0, 638
Telemetry [baseline] (8.994 ms) : 0, 8994
Telemetry [candidate] (9.074 ms) : 0, 9074
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.738 ms) : 0, 3738
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (689.119 ms) : 0, 689119
BytebuddyAgent [candidate] (689.284 ms) : 0, 689284
GlobalTracer [baseline] (259.09 ms) : 0, 259090
GlobalTracer [candidate] (259.215 ms) : 0, 259215
AppSec [baseline] (174.242 ms) : 0, 174242
AppSec [candidate] (173.898 ms) : 0, 173898
Debugger [baseline] (66.321 ms) : 0, 66321
Debugger [candidate] (67.573 ms) : 0, 67573
Remote Config [baseline] (712.86 µs) : 0, 713
Remote Config [candidate] (745.543 µs) : 0, 746
Telemetry [baseline] (8.997 ms) : 0, 8997
Telemetry [candidate] (9.058 ms) : 0, 9058
Flare Poller [baseline] (3.924 ms) : 0, 3924
Flare Poller [candidate] (4.012 ms) : 0, 4012
IAST [baseline] (24.597 ms) : 0, 24597
IAST [candidate] (24.568 ms) : 0, 24568
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (790.985 ms) : 0, 790985
BytebuddyAgent [candidate] (795.647 ms) : 0, 795647
GlobalTracer [baseline] (255.832 ms) : 0, 255832
GlobalTracer [candidate] (256.177 ms) : 0, 256177
AppSec [baseline] (35.493 ms) : 0, 35493
AppSec [candidate] (35.366 ms) : 0, 35366
Debugger [baseline] (65.415 ms) : 0, 65415
Debugger [candidate] (65.54 ms) : 0, 65540
Remote Config [baseline] (545.652 µs) : 0, 546
Remote Config [candidate] (542.486 µs) : 0, 542
Telemetry [baseline] (8.435 ms) : 0, 8435
Telemetry [candidate] (8.429 ms) : 0, 8429
Flare Poller [baseline] (3.469 ms) : 0, 3469
Flare Poller [candidate] (3.498 ms) : 0, 3498
IAST [baseline] (26.991 ms) : 0, 26991
IAST [candidate] (26.928 ms) : 0, 26928
section profiling
ProfilingAgent [baseline] (97.419 ms) : 0, 97419
ProfilingAgent [candidate] (99.039 ms) : 0, 99039
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (699.896 ms) : 0, 699896
BytebuddyAgent [candidate] (707.65 ms) : 0, 707650
GlobalTracer [baseline] (220.246 ms) : 0, 220246
GlobalTracer [candidate] (222.3 ms) : 0, 222300
AppSec [baseline] (32.327 ms) : 0, 32327
AppSec [candidate] (32.617 ms) : 0, 32617
Debugger [baseline] (67.923 ms) : 0, 67923
Debugger [candidate] (68.745 ms) : 0, 68745
Remote Config [baseline] (636.434 µs) : 0, 636
Remote Config [candidate] (641.379 µs) : 0, 641
Telemetry [baseline] (9.003 ms) : 0, 9003
Telemetry [candidate] (9.072 ms) : 0, 9072
Flare Poller [baseline] (3.73 ms) : 0, 3730
Flare Poller [candidate] (3.783 ms) : 0, 3783
Profiling [baseline] (98.002 ms) : 0, 98002
Profiling [candidate] (99.626 ms) : 0, 99626
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088273
Total [baseline] (8.778 s) : 0, 8777950
Agent [candidate] (1.08 s) : 0, 1080438
Total [candidate] (8.777 s) : 0, 8776708
section iast
Agent [baseline] (1.229 s) : 0, 1228611
Total [baseline] (9.45 s) : 0, 9449794
Agent [candidate] (1.223 s) : 0, 1222591
Total [candidate] (9.431 s) : 0, 9430703
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (652.887 ms) : 0, 652887
BytebuddyAgent [candidate] (649.176 ms) : 0, 649176
GlobalTracer [baseline] (283.973 ms) : 0, 283973
GlobalTracer [candidate] (281.911 ms) : 0, 281911
AppSec [baseline] (32.7 ms) : 0, 32700
AppSec [candidate] (32.261 ms) : 0, 32261
Debugger [baseline] (68.173 ms) : 0, 68173
Debugger [candidate] (66.998 ms) : 0, 66998
Remote Config [baseline] (665.123 µs) : 0, 665
Remote Config [candidate] (652.388 µs) : 0, 652
Telemetry [baseline] (9.104 ms) : 0, 9104
Telemetry [candidate] (8.963 ms) : 0, 8963
Flare Poller [baseline] (3.861 ms) : 0, 3861
Flare Poller [candidate] (3.763 ms) : 0, 3763
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (795.256 ms) : 0, 795256
BytebuddyAgent [candidate] (791.281 ms) : 0, 791281
GlobalTracer [baseline] (256.485 ms) : 0, 256485
GlobalTracer [candidate] (255.743 ms) : 0, 255743
IAST [baseline] (27.193 ms) : 0, 27193
IAST [candidate] (26.782 ms) : 0, 26782
AppSec [baseline] (35.329 ms) : 0, 35329
AppSec [candidate] (35.452 ms) : 0, 35452
Debugger [baseline] (65.06 ms) : 0, 65060
Debugger [candidate] (64.41 ms) : 0, 64410
Remote Config [baseline] (551.815 µs) : 0, 552
Remote Config [candidate] (555.12 µs) : 0, 555
Telemetry [baseline] (8.456 ms) : 0, 8456
Telemetry [candidate] (8.373 ms) : 0, 8373
Flare Poller [baseline] (3.507 ms) : 0, 3507
Flare Poller [candidate] (3.438 ms) : 0, 3438
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section baseline
no_agent (1.213 ms) : 1200, 1225
. : milestone, 1213,
iast (3.222 ms) : 3177, 3268
. : milestone, 3222,
iast_FULL (5.686 ms) : 5630, 5742
. : milestone, 5686,
iast_GLOBAL (3.539 ms) : 3483, 3595
. : milestone, 3539,
profiling (1.96 ms) : 1943, 1976
. : milestone, 1960,
tracing (1.858 ms) : 1841, 1875
. : milestone, 1858,
section candidate
no_agent (1.214 ms) : 1201, 1226
. : milestone, 1214,
iast (3.167 ms) : 3129, 3205
. : milestone, 3167,
iast_FULL (5.65 ms) : 5595, 5706
. : milestone, 5650,
iast_GLOBAL (3.566 ms) : 3513, 3619
. : milestone, 3566,
profiling (1.999 ms) : 1981, 2016
. : milestone, 1999,
tracing (1.769 ms) : 1754, 1784
. : milestone, 1769,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section baseline
no_agent (18.064 ms) : 17878, 18251
. : milestone, 18064,
appsec (18.424 ms) : 18238, 18611
. : milestone, 18424,
code_origins (17.853 ms) : 17676, 18029
. : milestone, 17853,
iast (17.581 ms) : 17404, 17758
. : milestone, 17581,
profiling (18.755 ms) : 18567, 18942
. : milestone, 18755,
tracing (17.412 ms) : 17240, 17584
. : milestone, 17412,
section candidate
no_agent (18.433 ms) : 18241, 18625
. : milestone, 18433,
appsec (18.703 ms) : 18510, 18896
. : milestone, 18703,
code_origins (17.925 ms) : 17745, 18105
. : milestone, 17925,
iast (17.39 ms) : 17217, 17563
. : milestone, 17390,
profiling (19.027 ms) : 18833, 19221
. : milestone, 19027,
tracing (17.487 ms) : 17319, 17655
. : milestone, 17487,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.48 ms) : 2428, 2531
. : milestone, 2480,
iast (2.217 ms) : 2152, 2281
. : milestone, 2217,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.074 ms) : 2022, 2126
. : milestone, 2074,
tracing (2.062 ms) : 2011, 2113
. : milestone, 2062,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.662 ms) : 3448, 3875
. : milestone, 3662,
iast (2.223 ms) : 2158, 2287
. : milestone, 2223,
iast_GLOBAL (2.268 ms) : 2203, 2332
. : milestone, 2268,
profiling (2.095 ms) : 2041, 2149
. : milestone, 2095,
tracing (2.052 ms) : 2002, 2103
. : milestone, 2052,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ced2208434, baseline=1.57.0-SNAPSHOT~2b04c87b81
dateFormat X
axisFormat %s
section baseline
no_agent (15.542 s) : 15542000, 15542000
. : milestone, 15542000,
appsec (14.753 s) : 14753000, 14753000
. : milestone, 14753000,
iast (18.211 s) : 18211000, 18211000
. : milestone, 18211000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
. : milestone, 17770000,
profiling (14.574 s) : 14574000, 14574000
. : milestone, 14574000,
tracing (14.76 s) : 14760000, 14760000
. : milestone, 14760000,
section candidate
no_agent (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
appsec (14.441 s) : 14441000, 14441000
. : milestone, 14441000,
iast (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
iast_GLOBAL (18.14 s) : 18140000, 18140000
. : milestone, 18140000,
profiling (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
tracing (14.564 s) : 14564000, 14564000
. : milestone, 14564000,
|
What Does This Do
This PR ensures that the injector correctly detects the content type even when it’s set via
setHeaderoraddHeader, rather than through the standardsetContentTypemethod.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]