-
Notifications
You must be signed in to change notification settings - Fork 320
Ensure messages are not modified before span serialization #10116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06f37ec to
fa01e9c
Compare
smola
approved these changes
Dec 9, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081963
Total [baseline] (8.767 s) : 0, 8767241
Agent [candidate] (1.082 s) : 0, 1082225
Total [candidate] (8.762 s) : 0, 8761778
section iast
Agent [baseline] (1.221 s) : 0, 1220944
Total [baseline] (9.49 s) : 0, 9489942
Agent [candidate] (1.231 s) : 0, 1230666
Total [candidate] (9.484 s) : 0, 9484283
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (650.438 ms) : 0, 650438
BytebuddyAgent [candidate] (649.873 ms) : 0, 649873
GlobalTracer [baseline] (281.917 ms) : 0, 281917
GlobalTracer [candidate] (282.225 ms) : 0, 282225
AppSec [baseline] (32.322 ms) : 0, 32322
AppSec [candidate] (32.372 ms) : 0, 32372
Debugger [baseline] (67.035 ms) : 0, 67035
Debugger [candidate] (67.441 ms) : 0, 67441
Remote Config [baseline] (665.251 µs) : 0, 665
Remote Config [candidate] (645.037 µs) : 0, 645
Telemetry [baseline] (9.015 ms) : 0, 9015
Telemetry [candidate] (9.067 ms) : 0, 9067
Flare Poller [baseline] (3.699 ms) : 0, 3699
Flare Poller [candidate] (3.786 ms) : 0, 3786
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (789.776 ms) : 0, 789776
BytebuddyAgent [candidate] (796.801 ms) : 0, 796801
GlobalTracer [baseline] (255.416 ms) : 0, 255416
GlobalTracer [candidate] (257.527 ms) : 0, 257527
IAST [baseline] (26.987 ms) : 0, 26987
IAST [candidate] (27.099 ms) : 0, 27099
AppSec [baseline] (34.537 ms) : 0, 34537
AppSec [candidate] (35.434 ms) : 0, 35434
Debugger [baseline] (65.258 ms) : 0, 65258
Debugger [candidate] (64.531 ms) : 0, 64531
Remote Config [baseline] (549.816 µs) : 0, 550
Remote Config [candidate] (548.02 µs) : 0, 548
Telemetry [baseline] (8.388 ms) : 0, 8388
Telemetry [candidate] (8.434 ms) : 0, 8434
Flare Poller [baseline] (3.463 ms) : 0, 3463
Flare Poller [candidate] (3.478 ms) : 0, 3478
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088402
Total [baseline] (11.005 s) : 0, 11004920
Agent [candidate] (1.085 s) : 0, 1085286
Total [candidate] (10.934 s) : 0, 10934289
section appsec
Agent [baseline] (1.267 s) : 0, 1267243
Total [baseline] (11.237 s) : 0, 11236872
Agent [candidate] (1.262 s) : 0, 1261751
Total [candidate] (11.246 s) : 0, 11246213
section iast
Agent [baseline] (1.224 s) : 0, 1223960
Total [baseline] (11.147 s) : 0, 11147413
Agent [candidate] (1.225 s) : 0, 1224673
Total [candidate] (11.128 s) : 0, 11128143
section profiling
Agent [baseline] (1.213 s) : 0, 1212682
Total [baseline] (11.193 s) : 0, 11193487
Agent [candidate] (1.206 s) : 0, 1206166
Total [candidate] (11.0 s) : 0, 10999914
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (652.994 ms) : 0, 652994
BytebuddyAgent [candidate] (649.584 ms) : 0, 649584
GlobalTracer [baseline] (283.968 ms) : 0, 283968
GlobalTracer [candidate] (283.544 ms) : 0, 283544
AppSec [baseline] (32.779 ms) : 0, 32779
AppSec [candidate] (32.728 ms) : 0, 32728
Debugger [baseline] (68.272 ms) : 0, 68272
Debugger [candidate] (69.033 ms) : 0, 69033
Remote Config [baseline] (638.185 µs) : 0, 638
Remote Config [candidate] (648.076 µs) : 0, 648
Telemetry [baseline] (9.01 ms) : 0, 9010
Telemetry [candidate] (9.117 ms) : 0, 9117
Flare Poller [baseline] (3.762 ms) : 0, 3762
Flare Poller [candidate] (3.802 ms) : 0, 3802
section appsec
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (689.305 ms) : 0, 689305
BytebuddyAgent [candidate] (687.482 ms) : 0, 687482
GlobalTracer [baseline] (259.825 ms) : 0, 259825
GlobalTracer [candidate] (258.686 ms) : 0, 258686
AppSec [baseline] (175.479 ms) : 0, 175479
AppSec [candidate] (173.943 ms) : 0, 173943
Debugger [baseline] (67.544 ms) : 0, 67544
Debugger [candidate] (67.041 ms) : 0, 67041
Remote Config [baseline] (769.694 µs) : 0, 770
Remote Config [candidate] (706.471 µs) : 0, 706
Telemetry [baseline] (9.194 ms) : 0, 9194
Telemetry [candidate] (8.97 ms) : 0, 8970
Flare Poller [baseline] (3.934 ms) : 0, 3934
Flare Poller [candidate] (3.814 ms) : 0, 3814
IAST [baseline] (24.522 ms) : 0, 24522
IAST [candidate] (24.41 ms) : 0, 24410
section iast
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (791.326 ms) : 0, 791326
BytebuddyAgent [candidate] (792.475 ms) : 0, 792475
GlobalTracer [baseline] (255.748 ms) : 0, 255748
GlobalTracer [candidate] (255.703 ms) : 0, 255703
AppSec [baseline] (35.287 ms) : 0, 35287
AppSec [candidate] (35.147 ms) : 0, 35147
Debugger [baseline] (65.594 ms) : 0, 65594
Debugger [candidate] (65.293 ms) : 0, 65293
Remote Config [baseline] (580.241 µs) : 0, 580
Remote Config [candidate] (574.928 µs) : 0, 575
Telemetry [baseline] (8.455 ms) : 0, 8455
Telemetry [candidate] (8.374 ms) : 0, 8374
Flare Poller [baseline] (3.454 ms) : 0, 3454
Flare Poller [candidate] (3.459 ms) : 0, 3459
IAST [baseline] (26.907 ms) : 0, 26907
IAST [candidate] (27.035 ms) : 0, 27035
section profiling
ProfilingAgent [baseline] (98.48 ms) : 0, 98480
ProfilingAgent [candidate] (98.235 ms) : 0, 98235
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (706.055 ms) : 0, 706055
BytebuddyAgent [candidate] (702.568 ms) : 0, 702568
GlobalTracer [baseline] (222.088 ms) : 0, 222088
GlobalTracer [candidate] (220.773 ms) : 0, 220773
AppSec [baseline] (32.552 ms) : 0, 32552
AppSec [candidate] (32.054 ms) : 0, 32054
Debugger [baseline] (68.521 ms) : 0, 68521
Debugger [candidate] (68.386 ms) : 0, 68386
Remote Config [baseline] (645.135 µs) : 0, 645
Remote Config [candidate] (621.014 µs) : 0, 621
Telemetry [baseline] (9.145 ms) : 0, 9145
Telemetry [candidate] (8.882 ms) : 0, 8882
Flare Poller [baseline] (3.85 ms) : 0, 3850
Flare Poller [candidate] (3.785 ms) : 0, 3785
Profiling [baseline] (99.065 ms) : 0, 99065
Profiling [candidate] (98.805 ms) : 0, 98805
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section baseline
no_agent (18.116 ms) : 17934, 18298
. : milestone, 18116,
appsec (19.742 ms) : 19539, 19944
. : milestone, 19742,
code_origins (17.652 ms) : 17475, 17829
. : milestone, 17652,
iast (17.727 ms) : 17553, 17901
. : milestone, 17727,
profiling (18.761 ms) : 18574, 18947
. : milestone, 18761,
tracing (17.776 ms) : 17599, 17954
. : milestone, 17776,
section candidate
no_agent (17.045 ms) : 16877, 17214
. : milestone, 17045,
appsec (18.801 ms) : 18610, 18992
. : milestone, 18801,
code_origins (17.864 ms) : 17686, 18042
. : milestone, 17864,
iast (17.731 ms) : 17555, 17907
. : milestone, 17731,
profiling (18.74 ms) : 18553, 18927
. : milestone, 18740,
tracing (17.723 ms) : 17547, 17898
. : milestone, 17723,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section baseline
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.241 ms) : 3200, 3282
. : milestone, 3241,
iast_FULL (5.719 ms) : 5662, 5776
. : milestone, 5719,
iast_GLOBAL (3.772 ms) : 3713, 3831
. : milestone, 3772,
profiling (2.152 ms) : 2131, 2174
. : milestone, 2152,
tracing (1.797 ms) : 1782, 1813
. : milestone, 1797,
section candidate
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.288 ms) : 3250, 3327
. : milestone, 3288,
iast_FULL (5.867 ms) : 5809, 5926
. : milestone, 5867,
iast_GLOBAL (3.71 ms) : 3655, 3765
. : milestone, 3710,
profiling (2.122 ms) : 2103, 2141
. : milestone, 2122,
tracing (1.819 ms) : 1804, 1834
. : milestone, 1819,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section baseline
no_agent (15.599 s) : 15599000, 15599000
. : milestone, 15599000,
appsec (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
iast (18.307 s) : 18307000, 18307000
. : milestone, 18307000,
iast_GLOBAL (18.063 s) : 18063000, 18063000
. : milestone, 18063000,
profiling (14.615 s) : 14615000, 14615000
. : milestone, 14615000,
tracing (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
section candidate
no_agent (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
appsec (14.761 s) : 14761000, 14761000
. : milestone, 14761000,
iast (18.303 s) : 18303000, 18303000
. : milestone, 18303000,
iast_GLOBAL (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
profiling (14.324 s) : 14324000, 14324000
. : milestone, 14324000,
tracing (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b4abd1bb17, baseline=1.57.0-SNAPSHOT~ea129e7775
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.75 ms) : 3529, 3970
. : milestone, 3750,
iast (2.228 ms) : 2164, 2293
. : milestone, 2228,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.062 ms) : 2010, 2114
. : milestone, 2062,
tracing (2.055 ms) : 2004, 2106
. : milestone, 2055,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.69 ms) : 3473, 3908
. : milestone, 3690,
iast (2.217 ms) : 2153, 2282
. : milestone, 2217,
iast_GLOBAL (2.268 ms) : 2203, 2333
. : milestone, 2268,
profiling (2.101 ms) : 2047, 2155
. : milestone, 2101,
tracing (2.065 ms) : 2013, 2116
. : milestone, 2065,
|
jandro996
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
AIGuardmessages are copied before being added to the meta struct so later mutations (e.g., adding tool calls) do not affect the serialized payload.tagsfrom the AI Guard response into theEvaluationobject.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]