-
Notifications
You must be signed in to change notification settings - Fork 320
Ensure compatibility with jboss modules 2.2 #10111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1094665
Total [baseline] (10.89 s) : 0, 10890441
Agent [candidate] (1.083 s) : 0, 1082729
Total [candidate] (10.813 s) : 0, 10812824
section appsec
Agent [baseline] (1.27 s) : 0, 1269533
Total [baseline] (11.114 s) : 0, 11114375
Agent [candidate] (1.262 s) : 0, 1261682
Total [candidate] (11.144 s) : 0, 11143743
section iast
Agent [baseline] (1.224 s) : 0, 1223569
Total [baseline] (11.206 s) : 0, 11206052
Agent [candidate] (1.23 s) : 0, 1229778
Total [candidate] (11.121 s) : 0, 11121071
section profiling
Agent [baseline] (1.204 s) : 0, 1204238
Total [baseline] (11.047 s) : 0, 11046702
Agent [candidate] (1.213 s) : 0, 1212631
Total [candidate] (11.046 s) : 0, 11046437
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (656.893 ms) : 0, 656893
BytebuddyAgent [candidate] (650.165 ms) : 0, 650165
GlobalTracer [baseline] (285.33 ms) : 0, 285330
GlobalTracer [candidate] (282.459 ms) : 0, 282459
AppSec [baseline] (32.903 ms) : 0, 32903
AppSec [candidate] (32.224 ms) : 0, 32224
Debugger [baseline] (68.871 ms) : 0, 68871
Debugger [candidate] (67.766 ms) : 0, 67766
Remote Config [baseline] (646.375 µs) : 0, 646
Remote Config [candidate] (639.345 µs) : 0, 639
Telemetry [baseline] (9.156 ms) : 0, 9156
Telemetry [candidate] (8.96 ms) : 0, 8960
Flare Poller [baseline] (3.875 ms) : 0, 3875
Flare Poller [candidate] (3.8 ms) : 0, 3800
section appsec
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (692.703 ms) : 0, 692703
BytebuddyAgent [candidate] (687.342 ms) : 0, 687342
GlobalTracer [baseline] (260.581 ms) : 0, 260581
GlobalTracer [candidate] (258.764 ms) : 0, 258764
IAST [baseline] (24.871 ms) : 0, 24871
IAST [candidate] (24.484 ms) : 0, 24484
AppSec [baseline] (174.453 ms) : 0, 174453
AppSec [candidate] (174.413 ms) : 0, 174413
Debugger [baseline] (66.654 ms) : 0, 66654
Debugger [candidate] (66.269 ms) : 0, 66269
Remote Config [baseline] (719.969 µs) : 0, 720
Remote Config [candidate] (687.713 µs) : 0, 688
Telemetry [baseline] (8.994 ms) : 0, 8994
Telemetry [candidate] (9.119 ms) : 0, 9119
Flare Poller [baseline] (3.83 ms) : 0, 3830
Flare Poller [candidate] (3.938 ms) : 0, 3938
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (791.28 ms) : 0, 791280
BytebuddyAgent [candidate] (795.507 ms) : 0, 795507
GlobalTracer [baseline] (255.268 ms) : 0, 255268
GlobalTracer [candidate] (256.099 ms) : 0, 256099
IAST [baseline] (27.127 ms) : 0, 27127
IAST [candidate] (27.085 ms) : 0, 27085
AppSec [baseline] (35.255 ms) : 0, 35255
AppSec [candidate] (35.288 ms) : 0, 35288
Debugger [baseline] (65.589 ms) : 0, 65589
Debugger [candidate] (66.427 ms) : 0, 66427
Remote Config [baseline] (569.935 µs) : 0, 570
Remote Config [candidate] (612.896 µs) : 0, 613
Telemetry [baseline] (8.445 ms) : 0, 8445
Telemetry [candidate] (8.475 ms) : 0, 8475
Flare Poller [baseline] (3.452 ms) : 0, 3452
Flare Poller [candidate] (3.512 ms) : 0, 3512
section profiling
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (702.29 ms) : 0, 702290
BytebuddyAgent [candidate] (706.895 ms) : 0, 706895
GlobalTracer [baseline] (220.774 ms) : 0, 220774
GlobalTracer [candidate] (222.277 ms) : 0, 222277
AppSec [baseline] (32.22 ms) : 0, 32220
AppSec [candidate] (32.464 ms) : 0, 32464
Debugger [baseline] (67.896 ms) : 0, 67896
Debugger [candidate] (68.267 ms) : 0, 68267
Remote Config [baseline] (639.148 µs) : 0, 639
Remote Config [candidate] (659.833 µs) : 0, 660
Telemetry [baseline] (8.992 ms) : 0, 8992
Telemetry [candidate] (9.002 ms) : 0, 9002
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.731 ms) : 0, 3731
ProfilingAgent [baseline] (96.9 ms) : 0, 96900
ProfilingAgent [candidate] (98.091 ms) : 0, 98091
Profiling [baseline] (97.479 ms) : 0, 97479
Profiling [candidate] (98.68 ms) : 0, 98680
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086569
Total [baseline] (8.756 s) : 0, 8756281
Agent [candidate] (1.088 s) : 0, 1088454
Total [candidate] (8.753 s) : 0, 8753386
section iast
Agent [baseline] (1.22 s) : 0, 1219724
Total [baseline] (9.429 s) : 0, 9428710
Agent [candidate] (1.221 s) : 0, 1221167
Total [candidate] (9.444 s) : 0, 9443722
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (652.833 ms) : 0, 652833
BytebuddyAgent [candidate] (654.007 ms) : 0, 654007
GlobalTracer [baseline] (283.11 ms) : 0, 283110
GlobalTracer [candidate] (284.055 ms) : 0, 284055
AppSec [baseline] (32.573 ms) : 0, 32573
AppSec [candidate] (32.677 ms) : 0, 32677
Debugger [baseline] (67.727 ms) : 0, 67727
Debugger [candidate] (67.122 ms) : 0, 67122
Remote Config [baseline] (669.65 µs) : 0, 670
Remote Config [candidate] (696.138 µs) : 0, 696
Telemetry [baseline] (9.017 ms) : 0, 9017
Telemetry [candidate] (9.108 ms) : 0, 9108
Flare Poller [baseline] (3.763 ms) : 0, 3763
Flare Poller [candidate] (3.855 ms) : 0, 3855
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (789.169 ms) : 0, 789169
BytebuddyAgent [candidate] (790.393 ms) : 0, 790393
GlobalTracer [baseline] (254.725 ms) : 0, 254725
GlobalTracer [candidate] (254.957 ms) : 0, 254957
IAST [baseline] (26.842 ms) : 0, 26842
IAST [candidate] (26.963 ms) : 0, 26963
AppSec [baseline] (35.507 ms) : 0, 35507
AppSec [candidate] (35.189 ms) : 0, 35189
Debugger [baseline] (64.501 ms) : 0, 64501
Debugger [candidate] (64.713 ms) : 0, 64713
Remote Config [baseline] (565.093 µs) : 0, 565
Remote Config [candidate] (569.756 µs) : 0, 570
Telemetry [baseline] (8.372 ms) : 0, 8372
Telemetry [candidate] (8.398 ms) : 0, 8398
Flare Poller [baseline] (3.428 ms) : 0, 3428
Flare Poller [candidate] (3.436 ms) : 0, 3436
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1195, 1220
. : milestone, 1207,
iast (3.251 ms) : 3208, 3294
. : milestone, 3251,
iast_FULL (5.637 ms) : 5581, 5693
. : milestone, 5637,
iast_GLOBAL (3.516 ms) : 3468, 3564
. : milestone, 3516,
profiling (2.026 ms) : 2007, 2044
. : milestone, 2026,
tracing (1.911 ms) : 1894, 1928
. : milestone, 1911,
section candidate
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.391 ms) : 3342, 3440
. : milestone, 3391,
iast_FULL (6.208 ms) : 6144, 6271
. : milestone, 6208,
iast_GLOBAL (3.608 ms) : 3556, 3661
. : milestone, 3608,
profiling (2.037 ms) : 2020, 2055
. : milestone, 2037,
tracing (1.826 ms) : 1811, 1841
. : milestone, 1826,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (18.116 ms) : 17930, 18303
. : milestone, 18116,
appsec (18.518 ms) : 18331, 18705
. : milestone, 18518,
code_origins (20.114 ms) : 19915, 20312
. : milestone, 20114,
iast (17.623 ms) : 17449, 17797
. : milestone, 17623,
profiling (18.58 ms) : 18391, 18770
. : milestone, 18580,
tracing (17.808 ms) : 17633, 17983
. : milestone, 17808,
section candidate
no_agent (19.22 ms) : 19017, 19423
. : milestone, 19220,
appsec (18.759 ms) : 18570, 18949
. : milestone, 18759,
code_origins (17.788 ms) : 17611, 17965
. : milestone, 17788,
iast (17.689 ms) : 17511, 17868
. : milestone, 17689,
profiling (18.771 ms) : 18582, 18961
. : milestone, 18771,
tracing (17.789 ms) : 17608, 17969
. : milestone, 17789,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
appsec (14.336 s) : 14336000, 14336000
. : milestone, 14336000,
iast (18.315 s) : 18315000, 18315000
. : milestone, 18315000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
profiling (14.601 s) : 14601000, 14601000
. : milestone, 14601000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
section candidate
no_agent (15.623 s) : 15623000, 15623000
. : milestone, 15623000,
appsec (14.596 s) : 14596000, 14596000
. : milestone, 14596000,
iast (18.334 s) : 18334000, 18334000
. : milestone, 18334000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
. : milestone, 18032000,
profiling (14.619 s) : 14619000, 14619000
. : milestone, 14619000,
tracing (14.832 s) : 14832000, 14832000
. : milestone, 14832000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~af4449d82a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.71 ms) : 3492, 3928
. : milestone, 3710,
iast (2.211 ms) : 2146, 2275
. : milestone, 2211,
iast_GLOBAL (2.255 ms) : 2190, 2320
. : milestone, 2255,
profiling (2.097 ms) : 2043, 2150
. : milestone, 2097,
tracing (2.05 ms) : 1998, 2101
. : milestone, 2050,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.644 ms) : 3429, 3858
. : milestone, 3644,
iast (2.211 ms) : 2146, 2275
. : milestone, 2211,
iast_GLOBAL (2.255 ms) : 2190, 2320
. : milestone, 2255,
profiling (2.094 ms) : 2040, 2148
. : milestone, 2094,
tracing (2.041 ms) : 1991, 2092
. : milestone, 2041,
|
mcculls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra tests
What Does This Do
ModuleIdentifierwas removed in version 2.2 and replaced with plain string identifiers.This PR ensures we can extract the module name correctly in both scenarios. In this case, I avoided creating multiple modules solely for that and instead used a MethodHandle-based approach.
Additional tests have been added to make the behavior future-proof.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]