-
Notifications
You must be signed in to change notification settings - Fork 320
Make spring-webflux instrumentation compatible with 7.0.0 #10110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Dec 9, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089268
Total [baseline] (10.832 s) : 0, 10832009
Agent [candidate] (1.082 s) : 0, 1081581
Total [candidate] (10.843 s) : 0, 10843012
section appsec
Agent [baseline] (1.273 s) : 0, 1273454
Total [baseline] (11.079 s) : 0, 11079074
Agent [candidate] (1.267 s) : 0, 1266949
Total [candidate] (11.134 s) : 0, 11134495
section iast
Agent [baseline] (1.227 s) : 0, 1226623
Total [baseline] (11.16 s) : 0, 11159873
Agent [candidate] (1.224 s) : 0, 1224466
Total [candidate] (11.176 s) : 0, 11176376
section profiling
Agent [baseline] (1.205 s) : 0, 1205250
Total [baseline] (11.079 s) : 0, 11078837
Agent [candidate] (1.203 s) : 0, 1202777
Total [candidate] (11.038 s) : 0, 11038346
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (653.182 ms) : 0, 653182
BytebuddyAgent [candidate] (649.423 ms) : 0, 649423
GlobalTracer [baseline] (284.294 ms) : 0, 284294
GlobalTracer [candidate] (281.98 ms) : 0, 281980
AppSec [baseline] (32.741 ms) : 0, 32741
AppSec [candidate] (32.303 ms) : 0, 32303
Debugger [baseline] (68.715 ms) : 0, 68715
Debugger [candidate] (67.763 ms) : 0, 67763
Remote Config [baseline] (663.58 µs) : 0, 664
Remote Config [candidate] (640.106 µs) : 0, 640
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (8.952 ms) : 0, 8952
Flare Poller [baseline] (3.71 ms) : 0, 3710
Flare Poller [candidate] (3.788 ms) : 0, 3788
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (693.848 ms) : 0, 693848
BytebuddyAgent [candidate] (690.602 ms) : 0, 690602
GlobalTracer [baseline] (260.996 ms) : 0, 260996
GlobalTracer [candidate] (259.782 ms) : 0, 259782
IAST [baseline] (24.601 ms) : 0, 24601
IAST [candidate] (24.535 ms) : 0, 24535
AppSec [baseline] (176.177 ms) : 0, 176177
AppSec [candidate] (174.723 ms) : 0, 174723
Debugger [baseline] (67.064 ms) : 0, 67064
Debugger [candidate] (66.629 ms) : 0, 66629
Remote Config [baseline] (697.251 µs) : 0, 697
Remote Config [candidate] (716.688 µs) : 0, 717
Telemetry [baseline] (9.166 ms) : 0, 9166
Telemetry [candidate] (9.26 ms) : 0, 9260
Flare Poller [baseline] (4.003 ms) : 0, 4003
Flare Poller [candidate] (3.991 ms) : 0, 3991
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (792.355 ms) : 0, 792355
BytebuddyAgent [candidate] (791.37 ms) : 0, 791370
GlobalTracer [baseline] (255.993 ms) : 0, 255993
GlobalTracer [candidate] (255.406 ms) : 0, 255406
IAST [baseline] (27.203 ms) : 0, 27203
IAST [candidate] (26.964 ms) : 0, 26964
AppSec [baseline] (35.567 ms) : 0, 35567
AppSec [candidate] (35.474 ms) : 0, 35474
Debugger [baseline] (66.275 ms) : 0, 66275
Debugger [candidate] (66.142 ms) : 0, 66142
Remote Config [baseline] (574.236 µs) : 0, 574
Remote Config [candidate] (574.578 µs) : 0, 575
Telemetry [baseline] (8.475 ms) : 0, 8475
Telemetry [candidate] (8.442 ms) : 0, 8442
Flare Poller [baseline] (3.471 ms) : 0, 3471
Flare Poller [candidate] (3.493 ms) : 0, 3493
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (701.541 ms) : 0, 701541
BytebuddyAgent [candidate] (700.261 ms) : 0, 700261
GlobalTracer [baseline] (220.89 ms) : 0, 220890
GlobalTracer [candidate] (220.041 ms) : 0, 220041
AppSec [baseline] (32.348 ms) : 0, 32348
AppSec [candidate] (31.931 ms) : 0, 31931
Debugger [baseline] (68.287 ms) : 0, 68287
Debugger [candidate] (68.845 ms) : 0, 68845
Remote Config [baseline] (663.317 µs) : 0, 663
Remote Config [candidate] (633.131 µs) : 0, 633
Telemetry [baseline] (9.044 ms) : 0, 9044
Telemetry [candidate] (9.009 ms) : 0, 9009
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.758 ms) : 0, 3758
ProfilingAgent [baseline] (97.7 ms) : 0, 97700
ProfilingAgent [candidate] (97.56 ms) : 0, 97560
Profiling [baseline] (98.28 ms) : 0, 98280
Profiling [candidate] (98.161 ms) : 0, 98161
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083360
Total [baseline] (8.801 s) : 0, 8800523
Agent [candidate] (1.085 s) : 0, 1085337
Total [candidate] (8.753 s) : 0, 8752891
section iast
Agent [baseline] (1.221 s) : 0, 1221460
Total [baseline] (9.449 s) : 0, 9449217
Agent [candidate] (1.245 s) : 0, 1245084
Total [candidate] (9.572 s) : 0, 9571963
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (649.149 ms) : 0, 649149
BytebuddyAgent [candidate] (651.644 ms) : 0, 651644
GlobalTracer [baseline] (283.341 ms) : 0, 283341
GlobalTracer [candidate] (282.87 ms) : 0, 282870
AppSec [baseline] (32.647 ms) : 0, 32647
AppSec [candidate] (32.534 ms) : 0, 32534
Debugger [baseline] (67.828 ms) : 0, 67828
Debugger [candidate] (67.872 ms) : 0, 67872
Remote Config [baseline] (666.595 µs) : 0, 667
Remote Config [candidate] (647.253 µs) : 0, 647
Telemetry [baseline] (9.067 ms) : 0, 9067
Telemetry [candidate] (9.147 ms) : 0, 9147
Flare Poller [baseline] (3.857 ms) : 0, 3857
Flare Poller [candidate] (3.812 ms) : 0, 3812
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (789.754 ms) : 0, 789754
BytebuddyAgent [candidate] (806.95 ms) : 0, 806950
GlobalTracer [baseline] (255.328 ms) : 0, 255328
GlobalTracer [candidate] (260.133 ms) : 0, 260133
IAST [baseline] (26.966 ms) : 0, 26966
IAST [candidate] (27.547 ms) : 0, 27547
AppSec [baseline] (35.633 ms) : 0, 35633
AppSec [candidate] (35.558 ms) : 0, 35558
Debugger [baseline] (64.615 ms) : 0, 64615
Debugger [candidate] (65.302 ms) : 0, 65302
Remote Config [baseline] (577.302 µs) : 0, 577
Remote Config [candidate] (581.486 µs) : 0, 581
Telemetry [baseline] (8.436 ms) : 0, 8436
Telemetry [candidate] (8.452 ms) : 0, 8452
Flare Poller [baseline] (3.438 ms) : 0, 3438
Flare Poller [candidate] (3.479 ms) : 0, 3479
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1179, 1202
. : milestone, 1190,
iast (3.124 ms) : 3085, 3163
. : milestone, 3124,
iast_FULL (5.838 ms) : 5779, 5896
. : milestone, 5838,
iast_GLOBAL (3.582 ms) : 3526, 3637
. : milestone, 3582,
profiling (2.348 ms) : 2326, 2369
. : milestone, 2348,
tracing (1.781 ms) : 1767, 1796
. : milestone, 1781,
section candidate
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.215 ms) : 3172, 3259
. : milestone, 3215,
iast_FULL (5.733 ms) : 5677, 5790
. : milestone, 5733,
iast_GLOBAL (3.643 ms) : 3596, 3689
. : milestone, 3643,
profiling (2.011 ms) : 1993, 2028
. : milestone, 2011,
tracing (1.797 ms) : 1783, 1812
. : milestone, 1797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (17.972 ms) : 17786, 18159
. : milestone, 17972,
appsec (18.669 ms) : 18481, 18857
. : milestone, 18669,
code_origins (17.641 ms) : 17464, 17818
. : milestone, 17641,
iast (17.885 ms) : 17706, 18063
. : milestone, 17885,
profiling (19.084 ms) : 18896, 19272
. : milestone, 19084,
tracing (17.739 ms) : 17562, 17915
. : milestone, 17739,
section candidate
no_agent (18.26 ms) : 18074, 18446
. : milestone, 18260,
appsec (18.409 ms) : 18224, 18593
. : milestone, 18409,
code_origins (17.908 ms) : 17728, 18088
. : milestone, 17908,
iast (18.206 ms) : 18022, 18390
. : milestone, 18206,
profiling (19.684 ms) : 19484, 19884
. : milestone, 19684,
tracing (17.858 ms) : 17678, 18037
. : milestone, 17858,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.738 ms) : 3512, 3963
. : milestone, 3738,
iast (2.218 ms) : 2153, 2283
. : milestone, 2218,
iast_GLOBAL (2.254 ms) : 2189, 2320
. : milestone, 2254,
profiling (2.073 ms) : 2020, 2126
. : milestone, 2073,
tracing (2.053 ms) : 2001, 2104
. : milestone, 2053,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.678 ms) : 3460, 3896
. : milestone, 3678,
iast (2.221 ms) : 2156, 2287
. : milestone, 2221,
iast_GLOBAL (2.264 ms) : 2198, 2329
. : milestone, 2264,
profiling (2.069 ms) : 2016, 2121
. : milestone, 2069,
tracing (2.039 ms) : 1988, 2090
. : milestone, 2039,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~62be43dc8a, baseline=1.57.0-SNAPSHOT~aff04738f0
dateFormat X
axisFormat %s
section baseline
no_agent (15.742 s) : 15742000, 15742000
. : milestone, 15742000,
appsec (14.398 s) : 14398000, 14398000
. : milestone, 14398000,
iast (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
iast_GLOBAL (18.091 s) : 18091000, 18091000
. : milestone, 18091000,
profiling (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
tracing (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
section candidate
no_agent (15.592 s) : 15592000, 15592000
. : milestone, 15592000,
appsec (14.463 s) : 14463000, 14463000
. : milestone, 14463000,
iast (18.214 s) : 18214000, 18214000
. : milestone, 18214000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
. : milestone, 18048000,
profiling (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
tracing (14.692 s) : 14692000, 14692000
. : milestone, 14692000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Spring WebFlux 7 removed several deprecated methods from the ServerRequest interface. Because of this, the instrumentation in this PR now obtains the HTTP method name from the httpMethod object rather than calling the removed method directly, which previously caused muzzle to disable the instrumentation.
Note: this also means that tracer version 1.56.x did not support WebFlux 7. Fortunately, WebFlux 7 was only released in November.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]