Fix muzzle for AddingSpanAttributesInstrumentation by mcculls · Pull Request #10108 · DataDog/dd-trace-java

mcculls · 2025-12-09T01:30:44Z

What Does This Do

Fixes the following error:

./gradlew :dd-java-agent:instrumentation:opentelemetry:opentelemetry-annotations-1.26:muzzle

> Task :dd-java-agent:instrumentation:opentelemetry:opentelemetry-annotations-1.26:muzzle-AssertPass-io.opentelemetry.instrumentation-opentelemetry-instrumentation-annotations-1.33.6 FAILED
FAILED MUZZLE VALIDATION: datadog.trace.instrumentation.opentelemetry.annotations.AddingSpanAttributesInstrumentation mismatches:
-- datadog.trace.instrumentation.opentelemetry.annotations.WithSpanDecorator:90 Missing class datadog.opentelemetry.shim.trace.OtelConventions

Motivation

#9759 added OtelConventions helper classes to opentelemetry-annotations-1.20 but missed out opentelemetry-annotations-1.26 which also uses the same WithSpanDecorator

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-12-09T02:17:06Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/fix-otel-annotations-1.26-helpers
git_commit_date	1765234372	1765243611
git_commit_sha	`aff0473`	`4346007`
release_version	1.57.0-SNAPSHOT~aff04738f0	1.57.0-SNAPSHOT~4346007069

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765245598	1765245598
ci_job_id	1278007839	1278007839
ci_pipeline_id	85457385	85457385
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-rfbrpf1f 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-rfbrpf1f 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080761
Total [baseline] (8.801 s) : 0, 8801023
Agent [candidate] (1.084 s) : 0, 1084187
Total [candidate] (8.827 s) : 0, 8826701
section iast
Agent [baseline] (1.235 s) : 0, 1235073
Total [baseline] (9.515 s) : 0, 9514791
Agent [candidate] (1.241 s) : 0, 1241198
Total [candidate] (9.508 s) : 0, 9508465

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.235 s	154.312 ms (14.3%)
Total	tracing	8.801 s	-
Total	iast	9.515 s	713.767 ms (8.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.084 s	-
Agent	iast	1.241 s	157.011 ms (14.5%)
Total	tracing	8.827 s	-
Total	iast	9.508 s	681.763 ms (7.7%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (649.357 ms) : 0, 649357
BytebuddyAgent [candidate] (649.705 ms) : 0, 649705
GlobalTracer [baseline] (281.745 ms) : 0, 281745
GlobalTracer [candidate] (282.631 ms) : 0, 282631
AppSec [baseline] (32.546 ms) : 0, 32546
AppSec [candidate] (32.847 ms) : 0, 32847
Debugger [baseline] (67.041 ms) : 0, 67041
Debugger [candidate] (68.422 ms) : 0, 68422
Remote Config [baseline] (614.297 µs) : 0, 614
Remote Config [candidate] (652.541 µs) : 0, 653
Telemetry [baseline] (8.97 ms) : 0, 8970
Telemetry [candidate] (9.197 ms) : 0, 9197
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.896 ms) : 0, 3896
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (798.742 ms) : 0, 798742
BytebuddyAgent [candidate] (803.234 ms) : 0, 803234
GlobalTracer [baseline] (258.744 ms) : 0, 258744
GlobalTracer [candidate] (259.011 ms) : 0, 259011
IAST [baseline] (27.472 ms) : 0, 27472
IAST [candidate] (27.511 ms) : 0, 27511
AppSec [baseline] (35.901 ms) : 0, 35901
AppSec [candidate] (35.888 ms) : 0, 35888
Debugger [baseline] (64.892 ms) : 0, 64892
Debugger [candidate] (65.754 ms) : 0, 65754
Remote Config [baseline] (561.402 µs) : 0, 561
Remote Config [candidate] (594.395 µs) : 0, 594
Telemetry [baseline] (8.434 ms) : 0, 8434
Telemetry [candidate] (8.588 ms) : 0, 8588
Flare Poller [baseline] (3.441 ms) : 0, 3441
Flare Poller [candidate] (3.544 ms) : 0, 3544

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091181
Total [baseline] (10.86 s) : 0, 10859776
Agent [candidate] (1.084 s) : 0, 1083536
Total [candidate] (10.985 s) : 0, 10985197
section appsec
Agent [baseline] (1.265 s) : 0, 1265405
Total [baseline] (11.26 s) : 0, 11260043
Agent [candidate] (1.268 s) : 0, 1267960
Total [candidate] (11.123 s) : 0, 11122823
section iast
Agent [baseline] (1.225 s) : 0, 1224864
Total [baseline] (11.217 s) : 0, 11216513
Agent [candidate] (1.237 s) : 0, 1236664
Total [candidate] (11.262 s) : 0, 11262161
section profiling
Agent [baseline] (1.207 s) : 0, 1207062
Total [baseline] (11.114 s) : 0, 11113539
Agent [candidate] (1.207 s) : 0, 1207212
Total [candidate] (11.068 s) : 0, 11067625

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	appsec	1.265 s	174.224 ms (16.0%)
Agent	iast	1.225 s	133.683 ms (12.3%)
Agent	profiling	1.207 s	115.881 ms (10.6%)
Total	tracing	10.86 s	-
Total	appsec	11.26 s	400.268 ms (3.7%)
Total	iast	11.217 s	356.738 ms (3.3%)
Total	profiling	11.114 s	253.764 ms (2.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.084 s	-
Agent	appsec	1.268 s	184.424 ms (17.0%)
Agent	iast	1.237 s	153.128 ms (14.1%)
Agent	profiling	1.207 s	123.677 ms (11.4%)
Total	tracing	10.985 s	-
Total	appsec	11.123 s	137.626 ms (1.3%)
Total	iast	11.262 s	276.963 ms (2.5%)
Total	profiling	11.068 s	82.428 ms (0.8%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (654.588 ms) : 0, 654588
BytebuddyAgent [candidate] (649.86 ms) : 0, 649860
GlobalTracer [baseline] (284.395 ms) : 0, 284395
GlobalTracer [candidate] (282.788 ms) : 0, 282788
AppSec [baseline] (32.74 ms) : 0, 32740
AppSec [candidate] (32.57 ms) : 0, 32570
Debugger [baseline] (69.208 ms) : 0, 69208
Debugger [candidate] (68.117 ms) : 0, 68117
Remote Config [baseline] (628.57 µs) : 0, 629
Remote Config [candidate] (653.533 µs) : 0, 654
Telemetry [baseline] (9.028 ms) : 0, 9028
Telemetry [candidate] (9.034 ms) : 0, 9034
Flare Poller [baseline] (3.739 ms) : 0, 3739
Flare Poller [candidate] (3.748 ms) : 0, 3748
section appsec
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (689.908 ms) : 0, 689908
BytebuddyAgent [candidate] (691.677 ms) : 0, 691677
GlobalTracer [baseline] (260.026 ms) : 0, 260026
GlobalTracer [candidate] (260.022 ms) : 0, 260022
IAST [baseline] (24.58 ms) : 0, 24580
IAST [candidate] (24.552 ms) : 0, 24552
AppSec [baseline] (174.748 ms) : 0, 174748
AppSec [candidate] (174.008 ms) : 0, 174008
Debugger [baseline] (65.593 ms) : 0, 65593
Debugger [candidate] (67.009 ms) : 0, 67009
Remote Config [baseline] (706.699 µs) : 0, 707
Remote Config [candidate] (725.916 µs) : 0, 726
Telemetry [baseline] (9.071 ms) : 0, 9071
Telemetry [candidate] (9.159 ms) : 0, 9159
Flare Poller [baseline] (3.934 ms) : 0, 3934
Flare Poller [candidate] (3.966 ms) : 0, 3966
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (791.426 ms) : 0, 791426
BytebuddyAgent [candidate] (799.661 ms) : 0, 799661
GlobalTracer [baseline] (255.609 ms) : 0, 255609
GlobalTracer [candidate] (257.802 ms) : 0, 257802
IAST [baseline] (27.095 ms) : 0, 27095
IAST [candidate] (27.458 ms) : 0, 27458
AppSec [baseline] (35.852 ms) : 0, 35852
AppSec [candidate] (35.678 ms) : 0, 35678
Debugger [baseline] (65.694 ms) : 0, 65694
Debugger [candidate] (66.579 ms) : 0, 66579
Remote Config [baseline] (581.392 µs) : 0, 581
Remote Config [candidate] (603.71 µs) : 0, 604
Telemetry [baseline] (8.423 ms) : 0, 8423
Telemetry [candidate] (8.499 ms) : 0, 8499
Flare Poller [baseline] (3.468 ms) : 0, 3468
Flare Poller [candidate] (3.483 ms) : 0, 3483
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (702.606 ms) : 0, 702606
BytebuddyAgent [candidate] (703.6 ms) : 0, 703600
GlobalTracer [baseline] (221.073 ms) : 0, 221073
GlobalTracer [candidate] (221.0 ms) : 0, 221000
AppSec [baseline] (32.43 ms) : 0, 32430
AppSec [candidate] (32.222 ms) : 0, 32222
Debugger [baseline] (68.339 ms) : 0, 68339
Debugger [candidate] (68.22 ms) : 0, 68220
Remote Config [baseline] (670.78 µs) : 0, 671
Remote Config [candidate] (628.404 µs) : 0, 628
Telemetry [baseline] (9.154 ms) : 0, 9154
Telemetry [candidate] (8.99 ms) : 0, 8990
Flare Poller [baseline] (3.914 ms) : 0, 3914
Flare Poller [candidate] (3.798 ms) : 0, 3798
ProfilingAgent [baseline] (98.095 ms) : 0, 98095
ProfilingAgent [candidate] (97.872 ms) : 0, 97872
Profiling [baseline] (98.702 ms) : 0, 98702
Profiling [candidate] (98.442 ms) : 0, 98442

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/fix-otel-annotations-1.26-helpers
git_commit_date	1765234372	1765243611
git_commit_sha	`aff0473`	`4346007`
release_version	1.57.0-SNAPSHOT~aff04738f0	1.57.0-SNAPSHOT~4346007069

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765246068	1765246068
ci_job_id	1278007840	1278007840
ci_pipeline_id	85457385	85457385
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-ewtuhfz5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-ewtuhfz5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.119 ms) : 17932, 18306
.   : milestone, 18119,
appsec (18.506 ms) : 18320, 18692
.   : milestone, 18506,
code_origins (17.741 ms) : 17565, 17917
.   : milestone, 17741,
iast (17.755 ms) : 17576, 17935
.   : milestone, 17755,
profiling (18.749 ms) : 18566, 18932
.   : milestone, 18749,
tracing (17.548 ms) : 17373, 17724
.   : milestone, 17548,
section candidate
no_agent (18.339 ms) : 18147, 18531
.   : milestone, 18339,
appsec (18.594 ms) : 18405, 18783
.   : milestone, 18594,
code_origins (17.787 ms) : 17613, 17962
.   : milestone, 17787,
iast (17.678 ms) : 17503, 17853
.   : milestone, 17678,
profiling (18.648 ms) : 18462, 18834
.   : milestone, 18648,
tracing (17.785 ms) : 17608, 17963
.   : milestone, 17785,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.119 ms [17.932 ms, 18.306 ms]	-
appsec	18.506 ms [18.32 ms, 18.692 ms]	386.592 µs (2.1%)
code_origins	17.741 ms [17.565 ms, 17.917 ms]	-378.213 µs (-2.1%)
iast	17.755 ms [17.576 ms, 17.935 ms]	-364.06 µs (-2.0%)
profiling	18.749 ms [18.566 ms, 18.932 ms]	629.596 µs (3.5%)
tracing	17.548 ms [17.373 ms, 17.724 ms]	-570.833 µs (-3.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.339 ms [18.147 ms, 18.531 ms]	-
appsec	18.594 ms [18.405 ms, 18.783 ms]	255.091 µs (1.4%)
code_origins	17.787 ms [17.613 ms, 17.962 ms]	-551.677 µs (-3.0%)
iast	17.678 ms [17.503 ms, 17.853 ms]	-661.231 µs (-3.6%)
profiling	18.648 ms [18.462 ms, 18.834 ms]	309.197 µs (1.7%)
tracing	17.785 ms [17.608 ms, 17.963 ms]	-553.565 µs (-3.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1201
.   : milestone, 1189,
iast (3.126 ms) : 3085, 3167
.   : milestone, 3126,
iast_FULL (5.742 ms) : 5686, 5799
.   : milestone, 5742,
iast_GLOBAL (3.737 ms) : 3682, 3791
.   : milestone, 3737,
profiling (1.905 ms) : 1889, 1920
.   : milestone, 1905,
tracing (1.772 ms) : 1758, 1787
.   : milestone, 1772,
section candidate
no_agent (1.185 ms) : 1173, 1196
.   : milestone, 1185,
iast (3.195 ms) : 3157, 3234
.   : milestone, 3195,
iast_FULL (5.85 ms) : 5791, 5908
.   : milestone, 5850,
iast_GLOBAL (3.664 ms) : 3606, 3722
.   : milestone, 3664,
profiling (2.074 ms) : 2054, 2093
.   : milestone, 2074,
tracing (1.836 ms) : 1820, 1851
.   : milestone, 1836,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.189 ms [1.178 ms, 1.201 ms]	-
iast	3.126 ms [3.085 ms, 3.167 ms]	1.937 ms (162.9%)
iast_FULL	5.742 ms [5.686 ms, 5.799 ms]	4.553 ms (382.9%)
iast_GLOBAL	3.737 ms [3.682 ms, 3.791 ms]	2.547 ms (214.2%)
profiling	1.905 ms [1.889 ms, 1.92 ms]	715.363 µs (60.2%)
tracing	1.772 ms [1.758 ms, 1.787 ms]	583.312 µs (49.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.185 ms [1.173 ms, 1.196 ms]	-
iast	3.195 ms [3.157 ms, 3.234 ms]	2.01 ms (169.7%)
iast_FULL	5.85 ms [5.791 ms, 5.908 ms]	4.665 ms (393.7%)
iast_GLOBAL	3.664 ms [3.606 ms, 3.722 ms]	2.479 ms (209.2%)
profiling	2.074 ms [2.054 ms, 2.093 ms]	888.579 µs (75.0%)
tracing	1.836 ms [1.82 ms, 1.851 ms]	650.749 µs (54.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/fix-otel-annotations-1.26-helpers
git_commit_date	1765234372	1765243611
git_commit_sha	`aff0473`	`4346007`
release_version	1.57.0-SNAPSHOT~aff04738f0	1.57.0-SNAPSHOT~4346007069

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765245777	1765245777
ci_job_id	1278007841	1278007841
ci_pipeline_id	85457385	85457385
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-zbswn3v0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-zbswn3v0 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.709 ms) : 3489, 3930
.   : milestone, 3709,
iast (2.211 ms) : 2147, 2276
.   : milestone, 2211,
iast_GLOBAL (2.247 ms) : 2183, 2312
.   : milestone, 2247,
profiling (2.06 ms) : 2007, 2112
.   : milestone, 2060,
tracing (2.048 ms) : 1997, 2098
.   : milestone, 2048,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.735 ms) : 3515, 3954
.   : milestone, 3735,
iast (2.211 ms) : 2147, 2276
.   : milestone, 2211,
iast_GLOBAL (2.266 ms) : 2201, 2332
.   : milestone, 2266,
profiling (2.073 ms) : 2020, 2126
.   : milestone, 2073,
tracing (2.041 ms) : 1990, 2092
.   : milestone, 2041,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.709 ms [3.489 ms, 3.93 ms]	2.234 ms (151.4%)
iast	2.211 ms [2.147 ms, 2.276 ms]	735.444 µs (49.8%)
iast_GLOBAL	2.247 ms [2.183 ms, 2.312 ms]	771.636 µs (52.3%)
profiling	2.06 ms [2.007 ms, 2.112 ms]	583.841 µs (39.6%)
tracing	2.048 ms [1.997 ms, 2.098 ms]	571.841 µs (38.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	3.735 ms [3.515 ms, 3.954 ms]	2.255 ms (152.5%)
iast	2.211 ms [2.147 ms, 2.276 ms]	732.136 µs (49.5%)
iast_GLOBAL	2.266 ms [2.201 ms, 2.332 ms]	787.214 µs (53.2%)
profiling	2.073 ms [2.02 ms, 2.126 ms]	593.758 µs (40.1%)
tracing	2.041 ms [1.99 ms, 2.092 ms]	561.811 µs (38.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~4346007069, baseline=1.57.0-SNAPSHOT~aff04738f0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.323 s) : 15323000, 15323000
.   : milestone, 15323000,
appsec (14.684 s) : 14684000, 14684000
.   : milestone, 14684000,
iast (18.305 s) : 18305000, 18305000
.   : milestone, 18305000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
.   : milestone, 17883000,
profiling (14.647 s) : 14647000, 14647000
.   : milestone, 14647000,
tracing (14.841 s) : 14841000, 14841000
.   : milestone, 14841000,
section candidate
no_agent (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
appsec (14.488 s) : 14488000, 14488000
.   : milestone, 14488000,
iast (18.147 s) : 18147000, 18147000
.   : milestone, 18147000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
.   : milestone, 17928000,
profiling (14.544 s) : 14544000, 14544000
.   : milestone, 14544000,
tracing (14.615 s) : 14615000, 14615000
.   : milestone, 14615000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.323 s [15.323 s, 15.323 s]	-
appsec	14.684 s [14.684 s, 14.684 s]	-639.0 ms (-4.2%)
iast	18.305 s [18.305 s, 18.305 s]	2.982 s (19.5%)
iast_GLOBAL	17.883 s [17.883 s, 17.883 s]	2.56 s (16.7%)
profiling	14.647 s [14.647 s, 14.647 s]	-676.0 ms (-4.4%)
tracing	14.841 s [14.841 s, 14.841 s]	-482.0 ms (-3.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.955 s [14.955 s, 14.955 s]	-
appsec	14.488 s [14.488 s, 14.488 s]	-467.0 ms (-3.1%)
iast	18.147 s [18.147 s, 18.147 s]	3.192 s (21.3%)
iast_GLOBAL	17.928 s [17.928 s, 17.928 s]	2.973 s (19.9%)
profiling	14.544 s [14.544 s, 14.544 s]	-411.0 ms (-2.7%)
tracing	14.615 s [14.615 s, 14.615 s]	-340.0 ms (-2.3%)

WithSpanDecorator requires OtelConventions.toSpanKindTagValue

4346007

mcculls requested a review from a team as a code owner December 9, 2025 01:30

mcculls added type: bug Bug report and fix tag: no release notes Changes to exclude from release notes inst: opentelemetry OpenTelemetry instrumentation labels Dec 9, 2025

mcculls temporarily deployed to ci-build December 9, 2025 01:30 — with GitHub Actions Inactive

mcculls changed the title ~~WithSpanDecorator requires OtelConventions.toSpanKindTagValue~~ Fix muzzle for AddingSpanAttributesInstrumentation Dec 9, 2025

amarziali approved these changes Dec 9, 2025

View reviewed changes

mcculls merged commit 2229c62 into master Dec 9, 2025
550 of 552 checks passed

mcculls deleted the mcculls/fix-otel-annotations-1.26-helpers branch December 9, 2025 08:16

github-actions Bot added this to the 1.57.0 milestone Dec 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix muzzle for AddingSpanAttributesInstrumentation#10108

Fix muzzle for AddingSpanAttributesInstrumentation#10108
mcculls merged 1 commit intomasterfrom
mcculls/fix-otel-annotations-1.26-helpers

mcculls commented Dec 9, 2025 •

edited

Loading

Uh oh!

pr-commenter Bot commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mcculls commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Contributor Checklist

Uh oh!

pr-commenter Bot commented Dec 9, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcculls commented Dec 9, 2025 •

edited

Loading