-
Notifications
You must be signed in to change notification settings - Fork 320
Bump ddprof-java to 1.34.4 #10097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ddprof-java to 1.34.4 #10097
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076309
Total [baseline] (8.736 s) : 0, 8736490
Agent [candidate] (1.079 s) : 0, 1078762
Total [candidate] (8.755 s) : 0, 8754696
section iast
Agent [baseline] (1.229 s) : 0, 1229232
Total [baseline] (9.457 s) : 0, 9456818
Agent [candidate] (1.218 s) : 0, 1218352
Total [candidate] (9.477 s) : 0, 9477431
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (646.295 ms) : 0, 646295
BytebuddyAgent [candidate] (648.258 ms) : 0, 648258
GlobalTracer [baseline] (281.161 ms) : 0, 281161
GlobalTracer [candidate] (281.619 ms) : 0, 281619
AppSec [baseline] (32.16 ms) : 0, 32160
AppSec [candidate] (32.275 ms) : 0, 32275
Debugger [baseline] (66.687 ms) : 0, 66687
Debugger [candidate] (66.48 ms) : 0, 66480
Remote Config [baseline] (648.589 µs) : 0, 649
Remote Config [candidate] (646.024 µs) : 0, 646
Telemetry [baseline] (8.909 ms) : 0, 8909
Telemetry [candidate] (8.969 ms) : 0, 8969
Flare Poller [baseline] (3.631 ms) : 0, 3631
Flare Poller [candidate] (3.776 ms) : 0, 3776
section iast
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (794.952 ms) : 0, 794952
BytebuddyAgent [candidate] (786.911 ms) : 0, 786911
GlobalTracer [baseline] (256.926 ms) : 0, 256926
GlobalTracer [candidate] (255.095 ms) : 0, 255095
IAST [baseline] (27.204 ms) : 0, 27204
IAST [candidate] (26.826 ms) : 0, 26826
AppSec [baseline] (35.571 ms) : 0, 35571
AppSec [candidate] (35.327 ms) : 0, 35327
Debugger [baseline] (65.293 ms) : 0, 65293
Debugger [candidate] (65.064 ms) : 0, 65064
Remote Config [baseline] (552.594 µs) : 0, 553
Remote Config [candidate] (539.828 µs) : 0, 540
Telemetry [baseline] (8.496 ms) : 0, 8496
Telemetry [candidate] (8.5 ms) : 0, 8500
Flare Poller [baseline] (3.475 ms) : 0, 3475
Flare Poller [candidate] (3.492 ms) : 0, 3492
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078477
Total [baseline] (10.777 s) : 0, 10776637
Agent [candidate] (1.084 s) : 0, 1083503
Total [candidate] (10.786 s) : 0, 10785792
section appsec
Agent [baseline] (1.27 s) : 0, 1270339
Total [baseline] (11.167 s) : 0, 11166692
Agent [candidate] (1.271 s) : 0, 1270604
Total [candidate] (11.177 s) : 0, 11176579
section iast
Agent [baseline] (1.226 s) : 0, 1226465
Total [baseline] (11.192 s) : 0, 11191694
Agent [candidate] (1.223 s) : 0, 1222713
Total [candidate] (11.136 s) : 0, 11136127
section profiling
Agent [baseline] (1.203 s) : 0, 1203417
Total [baseline] (11.051 s) : 0, 11050534
Agent [candidate] (1.203 s) : 0, 1203093
Total [candidate] (11.024 s) : 0, 11024363
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (646.468 ms) : 0, 646468
BytebuddyAgent [candidate] (650.034 ms) : 0, 650034
GlobalTracer [baseline] (281.474 ms) : 0, 281474
GlobalTracer [candidate] (282.442 ms) : 0, 282442
AppSec [baseline] (32.308 ms) : 0, 32308
AppSec [candidate] (32.303 ms) : 0, 32303
Debugger [baseline] (68.162 ms) : 0, 68162
Debugger [candidate] (68.532 ms) : 0, 68532
Remote Config [baseline] (686.848 µs) : 0, 687
Remote Config [candidate] (639.521 µs) : 0, 640
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (9.072 ms) : 0, 9072
Flare Poller [baseline] (3.668 ms) : 0, 3668
Flare Poller [candidate] (3.721 ms) : 0, 3721
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (693.554 ms) : 0, 693554
BytebuddyAgent [candidate] (692.838 ms) : 0, 692838
GlobalTracer [baseline] (260.711 ms) : 0, 260711
GlobalTracer [candidate] (259.022 ms) : 0, 259022
IAST [baseline] (24.604 ms) : 0, 24604
IAST [candidate] (24.594 ms) : 0, 24594
AppSec [baseline] (173.987 ms) : 0, 173987
AppSec [candidate] (175.485 ms) : 0, 175485
Debugger [baseline] (67.2 ms) : 0, 67200
Debugger [candidate] (67.918 ms) : 0, 67918
Remote Config [baseline] (674.861 µs) : 0, 675
Remote Config [candidate] (733.801 µs) : 0, 734
Telemetry [baseline] (8.833 ms) : 0, 8833
Telemetry [candidate] (9.08 ms) : 0, 9080
Flare Poller [baseline] (3.806 ms) : 0, 3806
Flare Poller [candidate] (3.927 ms) : 0, 3927
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (791.604 ms) : 0, 791604
BytebuddyAgent [candidate] (789.698 ms) : 0, 789698
GlobalTracer [baseline] (257.22 ms) : 0, 257220
GlobalTracer [candidate] (255.36 ms) : 0, 255360
IAST [baseline] (27.2 ms) : 0, 27200
IAST [candidate] (27.02 ms) : 0, 27020
AppSec [baseline] (35.53 ms) : 0, 35530
AppSec [candidate] (35.288 ms) : 0, 35288
Debugger [baseline] (65.852 ms) : 0, 65852
Debugger [candidate] (66.15 ms) : 0, 66150
Remote Config [baseline] (540.162 µs) : 0, 540
Remote Config [candidate] (545.184 µs) : 0, 545
Telemetry [baseline] (8.439 ms) : 0, 8439
Telemetry [candidate] (8.481 ms) : 0, 8481
Flare Poller [baseline] (3.445 ms) : 0, 3445
Flare Poller [candidate] (3.478 ms) : 0, 3478
section profiling
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (700.319 ms) : 0, 700319
BytebuddyAgent [candidate] (700.164 ms) : 0, 700164
GlobalTracer [baseline] (220.35 ms) : 0, 220350
GlobalTracer [candidate] (221.194 ms) : 0, 221194
AppSec [baseline] (32.072 ms) : 0, 32072
AppSec [candidate] (32.065 ms) : 0, 32065
Debugger [baseline] (68.296 ms) : 0, 68296
Debugger [candidate] (67.871 ms) : 0, 67871
Remote Config [baseline] (633.821 µs) : 0, 634
Remote Config [candidate] (617.321 µs) : 0, 617
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (9.151 ms) : 0, 9151
Flare Poller [baseline] (3.739 ms) : 0, 3739
Flare Poller [candidate] (3.734 ms) : 0, 3734
ProfilingAgent [baseline] (98.309 ms) : 0, 98309
ProfilingAgent [candidate] (97.624 ms) : 0, 97624
Profiling [baseline] (98.883 ms) : 0, 98883
Profiling [candidate] (98.192 ms) : 0, 98192
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 14 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1177, 1200
. : milestone, 1188,
iast (3.169 ms) : 3130, 3208
. : milestone, 3169,
iast_FULL (5.758 ms) : 5701, 5816
. : milestone, 5758,
iast_GLOBAL (3.685 ms) : 3621, 3748
. : milestone, 3685,
profiling (2.134 ms) : 2112, 2156
. : milestone, 2134,
tracing (1.787 ms) : 1772, 1802
. : milestone, 1787,
section candidate
no_agent (1.241 ms) : 1229, 1254
. : milestone, 1241,
iast (3.367 ms) : 3317, 3418
. : milestone, 3367,
iast_FULL (5.839 ms) : 5782, 5897
. : milestone, 5839,
iast_GLOBAL (3.643 ms) : 3590, 3696
. : milestone, 3643,
profiling (2.019 ms) : 2000, 2037
. : milestone, 2019,
tracing (1.885 ms) : 1868, 1902
. : milestone, 1885,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (18.799 ms) : 18607, 18990
. : milestone, 18799,
appsec (18.496 ms) : 18310, 18683
. : milestone, 18496,
code_origins (17.84 ms) : 17664, 18015
. : milestone, 17840,
iast (17.52 ms) : 17347, 17693
. : milestone, 17520,
profiling (19.978 ms) : 19774, 20181
. : milestone, 19978,
tracing (17.861 ms) : 17685, 18038
. : milestone, 17861,
section candidate
no_agent (17.467 ms) : 17289, 17645
. : milestone, 17467,
appsec (18.557 ms) : 18366, 18748
. : milestone, 18557,
code_origins (17.703 ms) : 17527, 17879
. : milestone, 17703,
iast (17.635 ms) : 17462, 17807
. : milestone, 17635,
profiling (18.628 ms) : 18439, 18817
. : milestone, 18628,
tracing (17.638 ms) : 17464, 17811
. : milestone, 17638,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
iast (18.388 s) : 18388000, 18388000
. : milestone, 18388000,
iast_GLOBAL (18.156 s) : 18156000, 18156000
. : milestone, 18156000,
profiling (14.445 s) : 14445000, 14445000
. : milestone, 14445000,
tracing (14.823 s) : 14823000, 14823000
. : milestone, 14823000,
section candidate
no_agent (15.247 s) : 15247000, 15247000
. : milestone, 15247000,
appsec (14.672 s) : 14672000, 14672000
. : milestone, 14672000,
iast (18.637 s) : 18637000, 18637000
. : milestone, 18637000,
iast_GLOBAL (18.148 s) : 18148000, 18148000
. : milestone, 18148000,
profiling (14.687 s) : 14687000, 14687000
. : milestone, 14687000,
tracing (14.651 s) : 14651000, 14651000
. : milestone, 14651000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~2f7fcecd83, baseline=1.57.0-SNAPSHOT~3c70e67379
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (2.378 ms) : 2332, 2425
. : milestone, 2378,
iast (2.229 ms) : 2165, 2294
. : milestone, 2229,
iast_GLOBAL (2.272 ms) : 2207, 2337
. : milestone, 2272,
profiling (2.074 ms) : 2022, 2126
. : milestone, 2074,
tracing (2.056 ms) : 2005, 2106
. : milestone, 2056,
section candidate
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.728 ms) : 3510, 3946
. : milestone, 3728,
iast (2.225 ms) : 2161, 2289
. : milestone, 2225,
iast_GLOBAL (2.271 ms) : 2206, 2336
. : milestone, 2271,
profiling (2.104 ms) : 2049, 2158
. : milestone, 2104,
tracing (2.054 ms) : 2003, 2105
. : milestone, 2054,
|
What Does This Do
Updates the ddprof java dependency
Motivation
The 1.34.4 patch contains critical stability and performance fixes in the Java profiler library.
See DataDog/java-profiler@v_1.34.3...v_1.34.4 for the full list of critical fixes
Additional Notes
This is a must to merge before dd-trace-java 1.57.0 release
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue