-
Notifications
You must be signed in to change notification settings - Fork 320
Make Code Origin fingerprint map concurrent #10043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Origin probe creation can be called multiple threads/requests need to be thread safe. Adjust the code to be also atomic using this concurrent map to create only one probe
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (317.697 µs) : 292, 343
. : milestone, 318,
basic (288.697 µs) : 282, 295
. : milestone, 289,
loop (8.957 ms) : 8954, 8960
. : milestone, 8957,
section candidate
noprobe (324.626 µs) : 290, 359
. : milestone, 325,
basic (296.806 µs) : 290, 304
. : milestone, 297,
loop (8.959 ms) : 8955, 8962
. : milestone, 8959,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049672
Total [baseline] (8.698 s) : 0, 8697966
Agent [candidate] (1.057 s) : 0, 1056945
Total [candidate] (8.655 s) : 0, 8655348
section iast
Agent [baseline] (1.192 s) : 0, 1191804
Total [baseline] (9.308 s) : 0, 9308276
Agent [candidate] (1.193 s) : 0, 1192587
Total [candidate] (9.362 s) : 0, 9362141
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (706.159 ms) : 0, 706159
BytebuddyAgent [candidate] (710.974 ms) : 0, 710974
GlobalTracer [baseline] (248.019 ms) : 0, 248019
GlobalTracer [candidate] (250.029 ms) : 0, 250029
AppSec [baseline] (31.779 ms) : 0, 31779
AppSec [candidate] (32.226 ms) : 0, 32226
Debugger [baseline] (6.353 ms) : 0, 6353
Debugger [candidate] (6.412 ms) : 0, 6412
Remote Config [baseline] (668.598 µs) : 0, 669
Remote Config [candidate] (671.128 µs) : 0, 671
Telemetry [baseline] (15.593 ms) : 0, 15593
Telemetry [candidate] (15.976 ms) : 0, 15976
Flare Poller [baseline] (4.782 ms) : 0, 4782
Flare Poller [candidate] (4.109 ms) : 0, 4109
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (831.053 ms) : 0, 831053
BytebuddyAgent [candidate] (831.6 ms) : 0, 831600
GlobalTracer [baseline] (237.289 ms) : 0, 237289
GlobalTracer [candidate] (237.731 ms) : 0, 237731
IAST [baseline] (30.799 ms) : 0, 30799
IAST [candidate] (31.657 ms) : 0, 31657
AppSec [baseline] (30.89 ms) : 0, 30890
AppSec [candidate] (29.689 ms) : 0, 29689
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.057 ms) : 0, 6057
Remote Config [baseline] (620.737 µs) : 0, 621
Remote Config [candidate] (613.168 µs) : 0, 613
Telemetry [baseline] (7.952 ms) : 0, 7952
Telemetry [candidate] (7.967 ms) : 0, 7967
Flare Poller [baseline] (10.735 ms) : 0, 10735
Flare Poller [candidate] (10.88 ms) : 0, 10880
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053627
Total [baseline] (10.81 s) : 0, 10810344
Agent [candidate] (1.054 s) : 0, 1053979
Total [candidate] (10.862 s) : 0, 10862245
section appsec
Agent [baseline] (1.231 s) : 0, 1230769
Total [baseline] (10.831 s) : 0, 10831176
Agent [candidate] (1.237 s) : 0, 1236581
Total [candidate] (11.054 s) : 0, 11053981
section iast
Agent [baseline] (1.196 s) : 0, 1195592
Total [baseline] (11.126 s) : 0, 11126078
Agent [candidate] (1.192 s) : 0, 1191777
Total [candidate] (11.167 s) : 0, 11167374
section profiling
Agent [baseline] (1.207 s) : 0, 1207241
Total [baseline] (10.874 s) : 0, 10873594
Agent [candidate] (1.2 s) : 0, 1199720
Total [candidate] (10.958 s) : 0, 10958207
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.506 ms) : 0, 1506
BytebuddyAgent [baseline] (708.33 ms) : 0, 708330
BytebuddyAgent [candidate] (708.577 ms) : 0, 708577
GlobalTracer [baseline] (249.534 ms) : 0, 249534
GlobalTracer [candidate] (249.332 ms) : 0, 249332
AppSec [baseline] (32.01 ms) : 0, 32010
AppSec [candidate] (32.032 ms) : 0, 32032
Debugger [baseline] (6.377 ms) : 0, 6377
Debugger [candidate] (6.38 ms) : 0, 6380
Remote Config [baseline] (676.96 µs) : 0, 677
Remote Config [candidate] (673.54 µs) : 0, 674
Telemetry [baseline] (15.383 ms) : 0, 15383
Telemetry [candidate] (14.21 ms) : 0, 14210
Flare Poller [baseline] (5.033 ms) : 0, 5033
Flare Poller [candidate] (6.407 ms) : 0, 6407
section appsec
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (733.026 ms) : 0, 733026
BytebuddyAgent [candidate] (736.651 ms) : 0, 736651
GlobalTracer [baseline] (241.416 ms) : 0, 241416
GlobalTracer [candidate] (243.566 ms) : 0, 243566
AppSec [baseline] (175.866 ms) : 0, 175866
AppSec [candidate] (175.462 ms) : 0, 175462
Debugger [baseline] (6.289 ms) : 0, 6289
Debugger [candidate] (6.346 ms) : 0, 6346
Remote Config [baseline] (686.606 µs) : 0, 687
Remote Config [candidate] (708.431 µs) : 0, 708
Telemetry [baseline] (8.135 ms) : 0, 8135
Telemetry [candidate] (8.267 ms) : 0, 8267
Flare Poller [baseline] (3.971 ms) : 0, 3971
Flare Poller [candidate] (4.067 ms) : 0, 4067
IAST [baseline] (24.787 ms) : 0, 24787
IAST [candidate] (24.934 ms) : 0, 24934
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (832.231 ms) : 0, 832231
BytebuddyAgent [candidate] (830.715 ms) : 0, 830715
GlobalTracer [baseline] (238.997 ms) : 0, 238997
GlobalTracer [candidate] (237.825 ms) : 0, 237825
AppSec [baseline] (31.024 ms) : 0, 31024
AppSec [candidate] (29.076 ms) : 0, 29076
Debugger [baseline] (6.145 ms) : 0, 6145
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (625.633 µs) : 0, 626
Remote Config [candidate] (617.716 µs) : 0, 618
Telemetry [baseline] (8.015 ms) : 0, 8015
Telemetry [candidate] (7.924 ms) : 0, 7924
Flare Poller [baseline] (11.091 ms) : 0, 11091
Flare Poller [candidate] (10.661 ms) : 0, 10661
IAST [baseline] (31.052 ms) : 0, 31052
IAST [candidate] (32.563 ms) : 0, 32563
section profiling
ProfilingAgent [baseline] (110.723 ms) : 0, 110723
ProfilingAgent [candidate] (111.192 ms) : 0, 111192
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (740.194 ms) : 0, 740194
BytebuddyAgent [candidate] (734.4 ms) : 0, 734400
GlobalTracer [baseline] (224.843 ms) : 0, 224843
GlobalTracer [candidate] (223.468 ms) : 0, 223468
AppSec [baseline] (32.413 ms) : 0, 32413
AppSec [candidate] (32.152 ms) : 0, 32152
Debugger [baseline] (6.808 ms) : 0, 6808
Debugger [candidate] (7.558 ms) : 0, 7558
Remote Config [baseline] (717.334 µs) : 0, 717
Remote Config [candidate] (683.488 µs) : 0, 683
Telemetry [baseline] (16.219 ms) : 0, 16219
Telemetry [candidate] (15.427 ms) : 0, 15427
Flare Poller [baseline] (4.13 ms) : 0, 4130
Flare Poller [candidate] (4.194 ms) : 0, 4194
Profiling [baseline] (111.377 ms) : 0, 111377
Profiling [candidate] (111.832 ms) : 0, 111832
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 5 performance regressions! Performance is the same for 14 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section baseline
no_agent (1.224 ms) : 1213, 1236
. : milestone, 1224,
iast (3.215 ms) : 3173, 3257
. : milestone, 3215,
iast_FULL (5.839 ms) : 5781, 5898
. : milestone, 5839,
iast_GLOBAL (3.64 ms) : 3588, 3692
. : milestone, 3640,
profiling (1.974 ms) : 1958, 1991
. : milestone, 1974,
tracing (1.833 ms) : 1818, 1848
. : milestone, 1833,
section candidate
no_agent (1.223 ms) : 1211, 1234
. : milestone, 1223,
iast (3.177 ms) : 3136, 3218
. : milestone, 3177,
iast_FULL (5.637 ms) : 5581, 5692
. : milestone, 5637,
iast_GLOBAL (3.552 ms) : 3501, 3603
. : milestone, 3552,
profiling (1.955 ms) : 1939, 1972
. : milestone, 1955,
tracing (1.797 ms) : 1783, 1811
. : milestone, 1797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section baseline
no_agent (19.408 ms) : 19210, 19607
. : milestone, 19408,
appsec (19.638 ms) : 19437, 19839
. : milestone, 19638,
code_origins (17.567 ms) : 17391, 17743
. : milestone, 17567,
iast (17.63 ms) : 17452, 17807
. : milestone, 17630,
profiling (18.709 ms) : 18522, 18897
. : milestone, 18709,
tracing (17.758 ms) : 17583, 17933
. : milestone, 17758,
section candidate
no_agent (17.904 ms) : 17725, 18083
. : milestone, 17904,
appsec (18.573 ms) : 18383, 18763
. : milestone, 18573,
code_origins (18.677 ms) : 18487, 18866
. : milestone, 18677,
iast (17.727 ms) : 17552, 17901
. : milestone, 17727,
profiling (21.232 ms) : 21014, 21451
. : milestone, 21232,
tracing (18.783 ms) : 18594, 18973
. : milestone, 18783,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section baseline
no_agent (15.24 s) : 15240000, 15240000
. : milestone, 15240000,
appsec (14.751 s) : 14751000, 14751000
. : milestone, 14751000,
iast (18.854 s) : 18854000, 18854000
. : milestone, 18854000,
iast_GLOBAL (18.187 s) : 18187000, 18187000
. : milestone, 18187000,
profiling (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
tracing (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
section candidate
no_agent (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
appsec (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
iast (18.785 s) : 18785000, 18785000
. : milestone, 18785000,
iast_GLOBAL (17.893 s) : 17893000, 17893000
. : milestone, 17893000,
profiling (15.118 s) : 15118000, 15118000
. : milestone, 15118000,
tracing (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1eb7e8b892, baseline=1.57.0-SNAPSHOT~c69c2cd420
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.666 ms) : 3452, 3880
. : milestone, 3666,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.267 ms) : 2202, 2332
. : milestone, 2267,
profiling (2.106 ms) : 2052, 2160
. : milestone, 2106,
tracing (2.06 ms) : 2009, 2110
. : milestone, 2060,
section candidate
no_agent (1.485 ms) : 1473, 1497
. : milestone, 1485,
appsec (3.678 ms) : 3465, 3891
. : milestone, 3678,
iast (2.224 ms) : 2160, 2288
. : milestone, 2224,
iast_GLOBAL (2.271 ms) : 2206, 2335
. : milestone, 2271,
profiling (2.084 ms) : 2030, 2137
. : milestone, 2084,
tracing (2.061 ms) : 2010, 2112
. : milestone, 2061,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
What Does This Do
Code Origin probe creation can be called multiple threads/requests need to be thread safe.
Adjust the code to be also atomic using this concurrent map to create
only one probe
Motivation
Correctness
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4813