Properly fix the osgi smoke test bnd task setup#10039
Merged
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
AlexeyKuznetsov-DD
approved these changes
Nov 26, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052338
Total [baseline] (10.815 s) : 0, 10814510
Agent [candidate] (1.054 s) : 0, 1053633
Total [candidate] (10.81 s) : 0, 10810290
section appsec
Agent [baseline] (1.229 s) : 0, 1229318
Total [baseline] (10.896 s) : 0, 10896329
Agent [candidate] (1.228 s) : 0, 1227574
Total [candidate] (10.901 s) : 0, 10901456
section iast
Agent [baseline] (1.206 s) : 0, 1205729
Total [baseline] (11.166 s) : 0, 11166378
Agent [candidate] (1.201 s) : 0, 1201199
Total [candidate] (11.2 s) : 0, 11199839
section profiling
Agent [baseline] (1.216 s) : 0, 1215852
Total [baseline] (10.943 s) : 0, 10942962
Agent [candidate] (1.198 s) : 0, 1197546
Total [candidate] (10.879 s) : 0, 10878769
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (707.456 ms) : 0, 707456
BytebuddyAgent [candidate] (708.106 ms) : 0, 708106
GlobalTracer [baseline] (248.954 ms) : 0, 248954
GlobalTracer [candidate] (249.604 ms) : 0, 249604
AppSec [baseline] (32.022 ms) : 0, 32022
AppSec [candidate] (32.109 ms) : 0, 32109
Debugger [baseline] (6.432 ms) : 0, 6432
Debugger [candidate] (6.432 ms) : 0, 6432
Remote Config [baseline] (682.467 µs) : 0, 682
Remote Config [candidate] (674.525 µs) : 0, 675
Telemetry [baseline] (14.013 ms) : 0, 14013
Telemetry [candidate] (13.27 ms) : 0, 13270
Flare Poller [baseline] (6.524 ms) : 0, 6524
Flare Poller [candidate] (7.168 ms) : 0, 7168
section appsec
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (732.564 ms) : 0, 732564
BytebuddyAgent [candidate] (730.942 ms) : 0, 730942
GlobalTracer [baseline] (241.274 ms) : 0, 241274
GlobalTracer [candidate] (240.863 ms) : 0, 240863
AppSec [baseline] (175.178 ms) : 0, 175178
AppSec [candidate] (175.244 ms) : 0, 175244
Debugger [baseline] (6.242 ms) : 0, 6242
Debugger [candidate] (6.298 ms) : 0, 6298
Remote Config [baseline] (687.064 µs) : 0, 687
Remote Config [candidate] (686.029 µs) : 0, 686
Telemetry [baseline] (8.039 ms) : 0, 8039
Telemetry [candidate] (8.134 ms) : 0, 8134
Flare Poller [baseline] (4.049 ms) : 0, 4049
Flare Poller [candidate] (4.05 ms) : 0, 4050
IAST [baseline] (24.789 ms) : 0, 24789
IAST [candidate] (24.841 ms) : 0, 24841
section iast
crashtracking [baseline] (1.505 ms) : 0, 1505
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (841.415 ms) : 0, 841415
BytebuddyAgent [candidate] (837.972 ms) : 0, 837972
GlobalTracer [baseline] (239.559 ms) : 0, 239559
GlobalTracer [candidate] (238.858 ms) : 0, 238858
AppSec [baseline] (31.037 ms) : 0, 31037
AppSec [candidate] (30.902 ms) : 0, 30902
Debugger [baseline] (6.188 ms) : 0, 6188
Debugger [candidate] (6.095 ms) : 0, 6095
Remote Config [baseline] (623.838 µs) : 0, 624
Remote Config [candidate] (601.158 µs) : 0, 601
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.113 ms) : 0, 8113
Flare Poller [baseline] (10.866 ms) : 0, 10866
Flare Poller [candidate] (10.847 ms) : 0, 10847
IAST [baseline] (31.195 ms) : 0, 31195
IAST [candidate] (31.199 ms) : 0, 31199
section profiling
ProfilingAgent [baseline] (112.013 ms) : 0, 112013
ProfilingAgent [candidate] (110.842 ms) : 0, 110842
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (745.692 ms) : 0, 745692
BytebuddyAgent [candidate] (733.553 ms) : 0, 733553
GlobalTracer [baseline] (225.649 ms) : 0, 225649
GlobalTracer [candidate] (222.716 ms) : 0, 222716
AppSec [baseline] (32.722 ms) : 0, 32722
AppSec [candidate] (32.009 ms) : 0, 32009
Debugger [baseline] (7.685 ms) : 0, 7685
Debugger [candidate] (6.827 ms) : 0, 6827
Remote Config [baseline] (1.518 ms) : 0, 1518
Remote Config [candidate] (678.254 µs) : 0, 678
Telemetry [baseline] (14.604 ms) : 0, 14604
Telemetry [candidate] (16.236 ms) : 0, 16236
Flare Poller [baseline] (4.242 ms) : 0, 4242
Flare Poller [candidate] (4.166 ms) : 0, 4166
Profiling [baseline] (112.66 ms) : 0, 112660
Profiling [candidate] (111.496 ms) : 0, 111496
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052222
Total [baseline] (8.689 s) : 0, 8688829
Agent [candidate] (1.051 s) : 0, 1051127
Total [candidate] (8.675 s) : 0, 8674524
section iast
Agent [baseline] (1.201 s) : 0, 1201259
Total [baseline] (9.306 s) : 0, 9305988
Agent [candidate] (1.195 s) : 0, 1194763
Total [candidate] (9.357 s) : 0, 9357271
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (707.055 ms) : 0, 707055
BytebuddyAgent [candidate] (706.725 ms) : 0, 706725
GlobalTracer [baseline] (248.88 ms) : 0, 248880
GlobalTracer [candidate] (248.734 ms) : 0, 248734
AppSec [baseline] (32.093 ms) : 0, 32093
AppSec [candidate] (32.01 ms) : 0, 32010
Debugger [baseline] (6.428 ms) : 0, 6428
Debugger [candidate] (6.422 ms) : 0, 6422
Remote Config [baseline] (687.026 µs) : 0, 687
Remote Config [candidate] (674.73 µs) : 0, 675
Telemetry [baseline] (16.526 ms) : 0, 16526
Telemetry [candidate] (15.441 ms) : 0, 15441
Flare Poller [baseline] (4.217 ms) : 0, 4217
Flare Poller [candidate] (4.747 ms) : 0, 4747
section iast
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (838.117 ms) : 0, 838117
BytebuddyAgent [candidate] (832.806 ms) : 0, 832806
GlobalTracer [baseline] (239.33 ms) : 0, 239330
GlobalTracer [candidate] (238.23 ms) : 0, 238230
IAST [baseline] (33.89 ms) : 0, 33890
IAST [candidate] (30.098 ms) : 0, 30098
AppSec [baseline] (27.876 ms) : 0, 27876
AppSec [candidate] (31.459 ms) : 0, 31459
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.157 ms) : 0, 6157
Remote Config [baseline] (615.396 µs) : 0, 615
Remote Config [candidate] (611.475 µs) : 0, 611
Telemetry [baseline] (8.005 ms) : 0, 8005
Telemetry [candidate] (8.029 ms) : 0, 8029
Flare Poller [baseline] (10.773 ms) : 0, 10773
Flare Poller [candidate] (10.821 ms) : 0, 10821
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section baseline
no_agent (18.272 ms) : 18084, 18460
. : milestone, 18272,
appsec (18.605 ms) : 18416, 18794
. : milestone, 18605,
code_origins (17.897 ms) : 17721, 18073
. : milestone, 17897,
iast (17.782 ms) : 17609, 17955
. : milestone, 17782,
profiling (18.435 ms) : 18250, 18620
. : milestone, 18435,
tracing (17.663 ms) : 17486, 17840
. : milestone, 17663,
section candidate
no_agent (18.194 ms) : 18010, 18379
. : milestone, 18194,
appsec (18.54 ms) : 18352, 18727
. : milestone, 18540,
code_origins (17.946 ms) : 17767, 18125
. : milestone, 17946,
iast (17.765 ms) : 17587, 17942
. : milestone, 17765,
profiling (19.714 ms) : 19509, 19918
. : milestone, 19714,
tracing (17.653 ms) : 17478, 17828
. : milestone, 17653,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.172 ms) : 3131, 3213
. : milestone, 3172,
iast_FULL (5.61 ms) : 5554, 5665
. : milestone, 5610,
iast_GLOBAL (3.549 ms) : 3492, 3605
. : milestone, 3549,
profiling (1.912 ms) : 1896, 1928
. : milestone, 1912,
tracing (1.782 ms) : 1768, 1797
. : milestone, 1782,
section candidate
no_agent (1.185 ms) : 1174, 1197
. : milestone, 1185,
iast (3.1 ms) : 3062, 3137
. : milestone, 3100,
iast_FULL (5.648 ms) : 5592, 5704
. : milestone, 5648,
iast_GLOBAL (3.571 ms) : 3520, 3622
. : milestone, 3571,
profiling (1.993 ms) : 1976, 2010
. : milestone, 1993,
tracing (1.816 ms) : 1800, 1831
. : milestone, 1816,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.638 ms) : 3425, 3850
. : milestone, 3638,
iast (2.215 ms) : 2150, 2281
. : milestone, 2215,
iast_GLOBAL (2.262 ms) : 2197, 2328
. : milestone, 2262,
profiling (2.065 ms) : 2012, 2118
. : milestone, 2065,
tracing (2.043 ms) : 1992, 2095
. : milestone, 2043,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.688 ms) : 3470, 3906
. : milestone, 3688,
iast (2.206 ms) : 2141, 2271
. : milestone, 2206,
iast_GLOBAL (2.257 ms) : 2191, 2322
. : milestone, 2257,
profiling (2.084 ms) : 2030, 2139
. : milestone, 2084,
tracing (2.037 ms) : 1986, 2088
. : milestone, 2037,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~46efc3136a, baseline=1.57.0-SNAPSHOT~497bd13a36
dateFormat X
axisFormat %s
section baseline
no_agent (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
appsec (14.436 s) : 14436000, 14436000
. : milestone, 14436000,
iast (18.659 s) : 18659000, 18659000
. : milestone, 18659000,
iast_GLOBAL (17.865 s) : 17865000, 17865000
. : milestone, 17865000,
profiling (14.493 s) : 14493000, 14493000
. : milestone, 14493000,
tracing (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
section candidate
no_agent (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
appsec (14.583 s) : 14583000, 14583000
. : milestone, 14583000,
iast (18.466 s) : 18466000, 18466000
. : milestone, 18466000,
iast_GLOBAL (18.284 s) : 18284000, 18284000
. : milestone, 18284000,
profiling (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
#9817 removed an eager tasks realization, while ensuring no tasks with a given name exist, however it forced to fix some behavior with the bnd gradle plugin.
In #9817 I made a mistake. This PR should provide a correct fix for this smoke test project.
The previous fix assumed it was related to the plugin update only. But actually, the missing piece was that custom bundle tasks also need to be depended on by the
checklifecycle task.Otherwise, it bnd failed the build as it was touching the configurations after Gradle made them immutable.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]