-
Notifications
You must be signed in to change notification settings - Fork 320
Crashtracking: improve OOM parsing for Zulu8 #10038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bric3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| && (sigInfo == null || "INVALID".equals(sigInfo.name)) | ||
| && !"#".equals(line))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Should these Strings be constant, like OOM_MARKER ?
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049303
Total [baseline] (8.686 s) : 0, 8686100
Agent [candidate] (1.049 s) : 0, 1049007
Total [candidate] (8.619 s) : 0, 8618611
section iast
Agent [baseline] (1.193 s) : 0, 1192864
Total [baseline] (9.291 s) : 0, 9291262
Agent [candidate] (1.192 s) : 0, 1191825
Total [candidate] (9.27 s) : 0, 9270220
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (705.46 ms) : 0, 705460
BytebuddyAgent [candidate] (705.651 ms) : 0, 705651
GlobalTracer [baseline] (248.024 ms) : 0, 248024
GlobalTracer [candidate] (247.996 ms) : 0, 247996
AppSec [baseline] (31.946 ms) : 0, 31946
AppSec [candidate] (31.948 ms) : 0, 31948
Debugger [baseline] (6.335 ms) : 0, 6335
Debugger [candidate] (6.343 ms) : 0, 6343
Remote Config [baseline] (676.568 µs) : 0, 677
Remote Config [candidate] (664.134 µs) : 0, 664
Telemetry [baseline] (15.554 ms) : 0, 15554
Telemetry [candidate] (16.067 ms) : 0, 16067
Flare Poller [baseline] (4.941 ms) : 0, 4941
Flare Poller [candidate] (4.075 ms) : 0, 4075
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (831.35 ms) : 0, 831350
BytebuddyAgent [candidate] (832.101 ms) : 0, 832101
GlobalTracer [baseline] (237.738 ms) : 0, 237738
GlobalTracer [candidate] (236.58 ms) : 0, 236580
IAST [baseline] (27.895 ms) : 0, 27895
IAST [candidate] (31.843 ms) : 0, 31843
AppSec [baseline] (33.885 ms) : 0, 33885
AppSec [candidate] (29.568 ms) : 0, 29568
Debugger [baseline] (6.165 ms) : 0, 6165
Debugger [candidate] (6.024 ms) : 0, 6024
Remote Config [baseline] (609.193 µs) : 0, 609
Remote Config [candidate] (600.793 µs) : 0, 601
Telemetry [baseline] (8.139 ms) : 0, 8139
Telemetry [candidate] (7.957 ms) : 0, 7957
Flare Poller [baseline] (10.708 ms) : 0, 10708
Flare Poller [candidate] (10.753 ms) : 0, 10753
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050011
Total [baseline] (10.777 s) : 0, 10776744
Agent [candidate] (1.057 s) : 0, 1056701
Total [candidate] (10.718 s) : 0, 10718436
section appsec
Agent [baseline] (1.228 s) : 0, 1228098
Total [baseline] (10.955 s) : 0, 10954866
Agent [candidate] (1.226 s) : 0, 1226157
Total [candidate] (10.908 s) : 0, 10908456
section iast
Agent [baseline] (1.191 s) : 0, 1190794
Total [baseline] (11.051 s) : 0, 11051256
Agent [candidate] (1.199 s) : 0, 1198869
Total [candidate] (11.183 s) : 0, 11182865
section profiling
Agent [baseline] (1.198 s) : 0, 1197959
Total [baseline] (10.821 s) : 0, 10820930
Agent [candidate] (1.194 s) : 0, 1194147
Total [candidate] (10.871 s) : 0, 10870986
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (706.118 ms) : 0, 706118
BytebuddyAgent [candidate] (710.399 ms) : 0, 710399
GlobalTracer [baseline] (248.472 ms) : 0, 248472
GlobalTracer [candidate] (250.057 ms) : 0, 250057
AppSec [baseline] (31.893 ms) : 0, 31893
AppSec [candidate] (32.3 ms) : 0, 32300
Debugger [baseline] (6.391 ms) : 0, 6391
Debugger [candidate] (6.448 ms) : 0, 6448
Remote Config [baseline] (674.58 µs) : 0, 675
Remote Config [candidate] (682.269 µs) : 0, 682
Telemetry [baseline] (15.51 ms) : 0, 15510
Telemetry [candidate] (14.756 ms) : 0, 14756
Flare Poller [baseline] (4.796 ms) : 0, 4796
Flare Poller [candidate] (5.681 ms) : 0, 5681
section appsec
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (731.871 ms) : 0, 731871
BytebuddyAgent [candidate] (731.279 ms) : 0, 731279
GlobalTracer [baseline] (241.089 ms) : 0, 241089
GlobalTracer [candidate] (240.457 ms) : 0, 240457
IAST [baseline] (24.796 ms) : 0, 24796
IAST [candidate] (24.785 ms) : 0, 24785
AppSec [baseline] (174.856 ms) : 0, 174856
AppSec [candidate] (174.155 ms) : 0, 174155
Debugger [baseline] (6.257 ms) : 0, 6257
Debugger [candidate] (6.272 ms) : 0, 6272
Remote Config [baseline] (691.477 µs) : 0, 691
Remote Config [candidate] (678.439 µs) : 0, 678
Telemetry [baseline] (8.108 ms) : 0, 8108
Telemetry [candidate] (8.137 ms) : 0, 8137
Flare Poller [baseline] (4.01 ms) : 0, 4010
Flare Poller [candidate] (4.002 ms) : 0, 4002
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (830.637 ms) : 0, 830637
BytebuddyAgent [candidate] (836.502 ms) : 0, 836502
GlobalTracer [baseline] (236.955 ms) : 0, 236955
GlobalTracer [candidate] (238.857 ms) : 0, 238857
IAST [baseline] (30.305 ms) : 0, 30305
IAST [candidate] (32.589 ms) : 0, 32589
AppSec [baseline] (31.206 ms) : 0, 31206
AppSec [candidate] (28.949 ms) : 0, 28949
Debugger [baseline] (6.067 ms) : 0, 6067
Debugger [candidate] (6.115 ms) : 0, 6115
Remote Config [baseline] (603.113 µs) : 0, 603
Remote Config [candidate] (619.83 µs) : 0, 620
Telemetry [baseline] (8.049 ms) : 0, 8049
Telemetry [candidate] (8.0 ms) : 0, 8000
Flare Poller [baseline] (10.694 ms) : 0, 10694
Flare Poller [candidate] (11.003 ms) : 0, 11003
section profiling
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (734.137 ms) : 0, 734137
BytebuddyAgent [candidate] (732.092 ms) : 0, 732092
GlobalTracer [baseline] (222.847 ms) : 0, 222847
GlobalTracer [candidate] (222.136 ms) : 0, 222136
AppSec [baseline] (32.068 ms) : 0, 32068
AppSec [candidate] (31.893 ms) : 0, 31893
Debugger [baseline] (6.808 ms) : 0, 6808
Debugger [candidate] (7.446 ms) : 0, 7446
Remote Config [baseline] (712.895 µs) : 0, 713
Remote Config [candidate] (672.491 µs) : 0, 672
Telemetry [baseline] (16.273 ms) : 0, 16273
Telemetry [candidate] (15.462 ms) : 0, 15462
Flare Poller [baseline] (4.107 ms) : 0, 4107
Flare Poller [candidate] (4.097 ms) : 0, 4097
ProfilingAgent [baseline] (110.438 ms) : 0, 110438
ProfilingAgent [candidate] (109.942 ms) : 0, 109942
Profiling [baseline] (111.07 ms) : 0, 111070
Profiling [candidate] (110.597 ms) : 0, 110597
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section baseline
no_agent (19.546 ms) : 19342, 19750
. : milestone, 19546,
appsec (18.556 ms) : 18368, 18744
. : milestone, 18556,
code_origins (17.646 ms) : 17472, 17820
. : milestone, 17646,
iast (17.856 ms) : 17677, 18035
. : milestone, 17856,
profiling (18.509 ms) : 18326, 18693
. : milestone, 18509,
tracing (17.729 ms) : 17550, 17907
. : milestone, 17729,
section candidate
no_agent (17.99 ms) : 17807, 18173
. : milestone, 17990,
appsec (18.549 ms) : 18359, 18740
. : milestone, 18549,
code_origins (17.652 ms) : 17474, 17829
. : milestone, 17652,
iast (18.886 ms) : 18696, 19076
. : milestone, 18886,
profiling (19.046 ms) : 18858, 19234
. : milestone, 19046,
tracing (17.908 ms) : 17725, 18092
. : milestone, 17908,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section baseline
no_agent (1.236 ms) : 1223, 1248
. : milestone, 1236,
iast (3.278 ms) : 3236, 3319
. : milestone, 3278,
iast_FULL (6.057 ms) : 5995, 6118
. : milestone, 6057,
iast_GLOBAL (3.584 ms) : 3528, 3639
. : milestone, 3584,
profiling (1.909 ms) : 1893, 1926
. : milestone, 1909,
tracing (1.819 ms) : 1802, 1836
. : milestone, 1819,
section candidate
no_agent (1.215 ms) : 1203, 1227
. : milestone, 1215,
iast (3.216 ms) : 3172, 3260
. : milestone, 3216,
iast_FULL (5.812 ms) : 5754, 5869
. : milestone, 5812,
iast_GLOBAL (3.691 ms) : 3634, 3748
. : milestone, 3691,
profiling (2.004 ms) : 1986, 2022
. : milestone, 2004,
tracing (1.794 ms) : 1780, 1809
. : milestone, 1794,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section baseline
no_agent (15.557 s) : 15557000, 15557000
. : milestone, 15557000,
appsec (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
iast (18.818 s) : 18818000, 18818000
. : milestone, 18818000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
tracing (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
section candidate
no_agent (15.721 s) : 15721000, 15721000
. : milestone, 15721000,
appsec (14.666 s) : 14666000, 14666000
. : milestone, 14666000,
iast (17.992 s) : 17992000, 17992000
. : milestone, 17992000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
profiling (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
tracing (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~ef4e3bec85, baseline=1.57.0-SNAPSHOT~8f0b20ea59
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.744 ms) : 3521, 3966
. : milestone, 3744,
iast (2.219 ms) : 2155, 2284
. : milestone, 2219,
iast_GLOBAL (2.265 ms) : 2200, 2331
. : milestone, 2265,
profiling (2.078 ms) : 2026, 2131
. : milestone, 2078,
tracing (2.054 ms) : 2003, 2104
. : milestone, 2054,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.651 ms) : 3438, 3864
. : milestone, 3651,
iast (2.212 ms) : 2148, 2276
. : milestone, 2212,
iast_GLOBAL (2.262 ms) : 2198, 2327
. : milestone, 2262,
profiling (2.082 ms) : 2029, 2135
. : milestone, 2082,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
|
What Does This Do
Improve OOM parsing for Zulu8 that prints a INVALID signal in the hs_err file while other jdk omit the signal.
It also includes a little leftover from a previous PR
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]