-
Notifications
You must be signed in to change notification settings - Fork 320
Store some crashtracking options on initialisation #10036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gleocadie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056902
Total [baseline] (8.735 s) : 0, 8735332
Agent [candidate] (1.053 s) : 0, 1052564
Total [candidate] (8.71 s) : 0, 8709726
section iast
Agent [baseline] (1.192 s) : 0, 1191583
Total [baseline] (9.352 s) : 0, 9352256
Agent [candidate] (1.187 s) : 0, 1187393
Total [candidate] (9.31 s) : 0, 9309885
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (710.768 ms) : 0, 710768
BytebuddyAgent [candidate] (707.793 ms) : 0, 707793
GlobalTracer [baseline] (250.036 ms) : 0, 250036
GlobalTracer [candidate] (249.027 ms) : 0, 249027
AppSec [baseline] (32.269 ms) : 0, 32269
AppSec [candidate] (32.209 ms) : 0, 32209
Debugger [baseline] (6.471 ms) : 0, 6471
Debugger [candidate] (6.404 ms) : 0, 6404
Remote Config [baseline] (685.638 µs) : 0, 686
Remote Config [candidate] (678.687 µs) : 0, 679
Telemetry [baseline] (14.565 ms) : 0, 14565
Telemetry [candidate] (14.583 ms) : 0, 14583
Flare Poller [baseline] (5.624 ms) : 0, 5624
Flare Poller [candidate] (5.539 ms) : 0, 5539
section iast
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (830.801 ms) : 0, 830801
BytebuddyAgent [candidate] (828.656 ms) : 0, 828656
GlobalTracer [baseline] (237.723 ms) : 0, 237723
GlobalTracer [candidate] (236.787 ms) : 0, 236787
AppSec [baseline] (29.677 ms) : 0, 29677
AppSec [candidate] (26.722 ms) : 0, 26722
Debugger [baseline] (6.121 ms) : 0, 6121
Debugger [candidate] (5.924 ms) : 0, 5924
Remote Config [baseline] (624.254 µs) : 0, 624
Remote Config [candidate] (603.511 µs) : 0, 604
Telemetry [baseline] (7.908 ms) : 0, 7908
Telemetry [candidate] (7.765 ms) : 0, 7765
Flare Poller [baseline] (10.822 ms) : 0, 10822
Flare Poller [candidate] (10.675 ms) : 0, 10675
IAST [baseline] (31.536 ms) : 0, 31536
IAST [candidate] (34.07 ms) : 0, 34070
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051886
Total [baseline] (10.787 s) : 0, 10787115
Agent [candidate] (1.059 s) : 0, 1059400
Total [candidate] (10.85 s) : 0, 10850147
section appsec
Agent [baseline] (1.241 s) : 0, 1240994
Total [baseline] (10.88 s) : 0, 10880491
Agent [candidate] (1.235 s) : 0, 1235246
Total [candidate] (10.969 s) : 0, 10968725
section iast
Agent [baseline] (1.193 s) : 0, 1192825
Total [baseline] (11.223 s) : 0, 11222923
Agent [candidate] (1.203 s) : 0, 1203288
Total [candidate] (11.358 s) : 0, 11357805
section profiling
Agent [baseline] (1.204 s) : 0, 1204475
Total [baseline] (10.941 s) : 0, 10940563
Agent [candidate] (1.199 s) : 0, 1198534
Total [candidate] (11.006 s) : 0, 11005763
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (706.795 ms) : 0, 706795
BytebuddyAgent [candidate] (712.049 ms) : 0, 712049
GlobalTracer [baseline] (249.143 ms) : 0, 249143
GlobalTracer [candidate] (250.663 ms) : 0, 250663
AppSec [baseline] (31.941 ms) : 0, 31941
AppSec [candidate] (32.476 ms) : 0, 32476
Debugger [baseline] (6.362 ms) : 0, 6362
Debugger [candidate] (6.53 ms) : 0, 6530
Remote Config [baseline] (678.042 µs) : 0, 678
Remote Config [candidate] (685.819 µs) : 0, 686
Telemetry [baseline] (14.219 ms) : 0, 14219
Telemetry [candidate] (14.798 ms) : 0, 14798
Flare Poller [baseline] (6.48 ms) : 0, 6480
Flare Poller [candidate] (5.68 ms) : 0, 5680
section appsec
crashtracking [baseline] (1.506 ms) : 0, 1506
crashtracking [candidate] (1.496 ms) : 0, 1496
BytebuddyAgent [baseline] (740.337 ms) : 0, 740337
BytebuddyAgent [candidate] (735.776 ms) : 0, 735776
GlobalTracer [baseline] (243.18 ms) : 0, 243180
GlobalTracer [candidate] (242.04 ms) : 0, 242040
IAST [baseline] (25.283 ms) : 0, 25283
IAST [candidate] (25.043 ms) : 0, 25043
AppSec [baseline] (176.135 ms) : 0, 176135
AppSec [candidate] (176.327 ms) : 0, 176327
Debugger [baseline] (6.346 ms) : 0, 6346
Debugger [candidate] (6.369 ms) : 0, 6369
Remote Config [baseline] (702.137 µs) : 0, 702
Remote Config [candidate] (705.645 µs) : 0, 706
Telemetry [baseline] (8.22 ms) : 0, 8220
Telemetry [candidate] (8.301 ms) : 0, 8301
Flare Poller [baseline] (4.039 ms) : 0, 4039
Flare Poller [candidate] (4.054 ms) : 0, 4054
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (831.338 ms) : 0, 831338
BytebuddyAgent [candidate] (839.571 ms) : 0, 839571
GlobalTracer [baseline] (238.355 ms) : 0, 238355
GlobalTracer [candidate] (239.241 ms) : 0, 239241
IAST [baseline] (32.457 ms) : 0, 32457
IAST [candidate] (29.303 ms) : 0, 29303
AppSec [baseline] (28.794 ms) : 0, 28794
AppSec [candidate] (32.833 ms) : 0, 32833
Debugger [baseline] (6.087 ms) : 0, 6087
Debugger [candidate] (6.129 ms) : 0, 6129
Remote Config [baseline] (604.724 µs) : 0, 605
Remote Config [candidate] (627.955 µs) : 0, 628
Telemetry [baseline] (7.916 ms) : 0, 7916
Telemetry [candidate] (8.144 ms) : 0, 8144
Flare Poller [baseline] (10.988 ms) : 0, 10988
Flare Poller [candidate] (10.82 ms) : 0, 10820
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (737.347 ms) : 0, 737347
BytebuddyAgent [candidate] (734.275 ms) : 0, 734275
GlobalTracer [baseline] (223.237 ms) : 0, 223237
GlobalTracer [candidate] (222.312 ms) : 0, 222312
AppSec [baseline] (32.352 ms) : 0, 32352
AppSec [candidate] (32.072 ms) : 0, 32072
Debugger [baseline] (7.643 ms) : 0, 7643
Debugger [candidate] (6.857 ms) : 0, 6857
Remote Config [baseline] (719.318 µs) : 0, 719
Remote Config [candidate] (1.467 ms) : 0, 1467
Telemetry [baseline] (15.476 ms) : 0, 15476
Telemetry [candidate] (15.528 ms) : 0, 15528
Flare Poller [baseline] (4.181 ms) : 0, 4181
Flare Poller [candidate] (4.171 ms) : 0, 4171
ProfilingAgent [baseline] (112.575 ms) : 0, 112575
ProfilingAgent [candidate] (111.302 ms) : 0, 111302
Profiling [baseline] (113.21 ms) : 0, 113210
Profiling [candidate] (111.929 ms) : 0, 111929
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (17.64 ms) : 17459, 17821
. : milestone, 17640,
appsec (19.41 ms) : 19212, 19607
. : milestone, 19410,
code_origins (17.667 ms) : 17492, 17842
. : milestone, 17667,
iast (17.725 ms) : 17546, 17905
. : milestone, 17725,
profiling (18.735 ms) : 18544, 18925
. : milestone, 18735,
tracing (17.379 ms) : 17210, 17548
. : milestone, 17379,
section candidate
no_agent (19.551 ms) : 19350, 19752
. : milestone, 19551,
appsec (18.755 ms) : 18561, 18949
. : milestone, 18755,
code_origins (17.698 ms) : 17525, 17871
. : milestone, 17698,
iast (17.813 ms) : 17636, 17991
. : milestone, 17813,
profiling (18.705 ms) : 18518, 18891
. : milestone, 18705,
tracing (17.82 ms) : 17637, 18004
. : milestone, 17820,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.214 ms) : 1202, 1226
. : milestone, 1214,
iast (3.182 ms) : 3139, 3224
. : milestone, 3182,
iast_FULL (5.778 ms) : 5720, 5835
. : milestone, 5778,
iast_GLOBAL (3.602 ms) : 3548, 3656
. : milestone, 3602,
profiling (2.204 ms) : 2183, 2225
. : milestone, 2204,
tracing (1.876 ms) : 1858, 1894
. : milestone, 1876,
section candidate
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.27 ms) : 3226, 3314
. : milestone, 3270,
iast_FULL (6.002 ms) : 5940, 6064
. : milestone, 6002,
iast_GLOBAL (3.602 ms) : 3553, 3651
. : milestone, 3602,
profiling (2.051 ms) : 2034, 2069
. : milestone, 2051,
tracing (1.77 ms) : 1756, 1785
. : milestone, 1770,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
appsec (14.542 s) : 14542000, 14542000
. : milestone, 14542000,
iast (18.766 s) : 18766000, 18766000
. : milestone, 18766000,
iast_GLOBAL (17.88 s) : 17880000, 17880000
. : milestone, 17880000,
profiling (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
tracing (14.761 s) : 14761000, 14761000
. : milestone, 14761000,
section candidate
no_agent (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
appsec (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
iast (18.289 s) : 18289000, 18289000
. : milestone, 18289000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
profiling (14.651 s) : 14651000, 14651000
. : milestone, 14651000,
tracing (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~2563480753, baseline=1.57.0-SNAPSHOT~0df702a3d3
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (3.694 ms) : 3475, 3912
. : milestone, 3694,
iast (2.222 ms) : 2157, 2287
. : milestone, 2222,
iast_GLOBAL (2.26 ms) : 2195, 2325
. : milestone, 2260,
profiling (2.062 ms) : 2009, 2114
. : milestone, 2062,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.648 ms) : 3434, 3863
. : milestone, 3648,
iast (2.221 ms) : 2156, 2287
. : milestone, 2221,
iast_GLOBAL (2.266 ms) : 2201, 2332
. : milestone, 2266,
profiling (2.067 ms) : 2014, 2120
. : milestone, 2067,
tracing (2.057 ms) : 2006, 2108
. : milestone, 2057,
|
What Does This Do
This PR persists the crashtracking configuration for agentless and dual shipping into error tracking at main process startup. Without doing so, those values would be unavailable in the crashtracking child process when it forks, since system-property–based settings are not inherited automatically.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]