-
Notifications
You must be signed in to change notification settings - Fork 320
Disable CodeOrigin by default #10027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it seems to lead to crashes on JDK8
db0ad35 to
353b02e
Compare
mcculls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(note you can use the JavaVirtualMachine utility if you want to only disable it on Java 8)
BenchmarksStartupParameters
See matching parameters
SummaryFound 12 performance improvements and 8 performance regressions! Performance is the same for 33 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1101093
Total [baseline] (10.802 s) : 0, 10801780
Agent [candidate] (1.054 s) : 0, 1054313
Total [candidate] (10.908 s) : 0, 10907998
section appsec
Agent [baseline] (1.284 s) : 0, 1283814
Total [baseline] (11.041 s) : 0, 11041041
Agent [candidate] (1.239 s) : 0, 1239464
Total [candidate] (11.0 s) : 0, 11000180
section iast
Agent [baseline] (1.259 s) : 0, 1258781
Total [baseline] (11.341 s) : 0, 11341228
Agent [candidate] (1.194 s) : 0, 1193533
Total [candidate] (11.232 s) : 0, 11231877
section profiling
Agent [baseline] (1.24 s) : 0, 1240045
Total [baseline] (11.173 s) : 0, 11173012
Agent [candidate] (1.204 s) : 0, 1204478
Total [candidate] (10.963 s) : 0, 10962809
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (707.074 ms) : 0, 707074
BytebuddyAgent [candidate] (709.1 ms) : 0, 709100
GlobalTracer [baseline] (248.947 ms) : 0, 248947
GlobalTracer [candidate] (249.442 ms) : 0, 249442
AppSec [baseline] (32.061 ms) : 0, 32061
AppSec [candidate] (32.151 ms) : 0, 32151
Debugger [baseline] (64.343 ms) : 0, 64343
Debugger [candidate] (6.397 ms) : 0, 6397
Remote Config [baseline] (631.218 µs) : 0, 631
Remote Config [candidate] (680.847 µs) : 0, 681
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (14.731 ms) : 0, 14731
Flare Poller [baseline] (3.69 ms) : 0, 3690
Flare Poller [candidate] (5.544 ms) : 0, 5544
section appsec
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.506 ms) : 0, 1506
BytebuddyAgent [baseline] (732.415 ms) : 0, 732415
BytebuddyAgent [candidate] (739.982 ms) : 0, 739982
GlobalTracer [baseline] (241.006 ms) : 0, 241006
GlobalTracer [candidate] (243.445 ms) : 0, 243445
IAST [baseline] (24.762 ms) : 0, 24762
IAST [candidate] (25.455 ms) : 0, 25455
AppSec [baseline] (174.091 ms) : 0, 174091
AppSec [candidate] (174.807 ms) : 0, 174807
Debugger [baseline] (61.916 ms) : 0, 61916
Debugger [candidate] (6.251 ms) : 0, 6251
Remote Config [baseline] (690.611 µs) : 0, 691
Remote Config [candidate] (685.795 µs) : 0, 686
Telemetry [baseline] (8.425 ms) : 0, 8425
Telemetry [candidate] (8.117 ms) : 0, 8117
Flare Poller [baseline] (3.996 ms) : 0, 3996
Flare Poller [candidate] (3.981 ms) : 0, 3981
section iast
crashtracking [baseline] (1.509 ms) : 0, 1509
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (847.062 ms) : 0, 847062
BytebuddyAgent [candidate] (832.378 ms) : 0, 832378
GlobalTracer [baseline] (239.598 ms) : 0, 239598
GlobalTracer [candidate] (238.052 ms) : 0, 238052
IAST [baseline] (27.906 ms) : 0, 27906
IAST [candidate] (31.686 ms) : 0, 31686
AppSec [baseline] (34.362 ms) : 0, 34362
AppSec [candidate] (29.762 ms) : 0, 29762
Debugger [baseline] (61.291 ms) : 0, 61291
Debugger [candidate] (6.041 ms) : 0, 6041
Remote Config [baseline] (557.408 µs) : 0, 557
Remote Config [candidate] (605.907 µs) : 0, 606
Telemetry [baseline] (7.667 ms) : 0, 7667
Telemetry [candidate] (7.938 ms) : 0, 7938
Flare Poller [baseline] (3.551 ms) : 0, 3551
Flare Poller [candidate] (10.789 ms) : 0, 10789
section profiling
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (739.937 ms) : 0, 739937
BytebuddyAgent [candidate] (737.995 ms) : 0, 737995
GlobalTracer [baseline] (223.944 ms) : 0, 223944
GlobalTracer [candidate] (223.825 ms) : 0, 223825
AppSec [baseline] (32.633 ms) : 0, 32633
AppSec [candidate] (32.529 ms) : 0, 32529
Debugger [baseline] (63.248 ms) : 0, 63248
Debugger [candidate] (7.773 ms) : 0, 7773
Remote Config [baseline] (671.942 µs) : 0, 672
Remote Config [candidate] (746.428 µs) : 0, 746
Telemetry [baseline] (8.013 ms) : 0, 8013
Telemetry [candidate] (15.496 ms) : 0, 15496
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (4.184 ms) : 0, 4184
ProfilingAgent [baseline] (96.943 ms) : 0, 96943
ProfilingAgent [candidate] (111.019 ms) : 0, 111019
Profiling [baseline] (97.532 ms) : 0, 97532
Profiling [candidate] (111.66 ms) : 0, 111660
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1101893
Total [baseline] (8.878 s) : 0, 8878267
Agent [candidate] (1.05 s) : 0, 1050021
Total [candidate] (8.644 s) : 0, 8643956
section iast
Agent [baseline] (1.238 s) : 0, 1237954
Total [baseline] (9.52 s) : 0, 9519752
Agent [candidate] (1.191 s) : 0, 1191163
Total [candidate] (9.291 s) : 0, 9290874
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (708.499 ms) : 0, 708499
BytebuddyAgent [candidate] (706.266 ms) : 0, 706266
GlobalTracer [baseline] (248.831 ms) : 0, 248831
GlobalTracer [candidate] (248.123 ms) : 0, 248123
AppSec [baseline] (32.036 ms) : 0, 32036
AppSec [candidate] (31.876 ms) : 0, 31876
Debugger [baseline] (63.635 ms) : 0, 63635
Debugger [candidate] (6.377 ms) : 0, 6377
Remote Config [baseline] (646.108 µs) : 0, 646
Remote Config [candidate] (677.409 µs) : 0, 677
Telemetry [baseline] (8.228 ms) : 0, 8228
Telemetry [candidate] (14.855 ms) : 0, 14855
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (5.606 ms) : 0, 5606
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (831.36 ms) : 0, 831360
BytebuddyAgent [candidate] (831.107 ms) : 0, 831107
GlobalTracer [baseline] (237.417 ms) : 0, 237417
GlobalTracer [candidate] (237.499 ms) : 0, 237499
AppSec [baseline] (33.103 ms) : 0, 33103
AppSec [candidate] (26.878 ms) : 0, 26878
Debugger [baseline] (59.729 ms) : 0, 59729
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (539.378 µs) : 0, 539
Remote Config [candidate] (605.685 µs) : 0, 606
Telemetry [baseline] (7.582 ms) : 0, 7582
Telemetry [candidate] (7.868 ms) : 0, 7868
Flare Poller [baseline] (3.414 ms) : 0, 3414
Flare Poller [candidate] (10.846 ms) : 0, 10846
IAST [baseline] (28.53 ms) : 0, 28530
IAST [candidate] (34.171 ms) : 0, 34171
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.204 ms) : 3160, 3249
. : milestone, 3204,
iast_FULL (5.773 ms) : 5715, 5831
. : milestone, 5773,
iast_GLOBAL (3.653 ms) : 3600, 3707
. : milestone, 3653,
profiling (2.016 ms) : 1998, 2035
. : milestone, 2016,
tracing (1.872 ms) : 1856, 1888
. : milestone, 1872,
section candidate
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.12 ms) : 3077, 3163
. : milestone, 3120,
iast_FULL (5.694 ms) : 5638, 5751
. : milestone, 5694,
iast_GLOBAL (3.506 ms) : 3455, 3558
. : milestone, 3506,
profiling (2.001 ms) : 1983, 2019
. : milestone, 2001,
tracing (1.778 ms) : 1762, 1793
. : milestone, 1778,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (18.474 ms) : 18285, 18663
. : milestone, 18474,
appsec (18.591 ms) : 18405, 18778
. : milestone, 18591,
code_origins (17.525 ms) : 17350, 17700
. : milestone, 17525,
iast (17.688 ms) : 17511, 17866
. : milestone, 17688,
profiling (18.756 ms) : 18568, 18944
. : milestone, 18756,
tracing (17.567 ms) : 17391, 17744
. : milestone, 17567,
section candidate
no_agent (17.043 ms) : 16872, 17213
. : milestone, 17043,
appsec (18.728 ms) : 18536, 18921
. : milestone, 18728,
code_origins (18.97 ms) : 18781, 19160
. : milestone, 18970,
iast (17.737 ms) : 17559, 17916
. : milestone, 17737,
profiling (18.509 ms) : 18325, 18692
. : milestone, 18509,
tracing (17.445 ms) : 17273, 17618
. : milestone, 17445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.461 ms) : 2409, 2514
. : milestone, 2461,
iast (2.217 ms) : 2151, 2282
. : milestone, 2217,
iast_GLOBAL (2.258 ms) : 2193, 2324
. : milestone, 2258,
profiling (2.076 ms) : 2023, 2129
. : milestone, 2076,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.462 ms) : 2410, 2514
. : milestone, 2462,
iast (2.214 ms) : 2149, 2278
. : milestone, 2214,
iast_GLOBAL (2.262 ms) : 2196, 2328
. : milestone, 2262,
profiling (2.098 ms) : 2043, 2152
. : milestone, 2098,
tracing (2.058 ms) : 2007, 2109
. : milestone, 2058,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~353b02e363, baseline=1.57.0-SNAPSHOT~c8bb44440b
dateFormat X
axisFormat %s
section baseline
no_agent (15.477 s) : 15477000, 15477000
. : milestone, 15477000,
appsec (14.802 s) : 14802000, 14802000
. : milestone, 14802000,
iast (18.832 s) : 18832000, 18832000
. : milestone, 18832000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
tracing (14.793 s) : 14793000, 14793000
. : milestone, 14793000,
section candidate
no_agent (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
appsec (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
iast (18.576 s) : 18576000, 18576000
. : milestone, 18576000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
profiling (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
|
|
Added |
What Does This Do
Motivation
it seems to lead to crashes on JDK8
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4768