-
Notifications
You must be signed in to change notification settings - Fork 320
🪞 10020 - Extract trace context from Kafka producer record headers #10022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076864
Total [baseline] (8.76 s) : 0, 8760485
Agent [candidate] (1.08 s) : 0, 1080044
Total [candidate] (8.775 s) : 0, 8775025
section iast
Agent [baseline] (1.22 s) : 0, 1220119
Total [baseline] (9.475 s) : 0, 9474685
Agent [candidate] (1.234 s) : 0, 1233640
Total [candidate] (9.509 s) : 0, 9509170
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (645.707 ms) : 0, 645707
BytebuddyAgent [candidate] (648.424 ms) : 0, 648424
GlobalTracer [baseline] (280.882 ms) : 0, 280882
GlobalTracer [candidate] (282.018 ms) : 0, 282018
AppSec [baseline] (32.3 ms) : 0, 32300
AppSec [candidate] (32.221 ms) : 0, 32221
Debugger [baseline] (67.787 ms) : 0, 67787
Debugger [candidate] (67.111 ms) : 0, 67111
Remote Config [baseline] (652.765 µs) : 0, 653
Remote Config [candidate] (654.443 µs) : 0, 654
Telemetry [baseline] (9.052 ms) : 0, 9052
Telemetry [candidate] (9.009 ms) : 0, 9009
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.622 ms) : 0, 3622
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (789.021 ms) : 0, 789021
BytebuddyAgent [candidate] (799.26 ms) : 0, 799260
GlobalTracer [baseline] (255.196 ms) : 0, 255196
GlobalTracer [candidate] (256.802 ms) : 0, 256802
IAST [baseline] (27.778 ms) : 0, 27778
IAST [candidate] (27.205 ms) : 0, 27205
AppSec [baseline] (34.493 ms) : 0, 34493
AppSec [candidate] (34.741 ms) : 0, 34741
Debugger [baseline] (64.523 ms) : 0, 64523
Debugger [candidate] (66.055 ms) : 0, 66055
Remote Config [baseline] (537.458 µs) : 0, 537
Remote Config [candidate] (567.142 µs) : 0, 567
Telemetry [baseline] (8.411 ms) : 0, 8411
Telemetry [candidate] (8.468 ms) : 0, 8468
Flare Poller [baseline] (3.453 ms) : 0, 3453
Flare Poller [candidate] (3.432 ms) : 0, 3432
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080158
Total [baseline] (10.861 s) : 0, 10860548
Agent [candidate] (1.087 s) : 0, 1086563
Total [candidate] (10.825 s) : 0, 10825420
section appsec
Agent [baseline] (1.26 s) : 0, 1260103
Total [baseline] (10.974 s) : 0, 10974394
Agent [candidate] (1.273 s) : 0, 1272763
Total [candidate] (11.187 s) : 0, 11187448
section iast
Agent [baseline] (1.232 s) : 0, 1232193
Total [baseline] (11.151 s) : 0, 11150754
Agent [candidate] (1.225 s) : 0, 1225084
Total [candidate] (11.216 s) : 0, 11216160
section profiling
Agent [baseline] (1.203 s) : 0, 1203046
Total [baseline] (11.059 s) : 0, 11058928
Agent [candidate] (1.206 s) : 0, 1205784
Total [candidate] (11.06 s) : 0, 11059689
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (647.464 ms) : 0, 647464
BytebuddyAgent [candidate] (651.846 ms) : 0, 651846
GlobalTracer [baseline] (281.759 ms) : 0, 281759
GlobalTracer [candidate] (283.39 ms) : 0, 283390
AppSec [baseline] (32.484 ms) : 0, 32484
AppSec [candidate] (32.618 ms) : 0, 32618
Debugger [baseline] (68.319 ms) : 0, 68319
Debugger [candidate] (68.468 ms) : 0, 68468
Remote Config [baseline] (656.816 µs) : 0, 657
Remote Config [candidate] (654.017 µs) : 0, 654
Telemetry [baseline] (8.999 ms) : 0, 8999
Telemetry [candidate] (8.907 ms) : 0, 8907
Flare Poller [baseline] (3.703 ms) : 0, 3703
Flare Poller [candidate] (3.708 ms) : 0, 3708
section appsec
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (686.993 ms) : 0, 686993
BytebuddyAgent [candidate] (693.863 ms) : 0, 693863
GlobalTracer [baseline] (258.314 ms) : 0, 258314
GlobalTracer [candidate] (260.525 ms) : 0, 260525
IAST [baseline] (24.394 ms) : 0, 24394
IAST [candidate] (24.761 ms) : 0, 24761
AppSec [baseline] (173.734 ms) : 0, 173734
AppSec [candidate] (175.867 ms) : 0, 175867
Debugger [baseline] (66.653 ms) : 0, 66653
Debugger [candidate] (67.211 ms) : 0, 67211
Remote Config [baseline] (705.658 µs) : 0, 706
Remote Config [candidate] (673.829 µs) : 0, 674
Telemetry [baseline] (8.75 ms) : 0, 8750
Telemetry [candidate] (8.95 ms) : 0, 8950
Flare Poller [baseline] (3.807 ms) : 0, 3807
Flare Poller [candidate] (3.923 ms) : 0, 3923
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (796.398 ms) : 0, 796398
BytebuddyAgent [candidate] (791.693 ms) : 0, 791693
GlobalTracer [baseline] (256.967 ms) : 0, 256967
GlobalTracer [candidate] (255.678 ms) : 0, 255678
IAST [baseline] (27.345 ms) : 0, 27345
IAST [candidate] (27.033 ms) : 0, 27033
AppSec [baseline] (35.631 ms) : 0, 35631
AppSec [candidate] (35.397 ms) : 0, 35397
Debugger [baseline] (66.595 ms) : 0, 66595
Debugger [candidate] (66.058 ms) : 0, 66058
Remote Config [baseline] (540.745 µs) : 0, 541
Remote Config [candidate] (547.719 µs) : 0, 548
Telemetry [baseline] (8.516 ms) : 0, 8516
Telemetry [candidate] (8.517 ms) : 0, 8517
Flare Poller [baseline] (3.498 ms) : 0, 3498
Flare Poller [candidate] (3.481 ms) : 0, 3481
section profiling
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (700.192 ms) : 0, 700192
BytebuddyAgent [candidate] (701.198 ms) : 0, 701198
GlobalTracer [baseline] (220.575 ms) : 0, 220575
GlobalTracer [candidate] (220.842 ms) : 0, 220842
AppSec [baseline] (32.163 ms) : 0, 32163
AppSec [candidate] (32.212 ms) : 0, 32212
Debugger [baseline] (68.047 ms) : 0, 68047
Debugger [candidate] (68.335 ms) : 0, 68335
Remote Config [baseline] (637.579 µs) : 0, 638
Remote Config [candidate] (665.513 µs) : 0, 666
Telemetry [baseline] (9.004 ms) : 0, 9004
Telemetry [candidate] (8.99 ms) : 0, 8990
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.779 ms) : 0, 3779
ProfilingAgent [baseline] (97.788 ms) : 0, 97788
ProfilingAgent [candidate] (99.006 ms) : 0, 99006
Profiling [baseline] (98.359 ms) : 0, 98359
Profiling [candidate] (99.601 ms) : 0, 99601
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.216 ms) : 1204, 1228
. : milestone, 1216,
iast (3.286 ms) : 3242, 3331
. : milestone, 3286,
iast_FULL (5.849 ms) : 5792, 5907
. : milestone, 5849,
iast_GLOBAL (3.656 ms) : 3597, 3716
. : milestone, 3656,
profiling (2.145 ms) : 2126, 2164
. : milestone, 2145,
tracing (1.839 ms) : 1823, 1855
. : milestone, 1839,
section candidate
no_agent (1.193 ms) : 1182, 1204
. : milestone, 1193,
iast (3.111 ms) : 3072, 3149
. : milestone, 3111,
iast_FULL (5.61 ms) : 5555, 5665
. : milestone, 5610,
iast_GLOBAL (3.717 ms) : 3657, 3777
. : milestone, 3717,
profiling (1.952 ms) : 1936, 1969
. : milestone, 1952,
tracing (1.804 ms) : 1789, 1819
. : milestone, 1804,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (18.234 ms) : 18051, 18417
. : milestone, 18234,
appsec (19.797 ms) : 19596, 19998
. : milestone, 19797,
code_origins (17.909 ms) : 17732, 18086
. : milestone, 17909,
iast (18.584 ms) : 18395, 18772
. : milestone, 18584,
profiling (18.78 ms) : 18586, 18974
. : milestone, 18780,
tracing (17.817 ms) : 17638, 17996
. : milestone, 17817,
section candidate
no_agent (18.491 ms) : 18298, 18684
. : milestone, 18491,
appsec (18.621 ms) : 18431, 18811
. : milestone, 18621,
code_origins (18.324 ms) : 18140, 18507
. : milestone, 18324,
iast (17.842 ms) : 17665, 18019
. : milestone, 17842,
profiling (18.462 ms) : 18277, 18647
. : milestone, 18462,
tracing (17.864 ms) : 17686, 18043
. : milestone, 17864,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (18.534 s) : 18534000, 18534000
. : milestone, 18534000,
iast_GLOBAL (17.823 s) : 17823000, 17823000
. : milestone, 17823000,
profiling (14.477 s) : 14477000, 14477000
. : milestone, 14477000,
tracing (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
section candidate
no_agent (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
appsec (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
iast (18.081 s) : 18081000, 18081000
. : milestone, 18081000,
iast_GLOBAL (18.141 s) : 18141000, 18141000
. : milestone, 18141000,
profiling (14.665 s) : 14665000, 14665000
. : milestone, 14665000,
tracing (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~82a174513b, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1484
. : milestone, 1472,
appsec (3.697 ms) : 3480, 3914
. : milestone, 3697,
iast (2.221 ms) : 2156, 2286
. : milestone, 2221,
iast_GLOBAL (2.258 ms) : 2193, 2323
. : milestone, 2258,
profiling (2.092 ms) : 2037, 2147
. : milestone, 2092,
tracing (2.042 ms) : 1991, 2093
. : milestone, 2042,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.641 ms) : 3425, 3857
. : milestone, 3641,
iast (2.206 ms) : 2142, 2271
. : milestone, 2206,
iast_GLOBAL (2.252 ms) : 2187, 2318
. : milestone, 2252,
profiling (2.049 ms) : 1997, 2101
. : milestone, 2049,
tracing (2.04 ms) : 1989, 2091
. : milestone, 2040,
|
82282ea to
a5a3c26
Compare
a5a3c26 to
5d8b3c9
Compare
5d8b3c9 to
8fed0a3
Compare
8fed0a3 to
a8cb36a
Compare
Allow Kafka producers to continue existing traces by extracting trace context from record headers and using it as parent for the produce span. This enables distributed tracing when messages are forwarded between services with pre-existing context.
a8cb36a to
82a1745
Compare
This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.
Original PR: #10020
Original Author: @PlugaruT
Original Branch: PlugaruT/dd-trace-java:fix/propagate-kafka-producer-trace-context-if-exists
Closes #10020
This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.