feat(bootstrap): Removing optimization

PerfectSlayer · PerfectSlayer · commit f7b9cb0fb11f · 2025-08-12T16:33:31.000+02:00
Unclear of the benefits compared to the existing optimization.
diff --git a/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentSpan.java b/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentSpan.java
@@ -216,12 +216,4 @@ default <T> T get(@Nonnull ContextKey<T> key) {
   default <T> Context with(@Nonnull ContextKey<T> key, @Nullable T value) {
     return SPAN_KEY == key ? (Context) value : Context.root().with(SPAN_KEY, this, key, value);
   }
-
-  @Override
-  default Context with(@Nullable ImplicitContextKeyed value) {
-    if (value instanceof AgentSpan) {
-      return (AgentSpan) value;
-    }
-    return Context.super.with(value);
-  }
 }

Original file line number	Diff line number	Diff line change
`@@ -216,12 +216,4 @@ default <T> T get(@Nonnull ContextKey<T> key) {`
`216`	`216`	`default <T> Context with(@Nonnull ContextKey<T> key, @Nullable T value) {`
`217`	`217`	`return SPAN_KEY == key ? (Context) value : Context.root().with(SPAN_KEY, this, key, value);`
`218`	`218`	`}`
`219`		`-`
`220`		`- @Override`
`221`		`- default Context with(@Nullable ImplicitContextKeyed value) {`
`222`		`- if (value instanceof AgentSpan) {`
`223`		`- return (AgentSpan) value;`
`224`		`- }`
`225`		`- return Context.super.with(value);`
`226`		`- }`
`227`	`219`	`}`