Add protobuf collections as safe ones

jpbempel · jpbempel · commit eee82fb98f1f · 2024-08-23T15:17:41.000+02:00
protobuf collections used are specific ones implementing JDK
interfaces. They are in-memory collection so it is safe to handle them
like the JDK ones.
diff --git a/dd-java-agent/agent-debugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/util/WellKnownClasses.java b/dd-java-agent/agent-debugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/util/WellKnownClasses.java
@@ -160,6 +160,10 @@ public static boolean isSafe(Collection<?> collection) {
       // All Collection implementations from JDK base module are considered as safe
       return true;
     }
+    if (className.startsWith("com.google.protobuf.")) {
+      // All Collection implementations from Google ProtoBuf are considered as safe
+      return true;
+    }
     return false;
   }
 
@@ -170,6 +174,10 @@ public static boolean isSafe(Map<?, ?> map) {
       // All Map implementations from JDK base module are considered as safe
       return true;
     }
+    if (className.startsWith("com.google.protobuf.")) {
+      // All Map implementations from Google ProtoBuf are considered as safe
+      return true;
+    }
     return false;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,10 @@ public static boolean isSafe(Collection<?> collection) {`
`160`	`160`	`// All Collection implementations from JDK base module are considered as safe`
`161`	`161`	`return true;`
`162`	`162`	`}`
	`163`	`+ if (className.startsWith("com.google.protobuf.")) {`
	`164`	`+ // All Collection implementations from Google ProtoBuf are considered as safe`
	`165`	`+ return true;`
	`166`	`+ }`
`163`	`167`	`return false;`
`164`	`168`	`}`
`165`	`169`
`@@ -170,6 +174,10 @@ public static boolean isSafe(Map<?, ?> map) {`
`170`	`174`	`// All Map implementations from JDK base module are considered as safe`
`171`	`175`	`return true;`
`172`	`176`	`}`
	`177`	`+ if (className.startsWith("com.google.protobuf.")) {`
	`178`	`+ // All Map implementations from Google ProtoBuf are considered as safe`
	`179`	`+ return true;`
	`180`	`+ }`
`173`	`181`	`return false;`
`174`	`182`	`}`
`175`	`183`