codenarc

randomanderson · randomanderson · commit ee55e639a921 · 2025-02-26T02:08:08.000-05:00
diff --git a/dd-trace-core/src/traceAgentTest/groovy/AbstractTraceAgentTest.groovy b/dd-trace-core/src/traceAgentTest/groovy/AbstractTraceAgentTest.groovy
@@ -40,17 +40,17 @@ abstract class AbstractTraceAgentTest extends DDSpecification {
   String getAgentContainerHost() {
     if (agentContainer) {
       return (String) agentContainer.getHost()
-    } else {
-      return System.getenv("CI_AGENT_HOST")
     }
+
+    return System.getenv("CI_AGENT_HOST")
   }
 
   String getAgentContainerPort() {
     if (agentContainer) {
       return (String) agentContainer.getMappedPort(ConfigDefaults.DEFAULT_TRACE_AGENT_PORT)
-    } else {
-      return ConfigDefaults.DEFAULT_TRACE_AGENT_PORT
     }
+
+    return ConfigDefaults.DEFAULT_TRACE_AGENT_PORT
   }
 
   def cleanupSpec() {

Original file line number	Diff line number	Diff line change
`@@ -40,17 +40,17 @@ abstract class AbstractTraceAgentTest extends DDSpecification {`
`40`	`40`	`String getAgentContainerHost() {`
`41`	`41`	`if (agentContainer) {`
`42`	`42`	`return (String) agentContainer.getHost()`
`43`		`- } else {`
`44`		`- return System.getenv("CI_AGENT_HOST")`
`45`	`43`	`}`
	`44`	`+`
	`45`	`+ return System.getenv("CI_AGENT_HOST")`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`String getAgentContainerPort() {`
`49`	`49`	`if (agentContainer) {`
`50`	`50`	`return (String) agentContainer.getMappedPort(ConfigDefaults.DEFAULT_TRACE_AGENT_PORT)`
`51`		`- } else {`
`52`		`- return ConfigDefaults.DEFAULT_TRACE_AGENT_PORT`
`53`	`51`	`}`
	`52`	`+`
	`53`	`+ return ConfigDefaults.DEFAULT_TRACE_AGENT_PORT`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`def cleanupSpec() {`