Fix StringModuleTest

Mariovido · Mariovido · commit e1bcfc9ea70c · 2024-11-21T18:46:17.000+01:00
diff --git a/dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/propagation/StringModuleTest.groovy b/dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/propagation/StringModuleTest.groovy
@@ -1269,7 +1269,7 @@ class StringModuleTest extends IastModuleImplTestBase {
     return new StringBuilder(string)
   }
 
-  private static StringBuilder sbf(final String string) {
-    return new StringBuilder(string)
+  private static StringBuffer sbf(final String string) {
+    return new StringBuffer(string)
   }
 }
diff --git a/dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/taint/TaintUtils.groovy b/dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/taint/TaintUtils.groovy
@@ -103,13 +103,18 @@ class TaintUtils {
     return resultString
   }
 
-  static StringBuilder addFromTaintFormat(final TaintedObjects tos, final StringBuilder sb) {
+  static Appendable addFromTaintFormat(final TaintedObjects tos, final Appendable sb) {
     final String s = sb.toString()
     final ranges = fromTaintFormat(s)
     if (ranges == null || ranges.length == 0) {
       return sb
     }
-    final result = new StringBuilder(getStringFromTaintFormat(s))
+    def result
+    if (sb instanceof StringBuffer) {
+      result = new StringBuffer(getStringFromTaintFormat(s))
+    } else {
+      result = new StringBuilder(getStringFromTaintFormat(s))
+    }
     tos.taint(result, ranges)
     return result
   }

Original file line number	Diff line number	Diff line change
`@@ -1269,7 +1269,7 @@ class StringModuleTest extends IastModuleImplTestBase {`
`1269`	`1269`	`return new StringBuilder(string)`
`1270`	`1270`	`}`
`1271`	`1271`
`1272`		`- private static StringBuilder sbf(final String string) {`
`1273`		`- return new StringBuilder(string)`
	`1272`	`+ private static StringBuffer sbf(final String string) {`
	`1273`	`+ return new StringBuffer(string)`
`1274`	`1274`	`}`
`1275`	`1275`	`}`