Catch invalid patterns exception from dd.data.jobs.command.pattern (#7383)

paul-laffon-dd · web-flow · commit e0d4e2291bf2 · 2024-08-05T11:27:08.000+02:00
Catch exception when compiling data jobs command pattern

Not failing tracer installation if the pattern is invalid
diff --git a/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java b/dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java
@@ -53,6 +53,7 @@
 import java.util.EnumSet;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.regex.PatternSyntaxException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -1325,6 +1326,14 @@ private static boolean isDataJobsSupported(String javaCommand, String dataJobsCo
       return true;
     }
 
-    return javaCommand.matches(dataJobsCommandPattern);
+    try {
+      return javaCommand.matches(dataJobsCommandPattern);
+    } catch (PatternSyntaxException e) {
+      log.warn(
+          "Invalid data jobs command pattern {}. The value must be a valid regex",
+          dataJobsCommandPattern);
+    }
+
+    return true;
   }
 }
