use seconds instead of millisecs with Instant.MIN

jpbempel · jpbempel · commit d3f552545011 · 2024-05-07T10:41:27.000+02:00
diff --git a/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception/ExceptionProbeManager.java b/dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception/ExceptionProbeManager.java
@@ -31,7 +31,7 @@ public class ExceptionProbeManager {
   // FIXME: if this becomes a bottleneck, find a way to make it concurrent weak identity hashmap
   private final Map<Throwable, ThrowableState> snapshotsByThrowable =
       Collections.synchronizedMap(new WeakIdentityHashMap<>());
-  private final long captureIntervalMS;
+  private final long captureIntervalS;
   private final Clock clock;
 
   public ExceptionProbeManager(ClassNameFiltering classNameFiltering, Duration captureInterval) {
@@ -45,7 +45,7 @@ public ExceptionProbeManager(ClassNameFiltering classNameFiltering, Duration cap
   ExceptionProbeManager(
       ClassNameFiltering classNameFiltering, Duration captureInterval, Clock clock) {
     this.classNameFiltering = classNameFiltering;
-    this.captureIntervalMS = captureInterval.toMillis();
+    this.captureIntervalS = captureInterval.getSeconds();
     this.clock = clock;
   }
 
@@ -105,7 +105,7 @@ boolean shouldCaptureException(String fingerprint, Clock clock) {
     if (lastCapture == null) {
       return false;
     }
-    return ChronoUnit.MILLIS.between(lastCapture, Instant.now(clock)) >= captureIntervalMS;
+    return ChronoUnit.SECONDS.between(lastCapture, Instant.now(clock)) >= captureIntervalS;
   }
 
   public void addSnapshot(Snapshot snapshot) {
diff --git a/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/exception/ExceptionProbeManagerTest.java b/dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/exception/ExceptionProbeManagerTest.java
@@ -45,7 +45,7 @@ void instrumentSingleFrame() {
 
     String fingerprint = Fingerprinter.fingerprint(exception, classNameFiltering);
     assertEquals("1c27b291764c9d387fb85247bb7c2711f885aadfbf2f64fed34b2e0c64c5a2", fingerprint);
-    exceptionProbeManager.createProbesForException(fingerprint, exception.getStackTrace());
+    exceptionProbeManager.createProbesForException(exception.getStackTrace());
     assertEquals(1, exceptionProbeManager.getProbes().size());
     ExceptionProbe exceptionProbe = exceptionProbeManager.getProbes().iterator().next();
     assertEquals(
