Remove warning whenever we receive an unknown WAF address

smola · smola · commit c35fcfe7e7a9 · 2024-08-21T09:35:00.000+02:00
These happens whenever we receive rules for an address that is not
supported by the current version, which is bound to happen for
previously released tracers. This has proved to be non-helpful so far,
and confusing to customers. Other tracers are not logging this either.
diff --git a/dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java b/dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java
@@ -387,8 +387,6 @@ private static Collection<Address<?>> getUsedAddresses(PowerwafContext ctx) {
       Address<?> address = KnownAddresses.forName(addrKey);
       if (address != null) {
         addressList.add(address);
-      } else {
-        log.warn("WAF has rule against unknown address {}", addrKey);
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -387,8 +387,6 @@ private static Collection<Address<?>> getUsedAddresses(PowerwafContext ctx) {`
`387`	`387`	`Address<?> address = KnownAddresses.forName(addrKey);`
`388`	`388`	`if (address != null) {`
`389`	`389`	`addressList.add(address);`
`390`		`- } else {`
`391`		`- log.warn("WAF has rule against unknown address {}", addrKey);`
`392`	`390`	`}`
`393`	`391`	`}`
`394`	`392`