suggestion

amarziali · amarziali · commit 93aa163f5cdf · 2025-09-10T11:01:44.000+02:00
diff --git a/dd-trace-core/src/main/java/datadog/trace/common/metrics/ConflatingMetricsAggregator.java b/dd-trace-core/src/main/java/datadog/trace/common/metrics/ConflatingMetricsAggregator.java
@@ -293,7 +293,8 @@ public boolean publish(List<? extends CoreSpan<?>> trace) {
 
   private boolean shouldComputeMetric(CoreSpan<?> span) {
     return (span.isMeasured() || span.isTopLevel() || spanKindEligible(span))
-        && span.getLongRunningVersion() <= 0 // either not long-running or unpublished long-running span
+        && span.getLongRunningVersion()
+            <= 0 // either not long-running or unpublished long-running span
         && span.getDurationNano() > 0;
   }
 
diff --git a/dd-trace-core/src/test/groovy/datadog/trace/common/metrics/ConflatingMetricAggregatorTest.groovy b/dd-trace-core/src/test/groovy/datadog/trace/common/metrics/ConflatingMetricAggregatorTest.groovy
@@ -833,7 +833,7 @@ class ConflatingMetricAggregatorTest extends DDSpecification {
     when:
     CountDownLatch latch = new CountDownLatch(1)
     aggregator.publish([
-      new SimpleSpan("service", "operation", "resource", "type", true, true, false, 0, 100, HTTP_OK, true, 1),
+      new SimpleSpan("service", "operation", "resource", "type", true, true, false, 0, 100, HTTP_OK, true, 12345),
       new SimpleSpan("service", "operation", "resource", "type", true, true, false, 0, 100, HTTP_OK, true, 0)
     ])
     aggregator.report()

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,8 @@ public boolean publish(List<? extends CoreSpan<?>> trace) {`
`293`	`293`
`294`	`294`	`private boolean shouldComputeMetric(CoreSpan<?> span) {`
`295`	`295`	`return (span.isMeasured() \|\| span.isTopLevel() \|\| spanKindEligible(span))`
`296`		`- && span.getLongRunningVersion() <= 0 // either not long-running or unpublished long-running span`
	`296`	`+ && span.getLongRunningVersion()`
	`297`	`+ <= 0 // either not long-running or unpublished long-running span`
`297`	`298`	`&& span.getDurationNano() > 0;`
`298`	`299`	`}`
`299`	`300`