Avoid permission issues for the crash uploader script (#6697)

jbachorik · web-flow · commit 79327cd5f2ab · 2024-02-19T14:46:56.000+01:00
diff --git a/dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/ScriptInitializer.java b/dd-java-agent/agent-crashtracking/src/main/java/com/datadog/crashtracking/ScriptInitializer.java
@@ -58,7 +58,9 @@ static void initialize(String onErrorVal, String onErrorFile) throws IOException
     if (scriptPath.getFileName().toString().toLowerCase(Locale.ROOT).contains("dd_crash_uploader")
         && Files.notExists(scriptPath)) {
       try {
-        Files.createDirectories(scriptPath.getParent());
+        Files.createDirectories(
+            scriptPath.getParent(),
+            PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rwxrwxrwx")));
       } catch (FileAlreadyExistsException ignored) {
         // can be safely ignored; if the folder exists we will just reuse it
       }
@@ -86,7 +88,7 @@ private static void writeScript(String crashFile, String execClass, Path scriptP
             .forEach(line -> writeLine(bw, line));
       }
     }
-    Files.setPosixFilePermissions(scriptPath, PosixFilePermissions.fromString("r-xr-x---"));
+    Files.setPosixFilePermissions(scriptPath, PosixFilePermissions.fromString("r-xr-xr-x"));
   }
 
   private static void writeLine(BufferedWriter bw, String line) {

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,9 @@ static void initialize(String onErrorVal, String onErrorFile) throws IOException`
`58`	`58`	`if (scriptPath.getFileName().toString().toLowerCase(Locale.ROOT).contains("dd_crash_uploader")`
`59`	`59`	`&& Files.notExists(scriptPath)) {`
`60`	`60`	`try {`
`61`		`- Files.createDirectories(scriptPath.getParent());`
	`61`	`+ Files.createDirectories(`
	`62`	`+ scriptPath.getParent(),`
	`63`	`+ PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rwxrwxrwx")));`
`62`	`64`	`} catch (FileAlreadyExistsException ignored) {`
`63`	`65`	`// can be safely ignored; if the folder exists we will just reuse it`
`64`	`66`	`}`
`@@ -86,7 +88,7 @@ private static void writeScript(String crashFile, String execClass, Path scriptP`
`86`	`88`	`.forEach(line -> writeLine(bw, line));`
`87`	`89`	`}`
`88`	`90`	`}`
`89`		`- Files.setPosixFilePermissions(scriptPath, PosixFilePermissions.fromString("r-xr-x---"));`
	`91`	`+ Files.setPosixFilePermissions(scriptPath, PosixFilePermissions.fromString("r-xr-xr-x"));`
`90`	`92`	`}`
`91`	`93`
`92`	`94`	`private static void writeLine(BufferedWriter bw, String line) {`