Add comment on finishApplication called using reflection

paul-laffon-dd · paul-laffon-dd · commit 62109bfe232d · 2025-03-27T13:25:38.000+01:00
diff --git a/dd-java-agent/instrumentation/spark/src/main/java/datadog/trace/instrumentation/spark/AbstractDatadogSparkListener.java b/dd-java-agent/instrumentation/spark/src/main/java/datadog/trace/instrumentation/spark/AbstractDatadogSparkListener.java
@@ -239,6 +239,8 @@ public void onApplicationEnd(SparkListenerApplicationEnd applicationEnd) {
     }
   }
 
+  // This function is called using reflection in SparkExitInstrumentation, make sure to update if
+  // the signature of this function is changed
   public synchronized void finishApplication(
       long time, Throwable throwable, int exitCode, String msg) {
     log.info("Finishing spark application trace");

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,8 @@ public void onApplicationEnd(SparkListenerApplicationEnd applicationEnd) {`
`239`	`239`	`}`
`240`	`240`	`}`
`241`	`241`
	`242`	`+ // This function is called using reflection in SparkExitInstrumentation, make sure to update if`
	`243`	`+ // the signature of this function is changed`
`242`	`244`	`public synchronized void finishApplication(`
`243`	`245`	`long time, Throwable throwable, int exitCode, String msg) {`
`244`	`246`	`log.info("Finishing spark application trace");`