Do not skip cov report creation if a source path cannot be determined

nikita-tkachenko-datadog · nikita-tkachenko-datadog · commit 5cdf8481ed78 · 2024-07-24T16:27:59.000+02:00
diff --git a/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/coverage/file/FileCoverageStore.java b/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/coverage/file/FileCoverageStore.java
@@ -67,9 +67,7 @@ protected TestReport report(
               "Skipping coverage reporting for {} because source path could not be determined",
               clazz);
           metrics.add(CiVisibilityCountMetric.CODE_COVERAGE_ERRORS, 1, CoverageErrorType.PATH);
-          // Abort, since we cannot gather complete and accurate coverage.
-          // No coverage will be submitted, and ITR will not skip this test.
-          return null;
+          continue;
         }
         coveredPaths.add(sourcePath);
       }
@@ -81,9 +79,7 @@ protected TestReport report(
               "Skipping coverage reporting for {} because resource path could not be determined",
               nonCodeResource);
           metrics.add(CiVisibilityCountMetric.CODE_COVERAGE_ERRORS, 1, CoverageErrorType.PATH);
-          // Abort, since we cannot gather complete and accurate coverage.
-          // No coverage will be submitted, and ITR will not skip this test.
-          return null;
+          continue;
         }
         coveredPaths.add(resourcePath);
       }
diff --git a/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/coverage/line/LineCoverageStore.java b/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/coverage/line/LineCoverageStore.java
@@ -80,9 +80,7 @@ protected TestReport report(
               "Skipping coverage reporting for {} because source path could not be determined",
               className);
           metrics.add(CiVisibilityCountMetric.CODE_COVERAGE_ERRORS, 1, CoverageErrorType.PATH);
-          // Abort, since we cannot gather complete and accurate coverage.
-          // No coverage will be submitted, and ITR will not skip this test.
-          return null;
+          continue;
         }
 
         try (InputStream is = Utils.getClassStream(clazz)) {
@@ -126,9 +124,7 @@ protected TestReport report(
               "Skipping coverage reporting for {} because resource path could not be determined",
               nonCodeResource);
           metrics.add(CiVisibilityCountMetric.CODE_COVERAGE_ERRORS, 1, CoverageErrorType.PATH);
-          // Abort, since we cannot gather complete and accurate coverage.
-          // No coverage will be submitted, and ITR will not skip this test.
-          return null;
+          continue;
         }
         fileEntries.add(new TestReportFileEntry(resourcePath, Collections.emptyList()));
       }

Original file line number	Diff line number	Diff line change
`@@ -67,9 +67,7 @@ protected TestReport report(`
`67`	`67`	`"Skipping coverage reporting for {} because source path could not be determined",`
`68`	`68`	`clazz);`
`69`	`69`	`metrics.add(CiVisibilityCountMetric.CODE_COVERAGE_ERRORS, 1, CoverageErrorType.PATH);`
`70`		`- // Abort, since we cannot gather complete and accurate coverage.`
`71`		`- // No coverage will be submitted, and ITR will not skip this test.`
`72`		`- return null;`
	`70`	`+ continue;`
`73`	`71`	`}`
`74`	`72`	`coveredPaths.add(sourcePath);`
`75`	`73`	`}`
`@@ -81,9 +79,7 @@ protected TestReport report(`
`81`	`79`	`"Skipping coverage reporting for {} because resource path could not be determined",`
`82`	`80`	`nonCodeResource);`
`83`	`81`	`metrics.add(CiVisibilityCountMetric.CODE_COVERAGE_ERRORS, 1, CoverageErrorType.PATH);`
`84`		`- // Abort, since we cannot gather complete and accurate coverage.`
`85`		`- // No coverage will be submitted, and ITR will not skip this test.`
`86`		`- return null;`
	`82`	`+ continue;`
`87`	`83`	`}`
`88`	`84`	`coveredPaths.add(resourcePath);`
`89`	`85`	`}`