fix(csi): Avoid clearing temporary file twice

PerfectSlayer · PerfectSlayer · commit 54a1da4b19ee · 2024-04-17T10:55:34.000+02:00
newTempFile clears existing files as withWriter does. Avoid doing twice for build performance.
diff --git a/buildSrc/src/main/groovy/CallSiteInstrumentationPlugin.groovy b/buildSrc/src/main/groovy/CallSiteInstrumentationPlugin.groovy
@@ -88,12 +88,10 @@ class CallSiteInstrumentationPlugin implements Plugin<Project> {
 
   private static File newTempFile(final File folder, final String name) {
     final file = new File(folder, name)
-    file.deleteOnExit()
-    if (file.exists()) {
-      file.text = ''
-    } else if (!file.createNewFile()) {
+    if (!file.exists() && !file.createNewFile()) {
       throw new GradleException("Cannot create temporary file: $file")
     }
+    file.deleteOnExit()
     return file
   }
 

Original file line number	Diff line number	Diff line change
`@@ -88,12 +88,10 @@ class CallSiteInstrumentationPlugin implements Plugin<Project> {`
`88`	`88`
`89`	`89`	`private static File newTempFile(final File folder, final String name) {`
`90`	`90`	`final file = new File(folder, name)`
`91`		`- file.deleteOnExit()`
`92`		`- if (file.exists()) {`
`93`		`- file.text = ''`
`94`		`- } else if (!file.createNewFile()) {`
	`91`	`+ if (!file.exists() && !file.createNewFile()) {`
`95`	`92`	`throw new GradleException("Cannot create temporary file: $file")`
`96`	`93`	`}`
	`94`	`+ file.deleteOnExit()`
`97`	`95`	`return file`
`98`	`96`	`}`
`99`	`97`