fix AppSecDispatcherServlet Instrumentations

jandro996 · jandro996 · commit 2a14d7afa19c · 2025-09-26T17:14:27.000+02:00
diff --git a/dd-java-agent/instrumentation/spring/spring-webmvc/spring-webmvc-3.1/src/main/java/datadog/trace/instrumentation/springweb/AppSecDispatcherServletInstrumentation.java b/dd-java-agent/instrumentation/spring/spring-webmvc/spring-webmvc-3.1/src/main/java/datadog/trace/instrumentation/springweb/AppSecDispatcherServletInstrumentation.java
@@ -13,6 +13,7 @@
 import datadog.trace.agent.tooling.InstrumenterModule;
 import datadog.trace.api.Config;
 import datadog.trace.api.telemetry.EndpointCollector;
+import java.util.HashMap;
 import java.util.Map;
 import net.bytebuddy.asm.Advice;
 import net.bytebuddy.matcher.ElementMatcher;
@@ -71,13 +72,16 @@ public static class AppSecHandlerMappingAdvice {
 
     @Advice.OnMethodExit(suppress = Throwable.class)
     public static void afterRefresh(@Advice.Argument(0) final ApplicationContext springCtx) {
-      final RequestMappingHandlerMapping handler =
-          springCtx.getBean(RequestMappingHandlerMapping.class);
-      if (handler == null) {
+      final Map<String, RequestMappingHandlerMapping> handlers =
+          springCtx.getBeansOfType(RequestMappingHandlerMapping.class);
+      if (handlers == null || handlers.isEmpty()) {
         return;
       }
-      final Map<RequestMappingInfo, HandlerMethod> mappings = handler.getHandlerMethods();
-      if (mappings == null || mappings.isEmpty()) {
+      final Map<RequestMappingInfo, HandlerMethod> mappings = new HashMap<>();
+      for (RequestMappingHandlerMapping mapping : handlers.values()) {
+        mappings.putAll(mapping.getHandlerMethods());
+      }
+      if (mappings.isEmpty()) {
         return;
       }
       EndpointCollector.get().supplier(new RequestMappingInfoIterator(mappings));
diff --git a/dd-java-agent/instrumentation/spring/spring-webmvc/spring-webmvc-5.3/src/main/java/datadog/trace/instrumentation/springweb/AppSecDispatcherServletWithPathPatternsInstrumentation.java b/dd-java-agent/instrumentation/spring/spring-webmvc/spring-webmvc-5.3/src/main/java/datadog/trace/instrumentation/springweb/AppSecDispatcherServletWithPathPatternsInstrumentation.java
@@ -12,6 +12,7 @@
 import datadog.trace.agent.tooling.InstrumenterModule;
 import datadog.trace.api.Config;
 import datadog.trace.api.telemetry.EndpointCollector;
+import java.util.HashMap;
 import java.util.Map;
 import net.bytebuddy.asm.Advice;
 import net.bytebuddy.matcher.ElementMatcher;
@@ -66,13 +67,16 @@ public static class AppSecHandlerMappingAdvice {
 
     @Advice.OnMethodExit(suppress = Throwable.class)
     public static void afterRefresh(@Advice.Argument(0) final ApplicationContext springCtx) {
-      final RequestMappingHandlerMapping handler =
-          springCtx.getBean(RequestMappingHandlerMapping.class);
-      if (handler == null) {
+      final Map<String, RequestMappingHandlerMapping> handlers =
+          springCtx.getBeansOfType(RequestMappingHandlerMapping.class);
+      if (handlers == null || handlers.isEmpty()) {
         return;
       }
-      final Map<RequestMappingInfo, HandlerMethod> mappings = handler.getHandlerMethods();
-      if (mappings == null || mappings.isEmpty()) {
+      final Map<RequestMappingInfo, HandlerMethod> mappings = new HashMap<>();
+      for (RequestMappingHandlerMapping mapping : handlers.values()) {
+        mappings.putAll(mapping.getHandlerMethods());
+      }
+      if (mappings.isEmpty()) {
         return;
       }
       EndpointCollector.get().supplier(new RequestMappingInfoWithPathPatternsIterator(mappings));
