Skip to content

Commit 22e9fef

Browse files
authored
Remove unused arguments and methods from async AdviceUtils (#7397)
1 parent 88ff5a6 commit 22e9fef

26 files changed

Lines changed: 31 additions & 43 deletions

File tree

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/java/concurrent/AdviceUtils.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import datadog.trace.bootstrap.ContextStore;
66
import datadog.trace.bootstrap.instrumentation.api.AgentScope;
7-
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
87

98
/** Helper utils for Runnable/Callable instrumentation */
109
public class AdviceUtils {
@@ -19,10 +18,10 @@ public class AdviceUtils {
1918
*/
2019
public static <T> AgentScope startTaskScope(
2120
final ContextStore<T, State> contextStore, final T task) {
22-
return startTaskScope(contextStore.get(task), false);
21+
return startTaskScope(contextStore.get(task));
2322
}
2423

25-
public static AgentScope startTaskScope(State state, boolean migrated) {
24+
public static AgentScope startTaskScope(State state) {
2625
if (state != null) {
2726
final AgentScope.Continuation continuation = state.getAndResetContinuation();
2827
if (continuation != null) {
@@ -50,16 +49,7 @@ public static <T> void cancelTask(ContextStore<T, State> contextStore, final T t
5049
}
5150
}
5251

53-
public static <T> AgentSpan getCapturedSpan(ContextStore<T, State> contextStore, final T task) {
54-
State state = contextStore.get(task);
55-
if (null != state) {
56-
return state.getSpan();
57-
}
58-
return null;
59-
}
60-
61-
public static <T> void capture(
62-
ContextStore<T, State> contextStore, T task, boolean startThreadMigration) {
52+
public static <T> void capture(ContextStore<T, State> contextStore, T task) {
6353
AgentScope activeScope = activeScope();
6454
if (null != activeScope && activeScope.isAsyncPropagating()) {
6555
State state = contextStore.get(task);

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/java/concurrent/TPEHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public static boolean shouldPropagate(
7474

7575
public static void capture(ContextStore<Runnable, State> contextStore, Runnable task) {
7676
if (task != null && !exclude(RUNNABLE, task)) {
77-
AdviceUtils.capture(contextStore, task, true);
77+
AdviceUtils.capture(contextStore, task);
7878
}
7979
}
8080

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaEnvelopeInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void methodAdvice(MethodTransformer transformer) {
3939
public static class ConstructAdvice {
4040
@Advice.OnMethodExit(suppress = Throwable.class)
4141
public static void afterInit(@Advice.This Envelope zis) {
42-
capture(InstrumentationContext.get(Envelope.class, State.class), zis, true);
42+
capture(InstrumentationContext.get(Envelope.class, State.class), zis);
4343
}
4444
}
4545
}

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaForkJoinExecutorTaskInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void methodAdvice(MethodTransformer transformer) {
5151
public static final class Construct {
5252
@Advice.OnMethodExit
5353
public static void construct(@Advice.Argument(0) Runnable wrapped) {
54-
capture(InstrumentationContext.get(Runnable.class, State.class), wrapped, true);
54+
capture(InstrumentationContext.get(Runnable.class, State.class), wrapped);
5555
}
5656
}
5757

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaForkJoinPoolInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public static final class ExternalPush {
4646
@Advice.OnMethodEnter
4747
public static <T> void externalPush(@Advice.Argument(0) ForkJoinTask<T> task) {
4848
if (!exclude(FORK_JOIN_TASK, task)) {
49-
capture(InstrumentationContext.get(ForkJoinTask.class, State.class), task, true);
49+
capture(InstrumentationContext.get(ForkJoinTask.class, State.class), task);
5050
}
5151
}
5252

dd-java-agent/instrumentation/akka-concurrent/src/main/java/datadog/trace/instrumentation/akka/concurrent/AkkaForkJoinTaskInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public static void after(@Advice.Enter AgentScope scope) {
103103
public static final class Fork {
104104
@Advice.OnMethodEnter
105105
public static <T> void fork(@Advice.This ForkJoinTask<T> task) {
106-
capture(InstrumentationContext.get(ForkJoinTask.class, State.class), task, true);
106+
capture(InstrumentationContext.get(ForkJoinTask.class, State.class), task);
107107
}
108108
}
109109

dd-java-agent/instrumentation/elasticsearch/transport/src/main/java/datadog/trace/instrumentation/elasticsearch/ThreadedActionListenerInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ public void methodAdvice(MethodTransformer transformer) {
5454
public static final class Construct {
5555
@Advice.OnMethodExit
5656
public static void after(@Advice.This ThreadedActionListener listener) {
57-
capture(
58-
InstrumentationContext.get(ThreadedActionListener.class, State.class), listener, true);
57+
capture(InstrumentationContext.get(ThreadedActionListener.class, State.class), listener);
5958
}
6059
}
6160

dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/QueuedCommandInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public static final class Construct {
6565
@Advice.OnMethodExit(suppress = Throwable.class)
6666
public static void after(@Advice.This Object command) {
6767
ContextStore<Object, State> contextStore = InstrumentationContext.get(QUEUED_COMMAND, STATE);
68-
capture(contextStore, command, false);
68+
capture(contextStore, command);
6969
QueueTimerHelper.startQueuingTimer(contextStore, Channel.class, command);
7070
}
7171
}

dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/client/MessagesAvailableInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public void methodAdvice(MethodTransformer transformer) {
6060
public static final class Capture {
6161
@Advice.OnMethodExit
6262
public static void capture(@Advice.This Runnable task) {
63-
AdviceUtils.capture(InstrumentationContext.get(Runnable.class, State.class), task, true);
63+
AdviceUtils.capture(InstrumentationContext.get(Runnable.class, State.class), task);
6464
}
6565
}
6666

dd-java-agent/instrumentation/java-concurrent/java-completablefuture/src/main/java/datadog/trace/instrumentation/java/completablefuture/AsyncTaskInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void methodAdvice(MethodTransformer transformer) {
7272
public static class Construct {
7373
@Advice.OnMethodExit
7474
public static void construct(@Advice.This ForkJoinTask<?> task) {
75-
capture(InstrumentationContext.get(ForkJoinTask.class, State.class), task, true);
75+
capture(InstrumentationContext.get(ForkJoinTask.class, State.class), task);
7676
}
7777
}
7878

0 commit comments

Comments
 (0)