Fix jar uploading to use shadow jar instead of default

tylerbenson · tylerbenson · commit 02d8f153a619 · 2017-07-20T09:58:22.000-07:00
Rename default jar to be explicit that no dependencies are embedded.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -14,7 +14,7 @@ jobs:
 
       - run:
           name: Run Tests
-          command: ./gradlew clean shadowJar check --parallel
+          command: ./gradlew clean check --parallel
 
       - save_cache:
           paths:
diff --git a/dd-java-agent-ittests/dd-java-agent-ittests.gradle b/dd-java-agent-ittests/dd-java-agent-ittests.gradle
@@ -37,7 +37,7 @@ dependencies {
 
 test {
   jvmArgs "-Ddd.trace.configurationFile=${project.buildDir}/resources/test/dd-trace.yaml"
-  jvmArgs "-javaagent:${project(':dd-java-agent').buildDir}/libs/dd-java-agent-${project.version}-shadow.jar"
+  jvmArgs "-javaagent:${project(':dd-java-agent').buildDir}/libs/dd-java-agent-${project.version}.jar"
   jvmArgs "-Dorg.jboss.byteman.verbose=true"
 }
 
diff --git a/dd-java-agent/dd-java-agent.gradle b/dd-java-agent/dd-java-agent.gradle
@@ -71,6 +71,8 @@ dependencies {
 }
 
 jar {
+  classifier = 'unbundled'
+
   manifest {
     attributes(
       // I don't think we want to define this since we can't really load after startup:
@@ -88,16 +90,15 @@ jar {
 shadowJar {
   append 'otarules.btm'
 
-  classifier 'shadow'
+  classifier null
 
 //    mergeServiceFiles()
 
   // Various tests fail when these are uncommented:
-//    relocate 'ch.qos.logback', 'dd.deps.ch.qos.logback'
 //    relocate 'com.google', 'dd.deps.com.google'
 //    relocate 'org.jboss.byteman', 'dd.deps.org.jboss.byteman'
-//    relocate 'org.slf4j', 'dd.deps.org.slf4j'
 
+  // Don't relocate slf4j or opentracing deps.
   relocate 'com.fasterxml', 'dd.deps.com.fasterxml'
   relocate 'javassist', 'dd.deps.javassist'
   relocate 'org.reflections', 'dd.deps.org.reflections'
diff --git a/dd-trace/dd-trace.gradle b/dd-trace/dd-trace.gradle
@@ -36,11 +36,16 @@ dependencies {
   jmh 'commons-io:commons-io:2.4'
 }
 
+jar {
+  classifier = 'unbundled'
+}
+
 shadowJar {
 //    mergeServiceFiles()
 
-  classifier 'shadow'
+  classifier null
 
+  // Don't relocate slf4j or opentracing deps.
   relocate 'com.fasterxml', 'dd.deps.com.fasterxml'
   relocate 'com.google', 'dd.deps.com.google'
   relocate 'javassist', 'dd.deps.javassist'
diff --git a/gradle/java.gradle b/gradle/java.gradle
@@ -17,7 +17,6 @@ tasks.withType(Javadoc) {
   options.encoding = "utf-8"
   options.docEncoding = "utf-8"
   options.charSet = "utf-8"
-  exclude "**/internal/**"
 
   options.addStringOption('Xdoclint:none', '-quiet')
 
@@ -51,10 +50,19 @@ task javaDocJar(type: Jar, dependsOn: javadoc) {
 }
 
 artifacts {
-  archives jar
   archives sourceJar
   archives javaDocJar
 }
 
+if (project.plugins.hasPlugin('com.github.johnrengelman.shadow')) {
+  // Remove the no-deps jar from the archives to prevent publication
+  configurations.archives.with {
+    artifacts.remove artifacts.find { it.archiveTask.is jar }
+  }
+  artifacts {
+    archives shadowJar
+  }
+}
+
 apply from: "$rootDir/gradle/checkstyle.gradle"
 apply from: "$rootDir/gradle/codenarc.gradle"
diff --git a/gradle/util.gradle b/gradle/util.gradle
@@ -0,0 +1,13 @@
+task artifacts {
+  group = "Help"
+  description = "Displays the artifacts associated with each configuration of " + project
+  doFirst {
+    configurations.findAll().each { config ->
+      println "${config}:"
+      config.allArtifacts.getFiles().each { file ->
+        println " " + file
+      }
+      println ' '
+    }
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ dependencies {`
`37`	`37`
`38`	`38`	`test {`
`39`	`39`	`jvmArgs "-Ddd.trace.configurationFile=${project.buildDir}/resources/test/dd-trace.yaml"`
`40`		`- jvmArgs "-javaagent:${project(':dd-java-agent').buildDir}/libs/dd-java-agent-${project.version}-shadow.jar"`
	`40`	`+ jvmArgs "-javaagent:${project(':dd-java-agent').buildDir}/libs/dd-java-agent-${project.version}.jar"`
`41`	`41`	`jvmArgs "-Dorg.jboss.byteman.verbose=true"`
`42`	`42`	`}`
`43`	`43`