contrib/jinzhu/gorm: Add err check#806
Merged
Merged
Conversation
knusbaum
requested changes
Jan 7, 2021
knusbaum
left a comment
knusbaum
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good. Please upmerge to the latest v1 to get the CI to pass.
dianashevchenko
pushed a commit
that referenced
this pull request
Feb 8, 2021
This commit adds the WithErrorCheck option, which allows users to specify a function that will determine whether a given gorm error should be marked as an error in the span.
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An implementation of #805