Skip to content

ci(benchmarks): support BP_EXTERNAL_S3_URL override for uploads#5003

Merged
igoragoli merged 3 commits into
mainfrom
augusto/external-s3-url-override
Jul 9, 2026
Merged

ci(benchmarks): support BP_EXTERNAL_S3_URL override for uploads#5003
igoragoli merged 3 commits into
mainfrom
augusto/external-s3-url-override

Conversation

@igoragoli

@igoragoli igoragoli commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an opt-in BP_EXTERNAL_S3_URL override to the microbenchmark upload path (.gitlab/benchmarks/micro/gitlab-ci.yml). When set, it overrides the S3 destination prefix for the artifact upload. When unset, the existing path is used unchanged.

The value is used as-is when set; an empty value falls back to the existing default destination.

Motivation

APMSP-2893 Set up flaky benchmark monitoring

  • benchmarking-platform-tools will orchestrate dd-trace-go benchmark jobs for monitoring benchmark health and needs results uploaded under a s3 URL it controls.
  • The override lets the orchestrator pass that prefix in via an env var, without changing default behavior.

This mirrors the same change on dd-trace-js: DataDog/dd-trace-js#9155

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 9, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 62.56% (+11.16%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8c573fe | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-09 08:30:25

Comparing candidate commit 8c573fe in PR branch augusto/external-s3-url-override with baseline commit 6e17d8c in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 325 metrics, 0 unstable metrics, 1 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:BenchmarkPartialFlushing/Enabled

  • 🟥 avgHeapInUse(Mb) [+0.584MB; +2.150MB] or [+2.030%; +7.468%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

Known flaky benchmarks without significant changes:

  • scenario:BenchmarkOTLPTraceWriterFlush

@igoragoli
igoragoli marked this pull request as ready for review July 9, 2026 06:53
@igoragoli
igoragoli requested review from a team as code owners July 9, 2026 06:53
@igoragoli
igoragoli merged commit f0fa5a7 into main Jul 9, 2026
185 checks passed
@igoragoli
igoragoli deleted the augusto/external-s3-url-override branch July 9, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igoragoli @genesor