fix(internal/civisibility): fix agent UDS requests by tonyredondo · Pull Request #4852 · DataDog/dd-trace-go

tonyredondo · 2026-06-04T10:28:55Z

What does this PR do?

Fixes the CI Visibility helper client when DD_TRACE_AGENT_URL is configured with a Unix domain socket. The helper client now captures the raw socket path before rewriting the base URL to the synthetic UDS host and reuses the shared internal.UDSClient and internal.UnixDataSocketURL helpers.

Adds agent-mode UDS coverage for the CI Visibility helper endpoints: settings, known tests, search commits, skippable tests, test management, packfile upload, coverage upload, and logs upload.

Motivation

The previous UDS branch built a custom dialer that closed over agentURL.Path, then reassigned agentURL to the synthetic HTTP URL. By request time agentURL.Path was empty, causing agent-mode requests to fail with dial unix: missing address.

Testing

go test ./internal/civisibility/utils/net -run 'TestClientAgentModeUDS' -count=1
go test ./internal/civisibility/utils/net -count=1
go test -race ./internal/civisibility/utils/net -count=1
go test ./internal -run 'TestUnixDataSocketURL|TestUDSClientTransportConfig|TestUDSConcurrentConnectionReuse|TestUDSServerCloseRecovery' -count=1
go test ./ddtrace/tracer -run 'TestCiVisibilityTransport|TestCIVisibilityTransportSecureLogging' -count=1
go test ./internal/civisibility/... -count=1
go test -race ./internal/civisibility/... -count=1
git diff --check

codecov · 2026-06-04T10:33:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.63%. Comparing base (72b6fb0) to head (b964609).

Additional details and impacted files

Files with missing lines	Coverage Δ
internal/civisibility/utils/net/client.go	`93.18% <100.00%> (+11.11%)`	⬆️

... and 287 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

datadog-official · 2026-06-04T10:33:53Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 62.99% (+0.03%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: a279241 | Docs | Datadog PR Page | Give us feedback!}

pr-commenter · 2026-06-04T10:53:24Z

Benchmarks

Benchmark execution time: 2026-06-04 12:08:15

Comparing candidate commit a279241 in PR branch feat/ci-visibility-uds-client with baseline commit 72b6fb0 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 297 metrics, 2 unstable metrics, 1 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

Known flaky benchmarks without significant changes:

scenario:BenchmarkOTLPTraceWriterFlush

Copilot

Pull request overview

Fixes CI Visibility’s internal helper client when DD_TRACE_AGENT_URL is configured as a Unix domain socket by ensuring the raw socket path is preserved and reused via shared internal.UDSClient / internal.UnixDataSocketURL helpers, and adds agent-mode UDS regression coverage for the CI Visibility helper endpoints.

Changes:

Replace the custom UDS transport/dialer logic with internal.UDSClient(...) and base URL rewriting via internal.UnixDataSocketURL(...).
Add comprehensive agent-mode UDS tests covering settings, known tests, search commits, skippable tests, test management, packfile upload, coverage upload, and logs upload endpoints.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
internal/civisibility/utils/net/client.go	Switch agent-mode UDS handling to shared internal helpers to avoid losing the socket path.
internal/civisibility/utils/net/uds_client_test.go	Add end-to-end UDS agent-mode coverage for all CI Visibility helper endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tonyredondo · 2026-06-04T11:47:58Z

@codex review

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

chatgpt-codex-connector · 2026-06-04T11:50:24Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### What does this PR do? Fixes the CI Visibility helper client when DD_TRACE_AGENT_URL is configured with a Unix domain socket. The helper client now captures the raw socket path before rewriting the base URL to the synthetic UDS host and reuses the shared internal.UDSClient and internal.UnixDataSocketURL helpers. Adds agent-mode UDS coverage for the CI Visibility helper endpoints: settings, known tests, search commits, skippable tests, test management, packfile upload, coverage upload, and logs upload. ### Motivation The previous UDS branch built a custom dialer that closed over agentURL.Path, then reassigned agentURL to the synthetic HTTP URL. By request time agentURL.Path was empty, causing agent-mode requests to fail with dial unix: missing address. ### Testing - go test ./internal/civisibility/utils/net -run 'TestClientAgentModeUDS' -count=1 - go test ./internal/civisibility/utils/net -count=1 - go test -race ./internal/civisibility/utils/net -count=1 - go test ./internal -run 'TestUnixDataSocketURL|TestUDSClientTransportConfig|TestUDSConcurrentConnectionReuse|TestUDSServerCloseRecovery' -count=1 - go test ./ddtrace/tracer -run 'TestCiVisibilityTransport|TestCIVisibilityTransportSecureLogging' -count=1 - go test ./internal/civisibility/... -count=1 - go test -race ./internal/civisibility/... -count=1 - git diff --check Co-authored-by: tony.redondo <[email protected]>

tonyredondo force-pushed the feat/ci-visibility-uds-client branch from b964609 to d96103d Compare June 4, 2026 11:27

tonyredondo marked this pull request as ready for review June 4, 2026 11:30

tonyredondo requested a review from a team as a code owner June 4, 2026 11:30

juan-fernandez approved these changes Jun 4, 2026

View reviewed changes

anmarchenko approved these changes Jun 4, 2026

View reviewed changes

tonyredondo requested a review from Copilot June 4, 2026 11:36

Copilot started reviewing on behalf of tonyredondo June 4, 2026 11:36 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread internal/civisibility/utils/net/uds_client_test.go

fix(internal/civisibility): fix agent UDS requests

a279241

tonyredondo force-pushed the feat/ci-visibility-uds-client branch from d96103d to a279241 Compare June 4, 2026 11:42

tonyredondo requested a review from Copilot June 4, 2026 11:45

Copilot started reviewing on behalf of tonyredondo June 4, 2026 11:46 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Jun 4, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 31d85a6 into main Jun 4, 2026
165 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Jun 4, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the feat/ci-visibility-uds-client branch June 4, 2026 12:24

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Jun 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(internal/civisibility): fix agent UDS requests#4852

fix(internal/civisibility): fix agent UDS requests#4852
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
feat/ci-visibility-uds-client

tonyredondo commented Jun 4, 2026

Uh oh!

codecov Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

datadog-official Bot commented Jun 4, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

Uh oh!

pr-commenter Bot commented Jun 4, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Known flaky benchmarks

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

tonyredondo commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tonyredondo commented Jun 4, 2026

What does this PR do?

Motivation

Testing

Uh oh!

codecov Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

datadog-official Bot commented Jun 4, 2026 • edited by datadog-prod-us1-3 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

Known flaky benchmarks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

tonyredondo commented Jun 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot commented Jun 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Jun 4, 2026 •

edited

Loading

datadog-official Bot commented Jun 4, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

pr-commenter Bot commented Jun 4, 2026 •

edited

Loading